522009 - [tr] Choose search plug-ins for Fennec in Turkish

Status: RESOLVED FIXED

(Mozilla Localizations :: tr / Turkish, defect)

Description

[Staś Małolepszy :stas]

You've indicated an interest in participating in the localization of mobile Firefox (aka Fennec). We want to ship Fennec with a good list of search engines for Turkish. As the technical details of implementation are being worked on, we'd like to start the discussion about the choice of search engines. This bug is about agreeing on a set of search engines, and will not tackle the implementation (at least not yet).

First, the localization team and Staś will look at the market for the locale and come up with a good set of search providers. The guidelines for making recommendations are on https://wiki.mozilla.org/L10n:Mobile/Productization. You're welcome to suggest engines already shipped in desktop Firefox for Turkish, if they fit well in the categories outlined on the wiki.

For en-US, we currently use the following set, which may serve as an inspiration:
Google, Wikipedia, Amazon, Yahoo, Twitter.

Note that according to the guidelines, for some categories it may be better to leave them empty than to ship with en engine that's irrelevant or unavailable in your region.

After we decided on a particular search engine, we will need to test it in Fennec. You can test on a mobile device and on the desktop (download the builds from <http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/>). Staś will help with testing on a device, too. If the service works fine, Staś will contact the owner and ask for permission, and for specifics like proper search flags. We'll likely need your help to at least get the contact information if we don't have them already.

We don't know the implementation details yet, so for now, please don't create patches nor land anything. We will keep you posted as we figure out the how's and when's.

Thanks.

Comment 1

[Seth Bindernagel]

Hi Guys:  Just a friendly reminder, as we move closer to the general availability date for Fennec in mid-December, has your team had any chance to consider search providers?  Thanks!

Comment 2

[Rail Aliiev [:rail]]

Seth, thanks for the reminder. I'll discuss this issue with other community members.

Comment 3

[Rail Aliiev [:rail]]

BTW, is there any recommendation how many sites we need to use? At least from UI consistency POV.

IMO, at least Google, Wikipedia and Yahoo can be used as is.

Comment 4

[Staś Małolepszy :stas]

Rail: the max that we're recommending is 5. The minimum: probably 3. Please see https://wiki.mozilla.org/L10n:Mobile/Productization for more details.

Comment 5

[Staś Małolepszy :stas]

Attachment: Bootstrapping search engines with Google, localized Wikipedia and Twitter

Here's a patch resetting the mobile/searchplugins/ directory to a minimal set of search engines that we would like to ship your locale with. Please read this comment carefully before you land this patch.

*Important*: There has been a change to how we use the  <Description/> elements present in the plug-ins (see bug 528655 and bug 529869). We want to emphasize that the search is integrated with the browser to better reflect what a search plugin is and what it does. You will need to edit the Wikipedia plug-in before you commit this patch. Please read <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions> for detailed instructions.

For Google and Twitter, we don't have to copy the XML files to your mobile/searchplugins/ directory. Plugins identical to en-US are pulled from source automatically. It's enough to put the engine's name in list.txt for this to work (which I did). I also updated the Wikipedia plug-in to use a bigger icon, see bug 517997 for details.

Please edit the Wikipedia plug-in and commit this patch before you opt-in in the mozilla.dev.l10n newsgroup. Opt-ins without this patch will not be taken. This does not mean that we don't want to include other search engines. On the contrary, the work and the discussion will continue in this bug until we choose a good set of search engines for your locale. Then, you will be able to opt in again, so that in the final release we include more search engines than the mineral set from this patch.

This patch is simply meant to reset your mobile/searchplugins directory so that we keep the repository clean and happy.

Thanks for understanding!

Comment 6

[Rail Aliiev [:rail]]

Staś:

Thanks for pinging. We've discussed the list of search engines and somehow our list is the same as yours. :)

I've committed 
http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/tr/rev/0c7b5af807de
to reflect your patch, with some modifications for Wikipedia's search URL (which is fully translated now).

My local build contains Google and Twitter only (see next attachment), let's wait for nightly build.

Comment 7

[Rail Aliiev [:rail]]

Attachment: Fennec search engines (tr)

Comment 8

[Rail Aliiev [:rail]]

Hmm, seems like 
chrome/tr.jar!locale/tr/browser/searchplugins/list.txt file is delivered from en-US, not from tr, while *.xml files delivered as expected. FYI.

Comment 9

[Rail Aliiev [:rail]]

Another question:
Can I change <ShortName> from "Wikipedia (tr)" to more usual "Vikipedi"?

Comment 10

[Rail Aliiev [:rail]]

And nightly build (built against latest l10n) doesn't contain (probably yet) any search plug-in.

Comment 11

[Staś Małolepszy :stas]

(In reply to comment #6)
> Staś:
> 
> Thanks for pinging. We've discussed the list of search engines and somehow our
> list is the same as yours. :)

:)

> 
> I've committed 
> http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/tr/rev/0c7b5af807de
> to reflect your patch, with some modifications for Wikipedia's search URL
> (which is fully translated now).

Thanks for doing that. Did you made the change to Wikipedia's <Description/>?

(In reply to comment #9)
> Another question:
> Can I change <ShortName> from "Wikipedia (tr)" to more usual "Vikipedi"?

No, please don't do that (and thanks for asking). tr.wikipedia.org uses "Wikipedia (tr)" and by using the same in the plugin, we make Firefox know that it has this plugin installed already.

I'll investigate the issue with the nightlies.

Comment 12

[Rail Aliiev [:rail]]

(In reply to comment #11)
> Thanks for doing that. Did you made the change to Wikipedia's <Description/>?

I've just uncommented it, no changes in the content.

And again, argh, I forgot to add "special" commit subject with "r=". :( Have to investigate the rules and add a hg hook.

Comment 13

[Staś Małolepszy :stas]

Regarding Wikipedia's description: actually, the recommendation was to either:
- change the content to say that the enigne is integrated, or
- remove the description line completely (Fennec will display a generic "Integrated search" description in its place).

Rail, would mind changing wikipedia's description in one of these two ways? Thanks.

Comment 14

[Rail Aliiev [:rail]]

Done,
http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/tr/rev/b030d1d86e03