Closed Bug 522063 Opened 11 years ago Closed 11 years ago

Advanced proxy preferences dialog is cut off in SM 2.0 RC1 Russian build on Windows XP Luna/Windows Vista with default theme

Categories

(Core :: Widget: Win32, defect)

All
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: unghost, Assigned: neil)

Details

Attachments

(4 files)

Attached image Screenshot
Advanced proxy preferences dialog is cut off in SM 2.0 RC1 Russian build. This is problem on Windows only. Linux looks fine. I don't have Mac.
I was able to workaround this issue with CSS hack for 2.0 ( http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/ru/rev/4c3c3f610eff ), but AFAIK CSS hacks is frowned upon.
May be this is fallout from fix for Bug 484622, but I don't have time to test right now.
The question is what label makes it grow that way and what we can do about it.

Neil fixed bug 484622, so CCing him here.
The screen shot shows XP Luna, right? Do you know if the problem occurs with XP in Classic theme, or using the Modern theme? Does the problem occur with a Russian language pack applied to a US build? If so, where can I download it?
(In reply to comment #2)
> The screen shot shows XP Luna, right? Do you know if the problem occurs with XP in Classic theme, or using the Modern theme?
I've found out that problem happens on Windows XP Luna/Windows Vista with default theme. On Windows XP Classic with any theme/Windows XP Luna with Modern theme everything is fine.

Preferences window is cut off on:
Windows XP Luna with default theme.
Windows Vista with default theme (I've forgot to test Modern :-().

Preferences window is fine on:
Windows XP Luna with Modern theme.
Windows XP Classic with any theme.
Windows 2000 with default theme (I've forgot to test Modern :-().

(In reply to comment #2)
> Does the problem occur with a Russian language pack applied to a US build?
Yes.

(In reply to comment #2)
> If so, where can I download it?
http://releases.mozilla.org/pub/mozilla.org/seamonkey/releases/2.0rc1/langpack/seamonkey-2.0rc1.ru.langpack.xpi
Hardware: x86 → All
Summary: Advanced proxy preferences dialog is cut off in SM 2.0 RC1 Russian build for Windows → Advanced proxy preferences dialog is cut off in SM 2.0 RC1 Russian build on Windows XP Luna/Windows Vista with default theme
OK, so fortunately the problem also appears in the US locale, but it's nowhere near so obvious, and you can at least just about see all of the controls.

If I add some userChrome.css to disable native theming of groupboxes then everything works properly, so this looks like being a core bug :-(
This is the groupbox version of bug 482955.
Component: Preferences → Widget: Win32
Product: SeaMonkey → Core
QA Contact: preferences → win32
Attached patch Proposed patchSplinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #406279 - Flags: review?(jmathies)
Attachment #406279 - Flags: review?(jmathies) → review+
Pushed changeset be47d2144b8a to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 406279 [details] [diff] [review]
Proposed patch

This is needed to make native themed groupboxes compute their intrinsic size correctly.
Attachment #406279 - Flags: approval1.9.2?
Comment on attachment 406279 [details] [diff] [review]
Proposed patch

Pushing approval request to the next branch release.

This fix may improve the appearance of Firefox or its extensions in some cases.
Attachment #406279 - Flags: approval1.9.2.1?
Attachment #406279 - Flags: approval1.9.2?
Comment on attachment 406279 [details] [diff] [review]
Proposed patch

Didn't make 1.9.2.2, we should take this in 1.9.2.3
Attachment #406279 - Flags: approval1.9.2.2? → approval1.9.2.3?
Attachment #406279 - Flags: approval1.9.2.4? → approval1.9.2.8?
Comment on attachment 406279 [details] [diff] [review]
Proposed patch

a=LegNeato for 1.9.2.9.
Attachment #406279 - Flags: approval1.9.2.9? → approval1.9.2.9+
Comment on attachment 406279 [details] [diff] [review]
Proposed patch

Removing .9 approval as this missed landing before freeze. Feel free to nominate again, though the bar for approval will be higher.
Attachment #406279 - Flags: approval1.9.2.9+ → approval1.9.2.9-
You need to log in before you can comment on or make changes to this bug.