Closed
Bug 522188
Opened 15 years ago
Closed 15 years ago
lightweight theme install doesn't "stick"
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.9.3a1
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta4-fixed |
People
(Reporter: bws42, Assigned: dao)
References
Details
(Keywords: verified1.9.2, Whiteboard: patch in bug 520346)
Attachments
(3 files)
387.00 KB,
image/png
|
Details | |
1.83 KB,
patch
|
Details | Diff | Splinter Review | |
758 bytes,
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20091013 Minefield/3.7a1pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20091013 Minefield/3.7a1pre 1. Go to http://www.getpersonas.com 2. Install a persona. 3. Hover over another persona, it should change as expected. 4. Mouse away from the persona, it should revert to the persona installed in #1. 5. Install a new persona, it should change as expected. 6. Hover over any persona, then move away, the theme will revert to persona installed in #1 instead of #5. The Theme manager (UI) thinks that the correct persona is installed (see attached pic). Reproducible: Always
Reporter | ||
Comment 1•15 years ago
|
||
I did not investigate a regression range since the functionality is so new.
Comment 2•15 years ago
|
||
I noticed this too, but only happened if I was also running GetPersonas Addon which takes ownership before LWThemes in Theme manager. Are you running GetPersonas too? And if so, try uninstalling that and checking STR.
Reporter | ||
Comment 3•15 years ago
|
||
I have never installed the personas add-on. This also happens on my Linux x64 machine at work so I'm setting the platform to All.
OS: Windows Vista → All
Hardware: x86 → All
Assignee | ||
Comment 4•15 years ago
|
||
Likely a regression from bug 516013.
Assignee | ||
Comment 5•15 years ago
|
||
Ah, I fixed that locally but apparently that's not the version I attached in the bug and landed.
Assignee | ||
Comment 6•15 years ago
|
||
I also tried and failed to manually evict the cache entries for the local files...
Attachment #406193 -
Flags: review?(dtownsend)
Comment 7•15 years ago
|
||
I think this is an over-complicated fix. nsIXULChromeRegistry.reloadChrome might do the job on its own. Alternately wouldn't it be simpler to keep everything as-is but append the theme ID on the end of the url rather than storing a hash?
Assignee | ||
Comment 8•15 years ago
|
||
(In reply to comment #7) > nsIXULChromeRegistry.reloadChrome might do the job on its own. I can try that. > Alternately wouldn't it be simpler to keep > everything as-is but append the theme ID on the end of the url rather than > storing a hash? This would reload the image when opening a new window.
Comment 9•15 years ago
|
||
(In reply to comment #8) > > Alternately wouldn't it be simpler to keep > > everything as-is but append the theme ID on the end of the url rather than > > storing a hash? > > This would reload the image when opening a new window. Why? The theme ID never changes
Assignee | ||
Comment 10•15 years ago
|
||
Oh, yeah, the id. I was thinking of moving Date.now() there.
Assignee | ||
Comment 11•15 years ago
|
||
reloadChrome appears to be completely broken...
Assignee | ||
Comment 12•15 years ago
|
||
I tried sending the chrome-flush-caches notification myself, but that doesn't affect these images.
Assignee | ||
Comment 13•15 years ago
|
||
This works, but it means that we won't reload the images when installing the same theme again with potential changes to the images.
Attachment #406249 -
Flags: review?(dtownsend)
Assignee | ||
Updated•15 years ago
|
Assignee | ||
Updated•15 years ago
|
Attachment #406249 -
Flags: review?(dtownsend)
Assignee | ||
Updated•15 years ago
|
Attachment #406193 -
Flags: review?(dtownsend)
Updated•15 years ago
|
Flags: blocking1.9.2? → blocking1.9.2+
Assignee | ||
Updated•15 years ago
|
Whiteboard: patch in bug 520346
Assignee | ||
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
status1.9.2:
--- → final-fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Version: unspecified → 1.9.2 Branch
Comment 15•15 years ago
|
||
This seems to be fixed for me on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b5pre) Gecko/20091202 Namoroka/3.6b5pre and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091202 Minefield/3.7a1pre. i havent seen any lightweight themes not "stick" lately. If you still experience this, please reopen and list repro steps. Thanks.
Status: RESOLVED → VERIFIED
Keywords: verified1.9.2
You need to log in
before you can comment on or make changes to this bug.
Description
•