Closed
Bug 522225
Opened 15 years ago
Closed 15 years ago
[ga-IE] Choose search plug-ins for Fennec in Irish
Categories
(Mozilla Localizations :: ga-IE / Irish, defect)
Mozilla Localizations
ga-IE / Irish
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stas, Assigned: kscanne)
References
Details
(Keywords: productization, Whiteboard: [bootstrapped][twitter][focal.ie][amazon.co.uk])
Attachments
(3 files)
8.71 KB,
patch
|
Details | Diff | Splinter Review | |
1.01 KB,
patch
|
stas
:
review+
|
Details | Diff | Splinter Review |
2.32 KB,
patch
|
stas
:
review+
|
Details | Diff | Splinter Review |
You've indicated an interest in participating in the localization of mobile Firefox (aka Fennec). We want to ship Fennec with a good list of search engines for Irish. As the technical details of implementation are being worked on, we'd like to start the discussion about the choice of search engines. This bug is about agreeing on a set of search engines, and will not tackle the implementation (at least not yet). First, the localization team and Staś will look at the market for the locale and come up with a good set of search providers. The guidelines for making recommendations are on https://wiki.mozilla.org/L10n:Mobile/Productization. You're welcome to suggest engines already shipped in desktop Firefox for Irish, if they fit well in the categories outlined on the wiki. For en-US, we currently use the following set, which may serve as an inspiration: Google, Wikipedia , Amazon, Yahoo, Amazon, Twitter. Note that according to the guidelines, for some categories it may be better to leave them empty than to ship with en engine that's irrelevant or unavailable in your region. After we decided on a particular search engine, we will need to test it in Fennec. You can test on a mobile device and on the desktop (download the builds from <http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/>). Staś will help with testing on a device, too. If the service works fine, Staś will contact the owner and ask for permission, and for specifics like proper search flags. We'll likely need your help to at least get the contact information if we don't have them already. We don't know the implementation details yet, so for now, please don't create patches nor land anything. We will keep you posted as we figure out the how's and when's. Thanks.
Assignee | ||
Comment 1•15 years ago
|
||
We'd like to use the same plugins as for Firefox: http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/ga-IE/file/800025a3aa03/browser/searchplugins
Reporter | ||
Comment 2•15 years ago
|
||
In desktop Firefox we currently have: google yahoo-en-GB amazon-en-GB eBay-en-GB answers creativecommons focal wikipedia-ga-IE Unfortunately, that's too many for Fennec. How about reducing this list to: google amazon-en-GB wikipedia-ga-IE focal + twitter ('social' category, new in Fennec) What do you think?
Reporter | ||
Comment 3•15 years ago
|
||
Here's a patch resetting the mobile/searchplugins/ directory to a minimal set of search engines that we would like to ship your locale with. Please read this comment carefully before you land this patch. *Important*: There has been a change to how we use the <Description/> elements present in the plug-ins (see bug 528655 and bug 529869). We want to emphasize that the search is integrated with the browser to better reflect what a search plugin is and what it does. You will need to edit the Wikipedia plug-in before you commit this patch. Please read <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions> for detailed instructions. For Google and Twitter, we don't have to copy the XML files to your mobile/searchplugins/ directory. Plugins identical to en-US are pulled from source automatically. It's enough to put the engine's name in list.txt for this to work (which I did). I also updated the Wikipedia plug-in to use a bigger icon, see bug 517997 for details. Please edit the Wikipedia plug-in and commit this patch before you opt-in in the mozilla.dev.l10n newsgroup. Opt-ins without this patch will not be taken. This does not mean that we don't want to include other search engines. On the contrary, the work and the discussion will continue in this bug until we choose a good set of search engines for your locale. Then, you will be able to opt in again, so that in the final release we include more search engines than the mineral set from this patch. This patch is simply meant to reset your mobile/searchplugins directory so that we keep the repository clean and happy. Thanks for understanding!
Assignee | ||
Comment 4•15 years ago
|
||
Patch committed, with appropriate changes to wikipedia-ga-IE plugin. http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/ga-IE/file/9d5574802774
Assignee | ||
Comment 5•15 years ago
|
||
Can I land this before opting-in for Fennec?
Reporter | ||
Updated•15 years ago
|
Attachment #415028 -
Flags: review+
Reporter | ||
Comment 6•15 years ago
|
||
Comment on attachment 415028 [details] [diff] [review] Patch adding focal.ie search plugin. Thanks Kevin, r=me. Please land this patch and opt in in the Fennec 1.0 opt-in thread in m.d.l10n. >+<Image width="16" height="16">data:image/x-icon;base64,R0lGODlhEAAQALMAAP//////9v/u1cX//5zu/3ve/8W0pJycpEqLpBCLxRCLtBCLpAAAAAAAAAAAAAAAACwAAAAAEAAQAAAEJnDJSau9OOc0QDjaUgBGuCjEZ44AICAaSppyGdY0Md+6bf7AYDACADs=</Image> I'm going to send e-mail to focal.ie to ask them to provide a 32x32px icon for us to use in Fennec. But, if you know anyone there, maybe you could try to reach out to them? Thanks.
Reporter | ||
Updated•15 years ago
|
Whiteboard: [bootstrapped][twitter]
Assignee | ||
Comment 7•15 years ago
|
||
Landed. I do know the focal.ie people, and just sent a note to the guy who created the original favicon for me, cc'd stas.
Reporter | ||
Comment 8•15 years ago
|
||
(In reply to comment #7) > Landed. For reference: the landing was http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/ga-IE/rev/f1ed1de6a441. > I do know the focal.ie people, and just sent a note to the guy who created the > original favicon for me, cc'd stas. Thanks. Kevin, should we add Amazon.co.uk to the list to make it final? If yes, please use the plug-in from desktop Firefox, but remember to edit the description (according to <http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/ga-IE/rev/f1ed1de6a441> and to use a larger icon from <http://hg.mozilla.org/mobile-browser/file/6c6ba58c1d7f/locales/en-US/searchplugins/amazondotcom.xml>. Thanks.
Whiteboard: [bootstrapped][twitter] → [bootstrapped][twitter][focal.ie]
Assignee | ||
Comment 9•15 years ago
|
||
Reporter | ||
Comment 10•15 years ago
|
||
Comment on attachment 415216 [details] [diff] [review] Patching adding amazon.co.uk search plugin, with correct <Description/> and larger icon Thank you! r=me, please land this patch and opt in with the new revision in the m.d.l10n newsgroup.
Attachment #415216 -
Flags: review+
Reporter | ||
Updated•15 years ago
|
Whiteboard: [bootstrapped][twitter][focal.ie] → [bootstrapped][twitter][focal.ie][amazon.co.uk]
Assignee | ||
Comment 11•15 years ago
|
||
Landed the amazon patch: http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/ga-IE/rev/6347dcb30711 and will opt in ASAP.
Reporter | ||
Comment 12•15 years ago
|
||
We now have 5 search engine plug-ins in Fennec, so I'm closing this bug as fixed. Thanks, Kevin!
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•