52298 - can't scroll to top or bottom of tree (bookmark list, preferences)

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[djk]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; m18) Gecko/20000911
BuildID:    2000091108

When using the Sidebar bookmarks or the Manage Bookmarks dialog, the scrollbar
gets misaligned with the region it's scrolling so that I can't get to the top of
the bookmark list anymore.

Reproducible: Always
Steps to Reproduce:
1. Open Manage Bookmarks dialog box. (Bookmarks -> Manage Bookmarks...)
2. Resize the box vertically until a vertical scrollbar appears.
3. Scroll down until a folder is at the top of the scroll region (like
"Community" for example).
4. Expand the folder.

Actual Results:  The "Community" folder disappeared off the viewable area
(leaving the folder below it, "Third Party Tools", at the top of the list).

Futhermore, I cannot scroll up more than 2 positions (the original number above
the "Community" folder).  I *can* scroll down so that there is blank space under
my last folder.

Expected Results:  The "Community" folder should have expanded in place, and I
should be able to scroll to the top and bottom of the area without any extra
blank lines.

Workaround is to close the Manage Bookmarks window and open it up again; this
restores the correct position.

This problem also occurs in the Sidebar bookmark list.  To work around that, you
have to shut off the sidebar and turn it back on via the menu (View -> My Sidebar).

Comment 1

[John Morrison]

Yep. This happens on mac/linux/win32. Very clear steps to reproduce. Thanks. 

One additional note: you can also workaround this on some occassions by 
dragging to the end of the list, and then back to the top, but this does 
not always work reliably.

Comment 2

[Peter Trudelle]

->future

Comment 3

[djk]

Using 2000091508 build on Win98:
  I found an instance when this bug *doesn't* happen when following the general
steps in the original bug report.
  If the folder at the top of the scroll region is the first child of its
parent, the folder expands in place and the scrollbar works correctly.
  For example, with the default bookmarks from this build, if I expand the
"Mozilla Project" folder and put the "mozilla.org" folder at the top of the
scroll region and open it, everything works as it should.  However, if I then
put the "Developer Information" folder at the top and expand it, the bug reappears.

Comment 4

[djk]

I'm running build 2000103004 on Win98se.

It looks like Hyatt's SuperPatch(tm) to bug 57139 has fixed this bug as well!

Way to go!

Comment 5

[David Hyatt]

Fixed by 57139.

Comment 6

[djk]

  I hate to say this, but I can still repo this bug using nightly 2000103020 on
Win98Se. :-(
  The steps to repo are different; the prior examples on this bug now behave
correctly.
  It now seems to happen more by chance than anything.  I *hate* those kinds of
bugs...
  Here's how I can repo this bug: (I use the "Customize My Sidebar" dialog here
because it's easier to repo with the shipped defaults.  Perhaps this bug is
related to the length of the subtree I'm expanding/collapsing?  It only seems to
happen with longer lists.)

1. Open Sidebar
2. Click "Tabs >"
3. Choose "Customize My Sidebar"
4. Expand "From Others" folder
5. Scroll to bottom of view
6. Expand "My Netscape Network" folder
7. Scroll to bottom of view
8. Scroll back up so that "My Netscape Network" folder is the 8th item down.
9. Close "My Netscape Network" folder
   ---> OK, so I lied.  This doesn't always work with the folder being the 8th
item down.  I *can* always repo, though.  You just have to stumble on the right
point in the tree.  I believe it has to do with the viewable length of the tree
area.

  At this point, the tree view messes up.  Sometimes, there are just a few items
in the middle of the tree missing, which a refresh (resize the window
vertically) cures.  Sometimes, the entire tree view disappears!  Other times,
only a few items in the middle of the list are shown.

  To repo the "can't scroll to top of tree" bug, after the tree view messes up:
1. Scroll to the top of the scroll region
2. If the first item(s) are missing, force a refresh (by resizing).

  Result: you can't get the to top items and there is empty space below the last
item, as reported originally in this bug.

  A caveat: If, after the view bonks, you scroll to the top of the region, then
the bottom, things get refreshed OK when the refresh happens.  Sometimes, even
following the steps above will result in correct behavior. :-}

  Another workaround to this bug is (when you can't scroll to the top):
1. Have the bottom collapsed folder in view
2. Expand a folder to make the tree grow down
  This fixes things as well.

  Sorry for the length of this post and the fact that the bug appearance is not
consistant, but I thought you should know.

Comment 7

[David Hyatt]

reopn

Comment 8

[djk]

Changed summary a bit to reflect this is not purely a bookmark issue.

Comment 9

[scalkins]

This affects AIM in the buddy list for commercial release as well. I understand
it may also affect the folders tree in Mail (nbaca?).
 It also affects the Preferences in the following way.
* Collapse all prefs components if they have been expanded.
* Scroll to the top of the prefs list
* Starting at the top and working your way down, expand each preference one by
one. Pull the scrollbar to the bottom  when you need to access the next
category(s) to expand.

RESULTS: When you expand the 'Advanced' category, note the scrollbar tack is in
the bottom position and can't be moved downward to select 'Debug'.

I see this on 5-17-22trunk build.
Changed summary to reflect this isn't only scrolling to the top of lists
Also, for prefs anyhoo, I see this on Linux and Mac also.

Comment 10

[scalkins]

Nominating nsbeta1 as it's more visible (IMO) than originally thot.

Comment 11

[Francisco León]

Since this bug takes on the same thing (can't scroll) in bookmarks and
preferences, should it also take on mail?
I have bug 89212 waiting...
Also there is bug 59108 specifically talking about preferences not scrolling...
Decide what should be duped

Comment 12

[djk]

IMHO, this is not the same bug as the other bugs referenced above.
Bug 63236, bug 59108, bug 89212, and the second part of the comment from 
"[e-mail]" on 2001-05-18 13:44 seem to deal with the fact that
scrollbars never appear when they should. (in preferences, etc...)

This bug deals with the list content getting misaligned WRT the scrollbar when
collapsing items and scrolling the scrollbar.  At least that's the reason I
filed it in the first place. :-)

Comment 13

[djk]

From what I've read, the bookmarks conversion to the outliner should fix things
like this.

Comment 14

[Blake Ross]

reassigning bugs dependent on 73508 to me.

Comment 15

[Blake Ross]

fixed.