52311 - Right-clicking image inside an anchor should focus anchor

Status: VERIFIED WORKSFORME

(Core :: Layout, enhancement, P4)

Description

[WD]

When you (left) click on an image that is a link in Mozilla, it puts a
dotted-line box around the link you just clicked on.    This is a nice feature
to let you know where you are and have been.

Mozilla should also do this when *right*-clicking on an image link.    I have an
FTP program that monitors the clipboard for URL's.    I right-click on an image
and hit "Copy link location".      Now let's say I have a page with 100 links I
want to copy.     With mozilla, it's nearly impossible to remember where I have
left off.    I use IE in such a case, because it does put such a box around the
image when right-clicking.  (and left-clicking, as Mozilla does)

For an example of this, check out http://ifihada.com/sp/
Right-clicking on any of the stars does not but a box around it.    An image
link should display a box when right-clicked, just as a text link does.

Comment 1

[Blake Ross]

I don't know what this would be, but not selection.  reassigning to html 
element for possible further triage

Comment 2

[Loco]

Blake-

Call me silly, but I'm not seeing how this could be related to Element-if the 
selection is working with the item with left click and not with a right click-
wouldn't that place it squarely under a "Selection Recognizer Widget" problem 
umbrella?

Comment 3

[Blake Ross]

Nope.  Selection typically has to do with drag-highlighting content of a 
website, not right clicking on an image.  I don't know why this is happening, 
though.  Obviously the proper styling is in html.css, so maybe it's a focus 
bug?  However, I was under the impression that saari's fix not all that long 
ago set focus to *all* elements on right click before the context menu 
appeared.  Ian or Saari, any ideas?

Comment 4

[Hixie (not reading bugmail)]

Sounds like what you want is a right-click to set focus on links. Nothing to do
with images per se.

Sending to rod for further triage.

Comment 5

[Blake Ross]

Nope.  Links *are* focused on right-click.  That's what makes this bug so weird.

Comment 6

[Hixie (not reading bugmail)]

Blake: Not in my build they ain't...

Comment 7

[Eric Pollmann]

Yep, this is a strange one.  I went to the test case with a FreeBSD build from
last night and saw exactly as described:

<A HREF=foo>text</A>

    Left mouse down -> focus ring around text
    Right mouse down -> context menu + focus ring around text

<A HREF=foo><IMG SRC=bar></A>

    Left mouse down -> focus ring around image
    Right mouse down -> context menu + NO focus ring!

Comment 8

[Hixie (not reading bugmail)]

I see what I was doing wrong. When you already have a context menu up, and then
right click on a link, it is not focussed. That is probably a separate bug.

Comment 9

[rods (gone)]

reassigning to core layout

Comment 10

[Jesse Ruderman]

Hixie: did you find the bug you mentioned on 2000-09-18?

Comment 11

[Hixie (not reading bugmail)]

Jesse: nope; I didn't really look though. Feel free to deal with it. :-)

Comment 12

[Jesse Ruderman]

Ok, filed bug 64849.

Comment 13

[saari (gone)]

WARNING: making right clicks take focus could potentially cause a raft of bugs.
Be careful here.

Comment 14

[Hixie (not reading bugmail)]

Reassigning QA Contact for all open and unverified bugs previously under Lorca's
care to Gerardo as per phone conversation this morning.

Comment 15

[bsharma]

qa contact updated.

Comment 16

[Heikki Toivonen (remove -bugzilla when emailing directly)]

SPAM. HTML Element component deprecated, changing component to Layout. See bug
88132 for details.

Comment 17

[karnaze (gone)]

->attinasi

Comment 18

[Christine Hoffman]

Changing qa contact. Also attaching a testcase with four examples: an image
link, a text link, an image link in a table cell, a text link in a table cell.
The images have no dotted line around them whether you right click or left
click. The text has dotted lines around it when you left click AND when you
right click. The behavior is already there for text. I'm not sure what the
behavior should be for image links. 

Comment 19

[Christine Hoffman]

Attachment: zip file containing html file and image

Comment 20

[Christine Hoffman]

Above testcase with 10_03_05_0.9.4 build.

Comment 21

[Christine Hoffman]

Changing QA contact

Comment 22

[Boris Zbarsky [:bzbarsky]]

This worksforme (try the banner image at the top of this very page --
right-clicking on it shows a focus outline) in a current build.

Comment 23

[WD]

V. WFM