525416 - compatibility dashboard is (slightly) over-reporting total users

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Compatibility Tools, defect, P4)

Description

[u278084]

I came across this while working on bug 477824. When I set an extension to be Thunderbird 3 compatible and re-ran compatibility_report.php for tb, it told me that Thunderbird had 1000 users (the value of update_counts.count). This isn't right. That number represents total users for all applications, and not just the specific application we are concerned about.

What we really should do is go through the data in the applications column and count all users for the respective application.

CC'ing fligtar on this since he wrote it, and might have some thoughts on this.

Comment 1

[u278084]

Request that we should set this for 5.5. While this is a small deal for Firefox, this will be a huge deal for Thunderbird and SeaMonkey. I plan on getting bug 477824 released for 5.5, and it'll be nice for this to be in sync.

Comment 2

[Robert Kaiser]

This will vastly improve what bug 509501 and bug 477824 are delivering, so marking dependencies for those even though in principle they can be shipped without this.

Comment 3

[u278084]

Attachment: ummm

I'm not actually sure whether this patch is correct. It will lead interesting results because it doesn't count total pings but application pings (so our Firefox stats will change as well).

I could use a second pair of eyes on this, if anyone can help out. The solution looks misleadingly simple for what I thought will be a much bigger job.

Comment 4

[Justin Scott [:fligtar]]

I haven't applied the patch, but I think that might be all that's needed.

Comment 5

[Wil Clouser [:clouserw]]

Thanks for filing this.  In an effort to not drown in existing reports we're aggressively closing old enhancements and bugs to get the buglist to a reasonable level so we can scope and process bug sprints in an effective manner.

Patches for this bug are still welcome.