525735 - Remove deprecated method getBoxObjectFor in select1 realization

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Sergey Reymerov]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; ru; rv:1.9.1.4) Gecko/20091028 Ubuntu/9.10 (karmic) Firefox/3.5.4
Build Identifier: Trunk

In FF (from trunk version) builded with Xforms and patch from https://bugzilla.mozilla.org/show_bug.cgi?id=525730. select1 with drop-down list works not correctly.
when clicks in control drop-down doesn't work.

Reproducible: Always

Steps to Reproduce:
1.click on drop-down control
2.nothing happens, that's wrong.

Comment 1

[Sergey Reymerov]

I had get an indea that XForms doesn't load any items to select. In DOMInspector I saw that items are loaded.

Comment 2

[Alexey Gaidukov]

JavaScript Debugger shows the error when clicks in control drop-down

[e] message = [string] "document.getBoxObjectFor is not a function"
Stopped for thrown exception.


The method  getBoxObjectFor is depricated
https://bugzilla.mozilla.org/show_bug.cgi?id=409220

Comment 3

[alexander :surkov (:asurkov)]

I think you should use nsIDOMNSElement instead.

Comment 4

[Sergey Reymerov]

Attachment: replacing getBoxObjectFor to getClientBoundingBox

I made this patch to replace deprecated method getBoxObjectFor, but bug is still exist.

Comment 5

[Sergey Reymerov]

Attachment: replacing getBoxObjectFor to getClientBoundingBox

This patch is workable.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 409901 [details] [diff] [review]
replacing getBoxObjectFor to getClientBoundingBox

I can't test this right now, but looks ok to me.
Surkov should also review this.

Comment 7

[alexander :surkov (:asurkov)]

I really would like to get bug 525730 firstly to be able to test this one. Since Sergey works on it as well then it should be reachable ;)

Comment 8

[Sergey Reymerov]

This patch is actual for mozilla 3.6.

Comment 9

[alexander :surkov (:asurkov)]

landed - http://hg.mozilla.org/xforms/rev/dda416d6a55f