525832 - (Message Header) Windows XP theme inconsisten signed message icon

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[[:Aureliano Buendía]]

Attachment: screenshot

I inspect enigmail.xpi and it seems that icon is TB: should be migrate to new tango style.
Set polish keywords but not blocking

Comment 1

[Andreas Nilsson (:andreasn)]

How do I reproduce this?

Comment 2

[[:Aureliano Buendía]]

With a signed message (in my case using enigmail extension for sign and\or encryption).

At the begin I think that this icon was an enigmail specific icon, but inspection enigmail.xpi I cannot find this icon: probably is native TB icon.

Comment 3

[[:Aureliano Buendía]]

Andreas, maybe this can help you: this icon is located to 

chrome\classic\messenger\smime\icons there are more icon in old style.

Comment 4

[Andreas Nilsson (:andreasn)]

Yeah, I'll take a look and see what's going on.

Comment 5

[Andreas Nilsson (:andreasn)]

Attachment: updated icons for gnomestripe, xp and vista

This should take care of the issue.

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 409886 [details] [diff] [review]
updated icons for gnomestripe, xp and vista

These new icons look a lot better.  I don't feel like the ? icons are a great metaphor but we could try to create better icons in a separate bug for the next release.

Too bad we're only making the pinstripe ones look worse and worse now :)

Comment 7

[[:Aureliano Buendía]]

Need flag approval-thunderbird?

Comment 8

[Mark Banner (:standard8) (afk until 12 Apr)]

Checked in:
http://hg.mozilla.org/comm-central/rev/ec27e3bdcb3b
http://hg.mozilla.org/releases/comm-1.9.1/rev/7ac616f8bebe

Comment 9

[[:Aureliano Buendía]]

great icons :-D

As suggest from Bryan in comment #6 I open a new bug for hdrSignUnknown.png and sbSignUnknown.png.

Comment 10

[Andreas Nilsson (:andreasn)]

(In reply to comment #6)
> Too bad we're only making the pinstripe ones look worse and worse now :)

Filed as bug 526909