525834 - Replace Search-glass.png with gtk-find stock icon

Status: RESOLVED FIXED

(Toolkit :: Themes, enhancement)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[Reed Loden [:reed]]

For some reason, I want to say we purposely went with a custom icon instead of gtk-find, but I can't remember why...

Comment 2

[Dão Gottwald [:dao]]

I also couldn't find anything about it, except for a comment that we should in fact use gtk-find. I've noticed that it's used in search fields throughout Ubuntu.

Comment 3

[Reed Loden [:reed]]

There's bug 424944 that talks about something similar that was WONTFIX'd (though, it was for using another icon).

Comment 4

[Dão Gottwald [:dao]]

We never seem to have used gtk-serach, so I'm not quite sure what the comments in that bug refer to. In any case, yes, it's about a different icon. As far as gtk-find is concerned, I think it's possible that previous Ubuntu icon themes used an icon that didn't fit. But it's a search glass now, and it's also a search glass on <http://library.gnome.org/devel/gtk/2.11/gtk-Stock-Items.html>.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/b156fe035fb7

Comment 6

[Victor Bielawski]

The default GNOME icon theme still has binoculars as the find icon.

http://git.gnome.org/cgit/gnome-icon-theme/plain/16x16/actions/edit-find.png

Comment 7

[Dão Gottwald [:dao]]

So... I think we want to stick with gtk-find for the generic search textbox widget, but cannot use it for the Firefox search bar. Other opinions?

Comment 8

[Phil Ringnalda (:philor)]

Thunderbird tucks a dropmarker in next to Search-glass.png, so we wouldn't mind (going back to) sharing one in toolkit, if it's not possible to count on the shape of gtk-find.

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

We should have visual changes like this (particularly in the main window) go through ui-review prior to landing.

Comment 10

[Alex Faaborg [:faaborg] (Firefox UX)]

To clarify, for things like replacing one search glass with another more native one, ui-review is basically a rubber stamp on Linux, but the advantage is that we can have a full view of what is changing (for instance realizing that this icon wasn't native might trigger a thought to hunt down the other non-native icons, etc.)