525971 - Look into making use of stock GTK+ search icon

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Andreas Nilsson (:andreasn)]

Bug 525834 talks about getting rid of the global search icon for Firefox on Linux and replacing it with a reference to the stock icon served by the toolkit. This would affect Thunderbird too, so we should look into if we want to use that as well.

Comment 2

[Takanori MATSUURA]

For Search-glass.png, I put a patch as 410169 in bug 526425.

Comment 3

[Andreas Nilsson (:andreasn)]

Attachment: Takanori's patch

Just to keep track of it easier.

Comment 4

[Andreas Nilsson (:andreasn)]

Attachment: and this is how it looks in action

Comment 5

[Andreas Nilsson (:andreasn)]

The only issue I recall with using the stock icon is that it can be slightly hard to spot the dropdown arrow in some themes. Looking at other GTK+ apps, it seems that some of them don't use a dropdown, but rather use the icon only as a dropdown (Banshee and Evolution among others).

Comment 6

[Takanori MATSUURA]

Search bar on firefox is one possible look and feel if we need arrows.

Anyway, three search glasses (whole image of Search-glass.png) are shown in the search bar on current tb trunk.

Comment 7

[Tuukka Tolvanen (sp3000)]

Attachment: screenshots w/ 16px dropmarker margin-start

(In reply to comment #5)
> The only issue I recall with using the stock icon is that it can be slightly
> hard to spot the dropdown arrow in some themes. Looking at other GTK+ apps, it
> seems that some of them don't use a dropdown, but rather use the icon only as a
> dropdown (Banshee and Evolution among others).

An option is just to tweak .quick-search-button-dropmarker { -moz-margin-start: from 13px to 16px, giving the dropmarker a bit of room past the beefy binoculars. That seems to agree fine with the icon themes default installed on karmic.

Comment 8

[Tuukka Tolvanen (sp3000)]

Attachment: Takanori's patch + 16px

...like so. I like it better than the triple-glass look ;) , I'd be a bit uneasy losing the dropmarker wrt discoverability even if others feel they might get away with it, and the fx search bar look can be a bonus level followup if desired.

Comment 9

[Andreas Nilsson (:andreasn)]

Comment on attachment 414393 [details] [diff] [review]
 Takanori's patch + 16px

Looks great!

Comment 11

[Takanori MATSUURA]

Hi Phil,

Can you review and check in attach414393?
Tuukka request to review to you.

Comment 12

[Phil Ringnalda (:philor)]

Comment on attachment 414393 [details] [diff] [review]
 Takanori's patch + 16px

Probably better off with a reviewer who actually uses Linux, rather than one who just breaks his VM over and over.

Comment 13

[Ryan Li]

I think it's fixed in Lanikai 20100212 nightly, tested under GNOME 2.28.1.

Comment 14

[Magnus Melin [:mkmelin]]

Comment on attachment 414393 [details] [diff] [review]
 Takanori's patch + 16px

Can we get an updated patch, this one doesn't apply.

Comment 15

[Takanori MATSUURA]

Attachment: My patch + 16px updated

Comment 16

[Magnus Melin [:mkmelin]]

Comment on attachment 426970 [details] [diff] [review]
My patch + 16px updated

Looks great thx! r=mkmelin

Only one place left then it seems http://mxr.mozilla.org/comm-central/source/mail/themes/gnomestripe/mail/tabmail.css#92

Comment 17

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/b7672ae07115