525917 - undo doesn't work for lightweight themes / personas

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

Running into a few (potentially edge) cases where "Undo" doesn't actually undo the action after installing a persona. Here's STR that I can reproduce:

1. remove addons.mozilla.org from the software install whitelist (Security options)
2. go to addons.mozilla.org/firefox/persona
3. pick a persona and "wear this"
4. click "allow"
5. click "undo"

Expected: to go back to previous persona
Actual: still shows new persona

It was pretty sticky, too. If I went into the add-ons manager and selected my previous persona, it wouldn't switch back. I had to uninstall the previous persona to get rid of the new one.

(Stephen Horlander says that he also hit this even when addons.mozilla.org was in the software install whitelist, but I wasn't able to reproduce that)

Comment 1

[Johnathan Nightingale [:johnath]]

(In reply to comment #0)
> (Stephen Horlander says that he also hit this even when addons.mozilla.org was
> in the software install whitelist, but I wasn't able to reproduce that)

Yeah, judging from the chat transcript, I think Stephen's experience might be bug 522188, but as Dao pointed out on today's team call, your complaint is different.

Comment 2

[Stephen Horlander [:shorlander]]

Yes. My issue actually sounds much more like bug 522188.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

The problem was that the currentTheme data wasn't original but pointed to the persisted images. So when browser.js used that data to set the current theme, the persisted images became the primary sources.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch

minor cleanup

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/138696e68064

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/5d0b180b9873

Comment 7

[[not reading bugmail]]

V. Fixed Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091106 Minefield/3.7a1pre

V. Fixed Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b2pre) Gecko/20091106 Namoroka/3.6b2pre

Comment 8

[Tony Chung [:tchung]]

changing status based on comment 7.  i've also verified the same on mac builds.