undo doesn't work for lightweight themes / personas

VERIFIED FIXED in Firefox 3.7a1

Status

()

Firefox
General
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: beltzner, Assigned: dao)

Tracking

(Blocks: 1 bug, {verified1.9.2})

3.6 Branch
Firefox 3.7a1
verified1.9.2
Points:
---
Bug Flags:
blocking-firefox3.6 +

Firefox Tracking Flags

(status1.9.2 beta2-fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Running into a few (potentially edge) cases where "Undo" doesn't actually undo the action after installing a persona. Here's STR that I can reproduce:

1. remove addons.mozilla.org from the software install whitelist (Security options)
2. go to addons.mozilla.org/firefox/persona
3. pick a persona and "wear this"
4. click "allow"
5. click "undo"

Expected: to go back to previous persona
Actual: still shows new persona

It was pretty sticky, too. If I went into the add-ons manager and selected my previous persona, it wouldn't switch back. I had to uninstall the previous persona to get rid of the new one.

(Stephen Horlander says that he also hit this even when addons.mozilla.org was in the software install whitelist, but I wasn't able to reproduce that)
Flags: blocking-firefox3.6+
(Assignee)

Updated

8 years ago
Blocks: 511104
No longer depends on: 511104
(Assignee)

Updated

8 years ago
Assignee: nobody → dao
(In reply to comment #0)
> (Stephen Horlander says that he also hit this even when addons.mozilla.org was
> in the software install whitelist, but I wasn't able to reproduce that)

Yeah, judging from the chat transcript, I think Stephen's experience might be bug 522188, but as Dao pointed out on today's team call, your complaint is different.
Yes. My issue actually sounds much more like bug 522188.
(Assignee)

Comment 3

8 years ago
Created attachment 410478 [details] [diff] [review]
patch

The problem was that the currentTheme data wasn't original but pointed to the persisted images. So when browser.js used that data to set the current theme, the persisted images became the primary sources.
Attachment #410478 - Flags: review?(dtownsend)
(Assignee)

Updated

8 years ago
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: needs review dtownsend
(Assignee)

Comment 4

8 years ago
Created attachment 410479 [details] [diff] [review]
patch

minor cleanup
Attachment #410478 - Attachment is obsolete: true
Attachment #410479 - Flags: review?(dtownsend)
Attachment #410478 - Flags: review?(dtownsend)
Attachment #410479 - Flags: review?(dtownsend) → review+
(Assignee)

Comment 5

8 years ago
http://hg.mozilla.org/mozilla-central/rev/138696e68064
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: needs review dtownsend
Target Milestone: --- → Firefox 3.7a1
(Assignee)

Comment 6

8 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/5d0b180b9873
status1.9.2: --- → beta2-fixed
V. Fixed Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091106 Minefield/3.7a1pre

V. Fixed Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b2pre) Gecko/20091106 Namoroka/3.6b2pre

Comment 8

8 years ago
changing status based on comment 7.  i've also verified the same on mac builds.
Status: RESOLVED → VERIFIED
Keywords: verified1.9.2
You need to log in before you can comment on or make changes to this bug.