525924 - [FyFx] The "5 years of Firefox" website should be easier to localize

Status: VERIFIED FIXED

(Webtools Graveyard :: Five Years of Firefox, defect)

Description

[Staś Małolepszy :stas]

Attachment: Patch for better l12y

The website's code should be improved to make localizer's work easier. Attached is a patch to home.php with suggested chages. 

The patch:
- adds comments
- adds more _()
- adds plurals to the "views" string
- changes str_replace to urlencode for Twitter URLs 
- puts some html tags outside of _() calls
- puts URLs outside of _() calls

To include the comments in the messages.po file, just add --add-comments=L10n to xgettext's options, like so:

xgettext --language=PHP --add-comments=L10n home.php

Not sure who should review this. Pascal, any suggestions?

Comment 1

[Staś Małolepszy :stas]

Attachment: v0.2, fixing bug 525929 and addressing Pascal's review comments on IRC

This has a fix for bug 525929, too (the Spanish string is now in English).

Comment 2

[Pascal Chevrel (relman team) -> :pascalc]

this looks good to me, a zemoga webdev should look at it though

Comment 3

[Jane Finette]

asked Zemoga to take a look and commented that we would make the change/s if we don't hear back in the next few hours. Its a public hol today in Colombia (which we were aware of).

Comment 4

[Jane Finette]

Feedback from Zemoga: 

"... tried contacting the team to resolve the issue but they don’t have easy access to a computer to help out. I wouldn’t want your team to be delayed any further so if you can take care of this in any way internally I would say that is the best approach for the situation at hand and we will look into the SVN first thing tomorrow for any changes your team has made in order to be in sync.

We will obviously be attentive again tomorrow for any immediate help you might need." 

(Stas - I have also asked Zemgoa to add you to Basecamp, this should be done now).

Comment 5

[Staś Małolepszy :stas]

Comment on attachment 409731 [details] [diff] [review]
v0.2, fixing bug 525929 and addressing Pascal's review comments on IRC

Landed in r54879.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; production's localization in more than 25 languages speaks for itself.