Closed
Bug 527198
Opened 15 years ago
Closed 15 years ago
No need to include dictionary in language packs
Categories
(Thunderbird :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0rc1
People
(Reporter: u60234, Assigned: standard8)
Details
(Whiteboard: [no l10n impact])
Attachments
(1 file)
1.26 KB,
patch
|
dmosedale
:
review+
|
Details | Diff | Splinter Review |
We distribute language packs for Thunderbird 3 that include spell checking dictionaries, but licensing information for those dictionaries are not shipped.
If bug 526505 doesn't get fixed on 1.9.1 before the release of Thunderbird 3, we need to come up with another way of bundle the licenses for the dictionaries we ship.
Flags: blocking-thunderbird3?
Assignee | ||
Comment 1•15 years ago
|
||
(In reply to comment #0)
> We distribute language packs for Thunderbird 3 that include spell checking
> dictionaries, but licensing information for those dictionaries are not shipped.
>
> If bug 526505 doesn't get fixed on 1.9.1 before the release of Thunderbird 3,
> we need to come up with another way of bundle the licenses for the dictionaries
> we ship.
Two possible solutions:
1) Don't ship language packs with dictionaries (I'm not sure why we do this anyway when Firefox doesn't) - this would be a one line fix iirc.
2) Don't ship language packs.
Assignee | ||
Comment 2•15 years ago
|
||
Remove shipping of dictionaries in langpacks:
- TB 2 didn't ship dictionaries in langpacks.
- KaiRo enabled shipping dictionaries in langpacks when we moved across some locale changes. I couldn't see any reason for this other than probably making langpacks similar to what is shipped in-apps.
- langpacks aren't shipped by default, we don't even link to them on the website afaik, but they are available on ftp.mozilla.org.
- AFAIK no-one has explicitly requested dictionaries to be shipping in langpacks at any time.
Therefore my proposal is that we remove shipping of dictionaries in langpacks until such time as: a) bug 526505 is fixed, fixing the licensing issue, b) it is explicitly requested.
This will mean we can ship Thunderbird 3 without any license worries, and we can revisit the decision later if necessary.
Updated•15 years ago
|
Flags: blocking-thunderbird3? → blocking-thunderbird3+
Assignee | ||
Updated•15 years ago
|
Whiteboard: [no l10n impact][needs review dmose]
Target Milestone: --- → Thunderbird 3.0rc1
Comment 3•15 years ago
|
||
Comment on attachment 411198 [details] [diff] [review]
Don't ship dictionaries in language packs
r=dmose, conditional on removing the trailing list on the remaining $(ZIP) line.
Attachment #411198 -
Flags: review?(dmose) → review+
Updated•15 years ago
|
Whiteboard: [no l10n impact][needs review dmose] → [no l10n impact][has reviewed patch; needs landing]
Comment 4•15 years ago
|
||
Er "trailing slash".
Assignee | ||
Comment 5•15 years ago
|
||
Checked in:
http://hg.mozilla.org/comm-central/rev/eee5a798a4df
http://hg.mozilla.org/releases/comm-1.9.1/rev/edb078ff2f4f
(updating summary to what we're actually doing/solving).
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Summary: Include dictionary license file in language packs → No need to include dictionary in license packs
Updated•15 years ago
|
Whiteboard: [no l10n impact][has reviewed patch; needs landing] → [no l10n impact]
![]() |
||
Updated•15 years ago
|
Summary: No need to include dictionary in license packs → No need to include dictionary in language packs
You need to log in
before you can comment on or make changes to this bug.
Description
•