527324 - [account autoconfig]When I create a new account tb stay in "checking password..." indefinitely

Status: VERIFIED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Giuseppe Tino]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; it; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.6pre) Gecko/20091108 Shredder/3.0pre

I follow the procedure to create a new account (@gmail.com).
It seems that all work properly but, after that TB found the configuration settings and I select the button "create account" TB remain in the state "check password..." indefinitely.

Reproducible: Always

Steps to Reproduce:
1.I start TB3 and select an existing account in the left sidebar
2.On the right I select "create a new account" 
3.I put the datas and select continue
4.Shredder find the settings for my email account
5.I select the button "create account"
6. Shredder start to "check password..." but continue indefinitely.
Actual Results:  
Shredder remain in "check password..." state and nothing appen.

Expected Results:  
Shredder confirm the account creation and it is displayed in the left sidebar

A strange behavior during the process of creation is that if I put in the email address field:
[e-mail] and select continue tb need about 15 secs and return me the following configuration
Username:myEmailAddress (without @Gmail.com)
Incoming:imap.Gmail.com IMAP:993 SSL/TLS
Outgoing:smtp.Gmail.com SMTP:587 STARTTLS

if i put in the email address field:
[e-mail] (the difference is only "Gmail" vs "gmail")and select continue tb need about 1 sec and return me the following configuration
Username:[e-mail] (WITH @gmail.com)
Incoming:imap.googlemail.com IMAP:993 SSL/TLS
Outgoing:smtp.googlemail.com SMTP:465 SSL/TLS

Comment 1

[Ludovic Hirlimann [:Usul]]

Giuseppe , can you have a look in Tools -> Error console and see if there are error messages when you are doing that ?

Comment 2

[Giuseppe Tino]

Yes, there's this error:
"Error: uncaught exception: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIMsgAccountManager.removeIncomingServer]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: chrome://messenger/content/accountcreation/verifyConfig.js :: anonymous :: line 257"  data: no]

Comment 3

[Ludovic Hirlimann [:Usul]]

Blake what else would you need here to figure out what the issue might be ?

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Well, if I can replicate it with the uppercase Gmail, that should be good enough.

(I'm having problems building these days, so it might be a little while before I can get to it.)

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Yeah, I can replicate it, and it seems like a huge pain to only be able to use lower-case in your email address, without any notification of that fact, and with a strange error when you don't follow the unwritten rule.  ;)

In bug 525532, Magnus made it so that we ignore the case of the email address when we figure out whether or not to show the Reply All button.  Perhaps we should lower-case the email address here as well, at least for the purposes of checking.

At the very least, we should probably mention it in the release notes, or something.

Thanks,
Blake.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Attachment: Let's lower-case the email address before trying to find the host.

It's not perfect, but it should let us find our stored configs a little better.

Note: I believe this is equivalent to doing the check on the server side, with the possible difference being the case of what gets shown in the username field.

Thanks,
Blake.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Attachment: A better version of the patch.

Okay, we're only going to lower-case the domain part, because we know it'll be ascii for the next little while.

The other change in this patch is to re-lowercase the domain if the user has changed it and hits "Re-test config".

Thanks,
Blake.

Comment 8

[David :Bienvenu]

Does this override user-visible things, like the account name we create, if the user uses mix-case? My inclination would be to lower-case the url we run right before we run it, not change the case on the user-visible strings, if there's a safe way of doing so.

Comment 9

[Blake Winton (:bwinton) (:☕️)]

Attachment: The created account

In the final account, we have mixed case, except for items which are domain names.

Another screenshot is coming up soon.

Comment 10

[Blake Winton (:bwinton) (:☕️)]

Attachment: The config screen, times 3

The first shot is after I've typed in the mixed case address, and hit "continue".
The second shot is after I've hit "edit", and changed the case of "latte".
The third shot is after I've hit "Re-test Configuration".

Does that UI seem okay to everyone?  (By which I mean Bryan. ;)

Thanks,
Blake.

Comment 11

[David :Bienvenu]

Comment on attachment 412662 [details] [diff] [review]
A better version of the patch.

cool, thx, Blake.

Comment 12

[David Ascher (:davida)]

Comment on attachment 412662 [details] [diff] [review]
A better version of the patch.

bryan is traveling today, so I don't expect he'll get to it.  I'm going to channel him and say that that UI seems good to me.

We should file a followup bug on IDN domains in autoconfig, for 3.1.

Comment 13

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 412662 [details] [diff] [review]
A better version of the patch.

Requesting approval, based on the tb3ride-along whiteboard note.

Comment 14

[Mark Banner (:standard8)]

Comment on attachment 412662 [details] [diff] [review]
A better version of the patch.

a=Standard8. Please land on comm-central and comm-1.9.1.

I'll land on the relbranch within the next 12 hours.

Comment 15

[Blake Winton (:bwinton) (:☕️)]

Checked in as:
http://hg.mozilla.org/releases/comm-1.9.1/rev/3b5f2b677918
http://hg.mozilla.org/comm-central/rev/990cc59beac8

Comment 16

[Mark Banner (:standard8)]

Checked in for build 2 of RC1:
http://hg.mozilla.org/releases/comm-1.9.1/rev/2aaa7e7e813a

Comment 17

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to comment #12)
> (From update of attachment 412662 [details] [diff] [review])
> bryan is traveling today, so I don't expect he'll get to it.  I'm going to
> channel him and say that that UI seems good to me.

Channeled correctly!