Closed Bug 528175 Opened 11 years ago Closed 10 years ago

[el] Choose search plug-ins for Fennec in Greek

Categories

(Mozilla Localizations :: el / Greek, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stas, Assigned: pkst)

References

Details

(Keywords: productization, Whiteboard: [bootstrapped][twitter])

Attachments

(2 files, 1 obsolete file)

You've indicated an interest in participating in the localization of mobile Firefox (aka Fennec). We want to ship Fennec with a good list of search engines for Greek. As the technical details of implementation are being worked on, we'd like to start the discussion about the choice of search engines. This bug is about agreeing on a set of search engines, and will not tackle the implementation (at least not yet).

First, the localization team and Staś will look at the market for the locale and come up with a good set of search providers. The guidelines for making recommendations are on https://wiki.mozilla.org/L10n:Mobile/Productization. You're welcome to suggest engines already shipped in desktop Firefox for Greek, if they fit well in the categories outlined on the wiki.

For en-US, we currently use the following set, which may serve as an inspiration:
Google, Wikipedia, Amazon, Yahoo, Twitter.

Note that according to the guidelines, for some categories it may be better to leave them empty than to ship with en engine that's irrelevant or unavailable in your region.

After we decided on a particular search engine, we will need to test it in Fennec. You can test on a mobile device and on the desktop (download the builds from <http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/>). Staś will help with testing on a device, too. If the service works fine, Staś will contact the owner and ask for permission, and for specifics like proper search flags. We'll likely need your help to at least get the contact information if we don't have them already.

We don't know the implementation details yet, so for now, please don't create patches nor land anything. We will keep you posted as we figure out the how's and when's.

Thanks.
Just a friendly reminder, as we move closer to the general availability date for Fennec in mid-December, have you had any chance to consider search providers?  Thanks!
Here's a patch resetting the mobile/searchplugins/ directory to a minimal set of search engines that we would like to ship your locale with. Please read this comment carefully before you land this patch.

*Important*: There has been a change to how we use the  <Description/> elements present in the plug-ins (see bug 528655 and bug 529869). We want to emphasize that the search is integrated with the browser to better reflect what a search plugin is and what it does. You will need to edit the Wikipedia plug-in before you commit this patch. Please read <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions> for detailed instructions.

For Google and Twitter, we don't have to copy the XML files to your mobile/searchplugins/ directory. Plugins identical to en-US are pulled from source automatically. It's enough to put the engine's name in list.txt for this to work (which I did). I also updated the Wikipedia plug-in to use a bigger icon, see bug 517997 for details.

Please edit the Wikipedia plug-in and commit this patch before you opt-in in the mozilla.dev.l10n newsgroup. Opt-ins without this patch will not be taken. This does not mean that we don't want to include other search engines. On the contrary, the work and the discussion will continue in this bug until we choose a good set of search engines for your locale. Then, you will be able to opt in again, so that in the final release we include more search engines than the mineral set from this patch.

This patch is simply meant to reset your mobile/searchplugins directory so that we keep the repository clean and happy.

Thanks for understanding!
OK Thanks for all the info
patch landed in el (with the necessary wikipedia editing) http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/el/rev/0dbe4855c51f
Thanks Kostas. I know zero Greek (unfortunately) but are you sure you changed the Wikipedia's description? I think it still says "The free encyclopedia" (at least I think so comparing it to what I see at el.wikipedia.org). :)

Also, for other search plug-ins: any suggestions for e-commerce and/or local search in Greece?
Whiteboard: [bootstrapped][twitter]
(In reply to comment #4)
> Thanks Kostas. I know zero Greek (unfortunately) but are you sure you changed
> the Wikipedia's description? I think it still says "The free encyclopedia" (at
> least I think so comparing it to what I see at el.wikipedia.org). :)


Ehmmm... nope it is in greek (and the description is OK ) see http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/el/file/0dbe4855c51f/mobile/searchplugins/wikipedia-el.xml 

> Also, for other search plug-ins: any suggestions for e-commerce and/or local
> search in Greece?

For local searching google is OK. For e-commerce there is a popular site (http://www.skroutz.gr/ ), I'll try to have a look on this site to see if a search plugin is possible.
(In reply to comment #5)
> (In reply to comment #4)
> > Thanks Kostas. I know zero Greek (unfortunately) but are you sure you changed
> > the Wikipedia's description? I think it still says "The free encyclopedia" (at
> > least I think so comparing it to what I see at el.wikipedia.org). :)
> 
> 
> Ehmmm... nope it is in greek (and the description is OK ) see
> http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/el/file/0dbe4855c51f/mobile/searchplugins/wikipedia-el.xml 
>

Replying to my self: RTFM Kostas:  "    *  Remove the <Description/> from the plug-in entirely. The generic fallback string will be used. .

This revision should be OK: http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/el/rev/542428774e12
Skroutz.gr search plugin  (search for the lowest price in greek e-commerce stores)
Attachment #415378 - Flags: review?
(In reply to comment #6)

> Replying to my self: RTFM Kostas:  "    *  Remove the <Description/> from the
> plug-in entirely. The generic fallback string will be used. .

:)

> This revision should be OK:
> http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/el/rev/542428774e12

Almost. You can't remove the tags only, as this will break the XML. So you can either remove the whole description line:

-<Description>Βικιπαίδεια, η ελεύθερη εγκυκλοπαίδεια</Description>

... or change it, so that is says "Integrated search on Wikipedia".

-<Description>Βικιπαίδεια, η ελεύθερη εγκυκλοπαίδεια</Description>
+<Description>Ενσωματωμένη αναζήτηση στην Βικιπαίδεια</Description>

HTH.
Comment on attachment 415378 [details] [diff] [review]
Patch for adding skroutz.gr search plugin

We'll need skroutz's permission to include the in Fennec. Could you help me find the contact information, please? I'd like to email them today.

My review comments:


>diff -r 542428774e12 mobile/searchplugins/skroutz.xml
>--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
>+++ b/mobile/searchplugins/skroutz.xml	Tue Dec 01 14:37:05 2009 +0200
>@@ -0,0 +1,9 @@
>+<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/" xmlns:os="http://a9.com/-/spec/opensearch/1.1/">

You can only leave xmlns="http://www.mozilla.org/2006/browser/search/" here, and then drop the "os:" prefixes everywhere later on.

>+<os:ShortName>Skroutz</os:ShortName>

So this should be <ShortName>Skroutz</ShortName>

>+<os:Url type="text/html" method="GET" template="http://www.skroutz.gr/search?keyphrase={searchTerms}">
>+</os:Url>

If possible, please put the keyphrase parameter in a separate <Param/> element, like this:

<Url type="text/html" method="GET" template="http://www.skroutz.gr/search">
  <Param name="keyphrase" value="{searchTerms}"/>
</Url>

Please address these comments and attach a new patch. Thanks.
Attachment #415378 - Flags: review? → review-
OK this should be OK : http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/el/rev/17886fa56501 

For the skroutz plugin: Seems that there is not any contact information in skroutz.gr site. ( I've found only a dev@skroutz.gr email in a disclaimer about shop prices)
(In reply to comment #10)
> OK this should be OK :
> http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/el/rev/17886fa56501 

Yep, this looks good indeed. Thanks, Kostas. Please make sure that you opt in with the new revision so that we can include this in the build.

> For the skroutz plugin: Seems that there is not any contact information in
> skroutz.gr site. ( I've found only a dev@skroutz.gr email in a disclaimer about
> shop prices)

I sent an email to dev@. We'll see if anybody responds. Thanks for your help.
I have received the permission from Vasilis Dimos of skroutz. The URL to use in the plugin is:

http://www.skroutz.gr/search?keyphrase={searchTerms}&browser=ffmob

I also have a 32x32px icon from them, but it's all gray and transparent, which will just blend with our UI's background :( I asked them to provide a different icon.
Here's a new patch.

* added new, larger icon
* added a second parameter to the search query, as requested by the Skroutz.gr team
* tested on Fennec b6pre nightly on Nokia n810

Kostas, feel free to land this patch and opt in with the new revision.
Attachment #415378 - Attachment is obsolete: true
Attachment #415665 - Flags: review+
(In reply to comment #13)
> Created an attachment (id=415665) [details]
> New patch with Skroutz.gr
> 
> Here's a new patch.
> 
> * added new, larger icon
> * added a second parameter to the search query, as requested by the Skroutz.gr
> team
> * tested on Fennec b6pre nightly on Nokia n810
> 
> Kostas, feel free to land this patch and opt in with the new revision.

Thanks...  patch landed with rev http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/el/rev/deb804e65100 .  Opted in also with this new revison
Resolved -fixed since last year
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.