528598 - provide a class to check for KDE environment and to interface with kmozillahelper

Status: RESOLVED WONTFIX

(Core :: General, enhancement)

Description

[Wolfgang Rosenauer [:wolfiR]]

For further KDE specific integration we need to provide a class or component which checks for KDE desktop and support and takes over the communication with the external kmozillahelper.

Comment 1

[Reed Loden [:reed]]

We have to use an external helper? No way we can just support KDE natively like we already do GNOME?

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

I'm not that deep into KDE but the original author wrote:
"I don't have the ability of some other KDE developers to have clones, and I'm not crazy enough to try to mix Gtk and Qt in one process (which, despite the possibility of a shared event loop, should be nowhere near trivial)."
http://www.kdedevelopers.org/node/4099

It's might be possible but I don't see anyone investing that much effort.

Comment 3

[Marco Poletti]

Attachment: kde preferences

Comment 4

[Marco Poletti]

Attachment: Part of the KDE support, named firefox-kde.patch in openSUSE

Comment 5

[Marco Poletti]

Attachment: Part of the KDE support (toolkit), named mozilla-kde.patch in openSUSE

Comment 6

[Marco Poletti]

Attachment: Avoids using gconf for non-gnome DE

Comment 7

[Marco Poletti]

I've now attached the current patches openSUSE is using as per Robert's comment to bug 528510.
If you some of them belong in other bugs, please attach them there.

Comment 8

[Wolfgang Rosenauer [:wolfiR]]

(In reply to Marco Poletti from comment #6)
> Created attachment 711728 [details] [diff] [review]
> Avoids using gconf for non-gnome DE

This one is currently discussed in bug 824341.
Please note that it's also "resolved" if libproxy usage is enabled in Firefox which is not the default compile option.

Comment 9

[Launchpad]

Cédric Bellegarde added the following comment to Launchpad bug report 949949:

It's really needed, chromium already have full KDE support...

-- 
http://launchpad.net/bugs/949949

Comment 10

[Cédric Bellegarde]

https://bugzilla.mozilla.org/show_bug.cgi?id=140751

Comment 11

[GrantK]

This issue -- of improving KDE + Firefox integration, generally, and of getting Firefox to use Dolphin, specifically -- has languished for a long time.

It has, after all, been percolating, unresolved, for ~ 12 yrs now.

Atm, it's basically dead & inactive. I'm hoping that that can be reversed.

If "you" are still interested in good/solid KDE+Firefox integration, read-on -- 

IMO, not getting to a decent solution has not been for lack of trying/interest:

	Bug 140751 - Integrate Mozilla with KDE 
	https://bugzilla.mozilla.org/show_bug.cgi?id=140751 

	Bug 528598 - provide a class to check for KDE environment and to interface with kmozillahelper 
	https://bugzilla.mozilla.org/show_bug.cgi?id=528598

	Provide better Firefox KDE integration 
	https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/494067 

	Bug 528510 - [Tracking] Port OpenSUSE KDE Integration for Firefox 
	https://bugzilla.mozilla.org/show_bug.cgi?id=528510

	Firefox on KDE
	https://groups.google.com/forum/#!topic/mozilla.dev.platforms.linux/XKyWG8NwSeA 

	(I'm sure there are more ...)

As of this date, there's still no solution that works consistently well.  Opensuse's patches are the closest to it (cref packages: "kmozillahelper", "mozilla-kde4-integration"), & have been intermittently available/functional in Opensuse, as well as ported to Ubuntu, Arch, others.

But, even the Opensuse devs say they're not happy with their own, 'hacky' solution.

And, unless I've missed it, the "right people" simply aren't talking to one another.

A "good" solution will need devs -- at least one each -- from KDE, Mozilla/Firefox & Opensuse/other distro devs, to agree that this should get done, and actually talk/work with one another to do so.

I've tried to re-start the discussion about getting a good solution to KDE+Firefox integration.

	https://mail.mozilla.org/pipermail/firefox-dev/2014-July/001940.html

In that thread I received thoughtful/arguable comments from @Mozilla folks, e.g.

	"...
	I believe that there is plenty of good will among
	Mozilla developers to help Firefox + Dolphin along the road (starting
	with reviewing patches and mentoring newcomers).
	...
	firefox-dev and bugs are as good a place as any to start.
	..."

They certainly seem willing to work with KDE & others -- but it will NOT happen alone.

So, if "you" are still interested in good/solid KDE+Firefox integration -- pls start by subscribing to "firexfox-dev" mailing list

	https://mail.mozilla.org/listinfo/firefox-dev

and consolidating communication to THIS thread:

	"Firefox + KDE integration: Getting FF to use Dolphin reliably. 12+ years and counting."
	 https://mail.mozilla.org/pipermail/firefox-dev/2014-July/001940.html

'Everybody' talking about the issue in one place wouldn't, imo, be a bad 1st step.

Comment 12

[(no longer active)]

The patches on this bug are from last year and I doubt they apply cleanly on trunk any more.  If someone has updated patches, please feel free to post them.  Please note that in order to get your patches landed, it's usually a good idea to divide them into small self-contained patches that can be reviewed and checked in individually.  Giant patches like attachment 711727 [details] [diff] [review] that touch all kinds of code in the tree are extremely hard to push through...

Comment 13

[M Lopez-Ibanez]

On a clean Kubuntu 14.04 installation with a new Firefox profile, Firefox offers to open JPEG files with "Hugin PTO generator" and only with that. Chromium does not offer choices, but it opens it with Gwenview, which is the default. I wonder if Chromium is simply using xdg-open unconditionally. Nonetheless, it is completely obscure even to advanced users how Firefox ends up with "Hugin PTO" as the only choice.

Comment 14

[Gérard Talbot]

(In reply to M Lopez-Ibanez from comment #13)
> On a clean Kubuntu 14.04 installation with a new Firefox profile, Firefox
> offers to open JPEG files with "Hugin PTO generator" and only with that.

Which application is set up to handle JPEG files in KDE's System Settings/File Associations/Image/jpeg ?

Which application is set up in Firefox to handle JPEG files in Edit/Preferences/Applications tab/JPEG images?

Gérard

Comment 15

[M Lopez-Ibanez]

(In reply to Gérard Talbot from comment #14)
> (In reply to M Lopez-Ibanez from comment #13)
> > On a clean Kubuntu 14.04 installation with a new Firefox profile, Firefox
> > offers to open JPEG files with "Hugin PTO generator" and only with that.
> 
> Which application is set up to handle JPEG files in KDE's System
> Settings/File Associations/Image/jpeg ?

Gwenview, then GIMP, then ImageMagick.

> Which application is set up in Firefox to handle JPEG files in
> Edit/Preferences/Applications tab/JPEG images?

Hugin PTO generator (it is the only option apart from Always ask and Save to file)