"Choose color for text" / "Choose color for background" not disabled like everything else

RESOLVED FIXED in Thunderbird 21.0

Status

Thunderbird
Message Compose Window
--
trivial
RESOLVED FIXED
8 years ago
4 years ago

People

(Reporter: Denny Crane, Assigned: aceman)

Tracking

(Blocks: 1 bug, {polish})

Trunk
Thunderbird 21.0
polish
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

4.63 KB, patch
Magnus Melin
: review+
bwinton
: ui-review+
Details | Diff | Splinter Review
(Reporter)

Description

8 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091105 Fedora/3.5.5-1.fc11 Firefox/3.5.5
Build Identifier: Thunderbird/3.0b4

In the formatting bar, there are buttons which have tooltips reading "Choose color for text" and "Choose color for background" -- when the user selects/focuses a field other than the e-mail body, these buttons are NOT disabled, whereas every other button in the formatting bar is.

Bug is applicable to Thunderbird 2 as well as Thunderbird 3 beta 4.

Reproducible: Always

Steps to Reproduce:
1.Click "Write" button from main Thunderbird window
2.Move cursor back and forth between Subject and Body.
3.Observe that all options but those mentioned are disabled when the cursor is in the Subject input.
Actual Results:  
"Choose color for text" and "Choose color for background" are not disabled.

Expected Results:  
"Choose color for text" and "Choose color for background" should be disabled.
Confirming.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: x86 → All
(Assignee)

Comment 2

5 years ago
I've added the disabled style for this toolbar item in bug 271730 so let's use it here too.
Assignee: nobody → acelists
Depends on: 271730
Keywords: polish
Version: unspecified → Trunk
(Assignee)

Comment 3

5 years ago
Created attachment 690100 [details] [diff] [review]
patch
Attachment #690100 - Flags: ui-review?(bwinton)
Attachment #690100 - Flags: review?(mkmelin+mozilla)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED

Comment 4

5 years ago
Comment on attachment 690100 [details] [diff] [review]
patch

Review of attachment 690100 [details] [diff] [review]:
-----------------------------------------------------------------

Nice polish! r=mkmelin
Attachment #690100 - Flags: review?(mkmelin+mozilla) → review+

Updated

5 years ago
Blocks: 360488
Comment on attachment 690100 [details] [diff] [review]
patch

I agree, nice polish!

Thanks, and I apologize for the delay.
Blake.
Attachment #690100 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/95e659704cba
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 21.0
(Assignee)

Updated

4 years ago
Depends on: 883540
You need to log in before you can comment on or make changes to this bug.