528793 - "Choose color for text" / "Choose color for background" not disabled like everything else

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Denny Crane]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091105 Fedora/3.5.5-1.fc11 Firefox/3.5.5
Build Identifier: Thunderbird/3.0b4

In the formatting bar, there are buttons which have tooltips reading "Choose color for text" and "Choose color for background" -- when the user selects/focuses a field other than the e-mail body, these buttons are NOT disabled, whereas every other button in the formatting bar is.

Bug is applicable to Thunderbird 2 as well as Thunderbird 3 beta 4.

Reproducible: Always

Steps to Reproduce:
1.Click "Write" button from main Thunderbird window
2.Move cursor back and forth between Subject and Body.
3.Observe that all options but those mentioned are disabled when the cursor is in the Subject input.
Actual Results:  
"Choose color for text" and "Choose color for background" are not disabled.

Expected Results:  
"Choose color for text" and "Choose color for background" should be disabled.

Comment 1

[Ludovic Hirlimann [:Usul]]

Confirming.

Comment 2

[:aceman]

I've added the disabled style for this toolbar item in bug 271730 so let's use it here too.

Comment 3

[:aceman]

Attachment: patch

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 690100 [details] [diff] [review]
patch

Review of attachment 690100 [details] [diff] [review]:
-----------------------------------------------------------------

Nice polish! r=mkmelin

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 690100 [details] [diff] [review]
patch

I agree, nice polish!

Thanks, and I apologize for the delay.
Blake.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/95e659704cba