Last Comment Bug 528793 - "Choose color for text" / "Choose color for background" not disabled like everything else
: "Choose color for text" / "Choose color for background" not disabled like eve...
Status: RESOLVED FIXED
: polish
Product: Thunderbird
Classification: Client Software
Component: Message Compose Window (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Thunderbird 21.0
Assigned To: :aceman
:
Mentors:
Depends on: 271730 883540
Blocks: TB2SM
  Show dependency treegraph
 
Reported: 2009-11-15 06:20 PST by Denny Crane
Modified: 2014-02-06 08:27 PST (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (4.63 KB, patch)
2012-12-08 08:01 PST, :aceman
mkmelin+mozilla: review+
bwinton: ui‑review+
Details | Diff | Splinter Review

Description Denny Crane 2009-11-15 06:20:47 PST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091105 Fedora/3.5.5-1.fc11 Firefox/3.5.5
Build Identifier: Thunderbird/3.0b4

In the formatting bar, there are buttons which have tooltips reading "Choose color for text" and "Choose color for background" -- when the user selects/focuses a field other than the e-mail body, these buttons are NOT disabled, whereas every other button in the formatting bar is.

Bug is applicable to Thunderbird 2 as well as Thunderbird 3 beta 4.

Reproducible: Always

Steps to Reproduce:
1.Click "Write" button from main Thunderbird window
2.Move cursor back and forth between Subject and Body.
3.Observe that all options but those mentioned are disabled when the cursor is in the Subject input.
Actual Results:  
"Choose color for text" and "Choose color for background" are not disabled.

Expected Results:  
"Choose color for text" and "Choose color for background" should be disabled.
Comment 1 Ludovic Hirlimann [:Usul] 2009-11-17 02:14:37 PST
Confirming.
Comment 2 :aceman 2012-11-19 06:38:43 PST
I've added the disabled style for this toolbar item in bug 271730 so let's use it here too.
Comment 3 :aceman 2012-12-08 08:01:51 PST
Created attachment 690100 [details] [diff] [review]
patch
Comment 4 Magnus Melin 2012-12-09 02:54:10 PST
Comment on attachment 690100 [details] [diff] [review]
patch

Review of attachment 690100 [details] [diff] [review]:
-----------------------------------------------------------------

Nice polish! r=mkmelin
Comment 5 Blake Winton (:bwinton) (:☕️) 2013-02-02 18:26:56 PST
Comment on attachment 690100 [details] [diff] [review]
patch

I agree, nice polish!

Thanks, and I apologize for the delay.
Blake.
Comment 6 Ryan VanderMeulen [:RyanVM] 2013-02-04 10:43:49 PST
https://hg.mozilla.org/comm-central/rev/95e659704cba

Note You need to log in before you can comment on or make changes to this bug.