528865 - Enter_bug should automatically show hidden fields if they're pre-filled

Status: ASSIGNED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[timeless]

User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_8; en-us) AppleWebKit/531.21.8 (KHTML, like Gecko) Version/4.0.4 Safari/531.21.10

Steps:
1. create a bookmarkable bug template with a value in "blocks"
2. load it <https://bugzilla.mozilla.org/enter_bug.cgi?alias=&assigned_to=create-and-change%40bugzilla.bugs&blocked=bmo-regressions&bug_file_loc=show_bug.cgi%3Fid%3D494683%23a0&bug_severity=normal&bug_status=NEW&cf_blocking_193=---&cf_status_192=---&comment=User-Agent%3A%20Mozilla%2F5.0%20%28Macintosh%3B%20U%3B%20Intel%20Mac%20OS%20X%2010_5_8%3B%20en-us%29%20AppleWebKit%2F531.21.8%20%28KHTML%2C%20like%20Gecko%29%20Version%2F4.0.3%20Safari%2F531.9%0D%0A%0D%0ASteps%3A%0D%0A0.%20%0D%0A1.%20load%20bug%20494683%0D%0A2.%20scroll%20to%20attachments%0D%0A3.%20&component=Creating%2FChanging%20Bugs&contenttypeentry=&contenttypemethod=autodetect&contenttypeselection=text%2Fplain&data=&dependson=&description=&flag_type-254=X&flag_type-297=X&flag_type-38=X&flag_type-381=X&flag_type-504=X&flag_type-552=X&flag_type-553=X&flag_type-554=X&flag_type-7=X&flag_type-74=X&form_name=enter_bug&keywords=&maketemplate=Remember%20values%20as%20bookmarkable%20template&op_sys=Mac%20OS%20X&priority=--&product=Bugzilla&qa_contact=default-qa%40bugzilla.bugs&rep_platform=x86&short_desc=&target_milestone=---&version=3.4.3>

expected results:
if there are any values filled in which can't be seen when "Hide Advanced Fields" is active, then "Hide Advanced Fields" should not be active.

actual results:
Fields that are filled in aren't visible

Comment 2

[Reed Loden [:reed]]

Attachment: patch - v1

How about we cheat a bit here and display all the fields if the bug is either a cloned bug or if a template is used? Would that make everybody happy?

Comment 3

[Guy Pyrzak]

I'd refer to check if any of the ugly fields are filled in first, but since cloning and templates are "kinda" advanced features and not being used by a new user I'm less concerned. 

It wouldn't be that hard to check those fields but i'm pretty sure that the current implementation of hiding fields doesn't actually know what fields it is hiding it just knows the classes.

I'd R+ this based on the code but I do think this is mkanat's concept. 

EITHER way, there should be something filed to make sure that any hidden fields show up as plain text if they are filled in b/c that would be wierd and confusing.

Comment 4

[Max Kanat-Alexander]

Comment on attachment 429308 [details] [diff] [review]
patch - v1

No, that doesn't work, maketemplate isn't used when pre-filling fields.

Comment 5

[Reed Loden [:reed]]

(In reply to comment #4)
> (From update of attachment 429308 [details] [diff] [review])
> No, that doesn't work, maketemplate isn't used when pre-filling fields.

On 3.4, it was used in the case of prefilling group checkboxes... That seems to have changed on trunk, however.

From 3.4's enter_bug.cgi:
    elsif(formvalue("maketemplate") ne "") {
        $check = formvalue("bit-$id", 0);
    }

Oh well. Guess we'll have to go with something more complicated.