Closed Bug 530403 Opened 15 years ago Closed 15 years ago

Port bug 187741 - age in days should default to "is less than"

Categories

(Thunderbird :: Search, enhancement)

Product:
Thunderbird
Component:
Search
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.1a1

People

(Reporter: wsmwk, Assigned: rsx11m.pub)

References

Details

Attachments

(1 file, 2 obsolete files)

Proposed patch (v3)
1.21 KB, patch
rsx11m.pub
: review+
clarkbw
: ui-review+
Details | Diff | Splinter Review 
age in days should default to "is less than".  This has been annoying for years. Surprisingly I can't find a bug on it.

comparatively, what % of people would be searching for messages of an exact age or date?  ugh
Not MailNews Core, works for me on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.6pre) Gecko/20091121 SeaMonkey/2.0.1pre with "is less than"
being the default already. Thus, that's specific to Thunderbird (also implying that there must be some SeaMonkey code to copy from).
Component: Filters → Search
OS: Windows Vista → All
Product: MailNews Core → Thunderbird
QA Contact: filters → search
Hardware: x86 → All
Version: 1.9.1 Branch → Trunk
indeed, bug 187741  "Age in days" search should default to "is less than"
Yes, found that too. I naively applied bug 187741 attachment 403895 [details] [diff] [review]
on Thunderbird, but it didn't work. The default says "is less than" now,
I'm getting different results though when using the default versus selecting
it manually after going to another option. Anyway, that patch may be a good starting point.
Actually, it doesn't work in SeaMonkey either by default. Filed bug 530406.
Neil's follow-up patch for SeaMonkey was checked in today and should work, thus I've given this another try for porting to Thunderbird. For what I can tell, it now picks (and also applies!) the desired default value.
Summary: age in days should default to "is less than" → Port bug 187741 - age in days should default to "is less than"
Attached patch Proposed patch (obsolete) — — Splinter Review 
This combines bug 187741 attachment 403895 [details] [diff] [review] with the follow-up patch
from bug 530406 attachment 413936 [details] [diff] [review]. I retained the reference to the
original bug as I can't really claim intellectual property on that patch. :-)
Assignee: nobody → rsx11m.pub
Attachment #414943 - Flags: ui-review?(clarkbw)
Attachment #414943 - Flags: review?(mkmelin+mozilla)
Comment on attachment 414943 [details] [diff] [review]
Proposed patch

r=mkmelin, but remove the bug ref - it's not needed and also confusing
Attachment #414943 - Flags: review?(mkmelin+mozilla) → review+
Attached patch Proposed patch (v2) (obsolete) — — Splinter Review 
Thanks for the review, updated patch with comment removed.
Attachment #414943 - Attachment is obsolete: true
Attachment #415018 - Flags: ui-review?(clarkbw)
Attachment #415018 - Flags: review+
Attachment #414943 - Flags: ui-review?(clarkbw)
The comment was quite useful, just not the bug ref ;)
Oops... :-)
Attachment #415018 - Attachment is obsolete: true
Attachment #415112 - Flags: ui-review?(clarkbw)
Attachment #415112 - Flags: review+
Attachment #415018 - Flags: ui-review?(clarkbw)
Attachment #415112 - Flags: ui-review?(clarkbw) → ui-review+
All set, push for comm-central please.
Keywords: checkin-needed
Whiteboard: [c-n: comm-central]
Checked in: http://hg.mozilla.org/comm-central/rev/4d4c13a0ba25
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: comm-central]
Target Milestone: --- → Thunderbird 3.1a1
Depends on: 187741, 530406
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: