531332 - Enable FastStart service with the EXE installer

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Alex Pakhotin (:alexp)]

Installer has to create a start-up shortcut to FennecFastStart.exe, and run fast-start service at the end of installation.

Comment 1

[Alex Pakhotin (:alexp)]

Attachment: Fix

If there is a faststart.exe in the installation, create a start-up shortcut to it, and run this service at the last step of the installation.

Comment 2

[Alex Pakhotin (:alexp)]

Attachment: Fix

Updated patch includes:
- Create fast-start shortcut
- Run fast-start service from the installer
- Remove fast-start shortcut from the uninstaller

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 414864 [details] [diff] [review]
Fix

Is it really not possible to create a shortcut with command line parameters? SHCreateShortcut msdn documentation seems to imply that it is, in which case we could just modify the parameters used for the shortcuts and avoid using the stub entirely (and perhaps get rid of it in a followup bug?). I guess we'd need some other way to determine whether we should install a faststart shortcut, though...

Is CSIDL_STARTUP exposed in any way on WinCE? I know that it is on desktop windows, which made me wonder whether we care about the localizability of "FastStart" in the link name at some point (not really something to worry about now, I guess).

>diff --git a/toolkit/mozapps/installer/wince/nsInstallerDlg.cpp b/toolkit/mozapps/installer/wince/nsInstallerDlg.cpp

> BOOL nsInstallerDlg::CreateShortcut()

>+    _snwprintf(sShortcutPath, MAX_PATH, L"%s\\%s.lnk", sProgramsPath, Strings.GetString(StrID_AppShortName));

Where is StrID_AppShortName, out of curiousity?

>+BOOL nsInstallerDlg::FastStartFileExists()

>+  return (GetFileAttributes(sFastStartPath) != (DWORD)-1);

Can't this use INVALID_FILE_ATTRIBUTES rather than (DWORD)-1?

>diff --git a/toolkit/mozapps/installer/wince/uninstall/Uninstall.cpp b/toolkit/mozapps/installer/wince/uninstall/Uninstall.cpp

> BOOL DeleteShortcut(HWND hwndParent)

Worth adding a comment in CreateShortcut to make sure to keep the file paths in sync with ones here, perhaps?

r=me with those addressed.

Comment 4

[Alex Pakhotin (:alexp)]

(In reply to comment #3)
> Is it really not possible to create a shortcut with command line parameters?

It is possible. I decided to use the faststart.exe considering the following: it is already there, conditionally compiled; it has already been working fine with CAB installer; it's easier to run manually and create a shortcut if needed; we can control the way how fast-start service is run separately from the installer (we may have it separate from Fennec.exe itself - some smaller EXE, which just speeds up launch of the browser, but does not keep the whole application in the background).
And at the moment it's easier just to check if that EXE exists to decide if we are using the fast-start service.
We may reconsider this later and get rid of faststart.exe.

> Is CSIDL_STARTUP exposed in any way on WinCE? I know that it is on desktop
> windows, which made me wonder whether we care about the localizability of
> "FastStart" in the link name at some point

It doesn't seem to be exposed in the UI. That's just a folder under \Windows.

> Where is StrID_AppShortName, out of curiousity?

Right now the name is hard-coded in the setup.ini, but this will be fixed in the bug 531908.

> >+  return (GetFileAttributes(sFastStartPath) != (DWORD)-1);
> 
> Can't this use INVALID_FILE_ATTRIBUTES rather than (DWORD)-1?

This is strange, but WinMo documentation does not mention INVALID_FILE_ATTRIBUTES, it says "0xFFFFFFFF indicates failure". But INVALID_FILE_ATTRIBUTES is defined in the SDK, I'll use it then.

Comment 5

[Alex Pakhotin (:alexp)]

Attachment: Updated fix

Code review changes.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/af12f12f11b0

Comment 7

[Aakash Desai [:aakashd]]

verified its running on build:
Mozilla/5.0 (Windows; U; Window3sCE 5.2; en-US; rv:1.9.2b5pre) Gecko/20091201 Namoroka/3.6b5pre Fennec/1.0a4pre


...filed a follow-up bug: bug 532115

Comment 8

[Karl Tomlinson (:karlt)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/320f38bc7455