531498 - Fennec Desktop L10n builds for Mac are not localized

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Francesco Lodolo [:flod]]

In localized Fennec desktop builds for Mac the whole interface (labels, searchplugins, bookmarks) remains in English. 

Some other information:
* The package contains the right locale.jar and locale.manifest files, also update.locale and crashreporter are localized.
* It seems to involve all locales (tried with French, Italian and Danish) and both latest-mobile-trunk-l10n and latest-mobile-1.9.2-l10n builds.
* Win32 builds work as expected.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

The en-US mac build puts almost all the files in
  Contents/Frameworks/XUL.framework
including en-US.jar and setting
  pref("general.useragent.locale", "en-US");
in 
 Contents/Frameworks/XUL.framework/Versions/1.9.2b5pre/defaults/pref/xulrunner.js
(There's another copy of en-US.jar at Contents/Resources/chrome/). The interesting exception is the launcher at Contents/MacOS/fennec, the only file in the MacOS dir.

The Italian mac build adds it.jar to Contents/MacOS/chrome/ and doesn't touch the xulrunner.js file, so it doesn't match what en-US does. Since we repack en-US to get a locale this causes problems.

If you look at the windows zips, then all the ab-CD.jar files are in fennec/chrome, and the value of general.useragent.locale in fennec/defaults/preferences/mobile-l10n.js changes between locales.

This looks to me like an intersection of XULRunner packaging and localization that we haven't explored before, and probably belongs in Core::Build Config.

Comment 2

[[e-mail] (:bhearsum)]

I agree with Nick, this seems like a Build config issue

Comment 3

[Axel Hecht [:Pike]]

Moving over to Fennec, then.

Comment 4

[Chris Cooper [:coop] (he/him)]

Attachment: [checked in] Disable Fennec desktop repacks on Mac until process is fixed

Comment 5

[Chris Cooper [:coop] (he/him)]

Comment on attachment 415217 [details] [diff] [review]
[checked in] Disable Fennec desktop repacks on Mac until process is fixed

http://hg.mozilla.org/build/buildbot-configs/rev/578c317dad45

Comment 6

[Chris Cooper [:coop] (he/him)]

(In reply to comment #4)
> Disable Fennec desktop repacks on Mac until process is fixed

Master has been reconfig-ed for this. Mac desktop repacks are now disabled.

Comment 7

[(no longer active)]

This blocks me and probably others from being able to test localized Fennec builds.  Is there any ETA on this being fixed?

Comment 8

[Axel Hecht [:Pike]]

coop, can you clean up the ftp dir with the non-localized builds?

Ehsan, can you try to test the linux builds on a VM? I think that we have loads of macs with l10n-drivers and other now-moz folks, but in the wild, not so many. And we prioritized this off in favor of doing a release factory etc.

Comment 9

[(no longer active)]

(In reply to comment #8)
> Ehsan, can you try to test the linux builds on a VM? I think that we have loads
> of macs with l10n-drivers and other now-moz folks, but in the wild, not so
> many. And we prioritized this off in favor of doing a release factory etc.

I can definitely do that.  I don't have a Linux VM right now, but I guess I can use my Linux laptop at home, if this can't be fixed soon enough.

Comment 10

[Guillermo López :willyaranda (probably SLOW response)]

I'm having this bug too with the latest 30-Nov nightly, and it seems is the last build for Mac.

Well, for me it's not a problem since I have other OS in my Mac to test, but I think that this bug should be fixed because some localizers use only Mac, and having installed other OS or virtual machines is not an ideal solution.

Comment 11

[Chris Cooper [:coop] (he/him)]

(In reply to comment #8)
> coop, can you clean up the ftp dir with the non-localized builds?

Done.

Comment 12

[Brian King [:kinger]]

I just tried a Windows desktop build for sl and it is coming up in English.

Comment 13

[Axel Hecht [:Pike]]

(In reply to comment #12)
> I just tried a Windows desktop build for sl and it is coming up in English.

That's probably because those are old and the slovene locale builds being busted right now with a locale problem. Working on fixing the latter.

Comment 14

[Aki Sasaki (not active)]

This appears to be a fennec-on-xulrunner localization issue for mac, which probably still exists.

However, since we're building a non-xr fennec at this point, I wondered if this still applied. Ben kindly ran a de repack on osx fennec in staging, and it appears to work.

Not sure if we want to morph this bug into either "mac localization repacks on xr broken", or "please reenable [non-xr] fennec osx repacks", or resolve and deal with reenabling with a different bug.

Comment 15

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #14)
> This appears to be a fennec-on-xulrunner localization issue for mac, which
> probably still exists.
> 
> However, since we're building a non-xr fennec at this point, I wondered if this
> still applied. Ben kindly ran a de repack on osx fennec in staging, and it
> appears to work.
> 
> Not sure if we want to morph this bug into either "mac localization repacks on
> xr broken", or "please reenable [non-xr] fennec osx repacks", or resolve and
> deal with reenabling with a different bug.

bhearsum filed bug#625144.

Comment 16

[Aki Sasaki (not active)]

This was fixed a while ago.
http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-central-macosx-l10n/