Last Comment Bug 531645 - "My Yahoo" should be "My Yahoo!" in the list of feed handlers (Port Bug 432118)
: "My Yahoo" should be "My Yahoo!" in the list of feed handlers (Port Bug 432118)
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Feed Discovery and Preview (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: seamonkey2.1a1
Assigned To: Philip Chee
:
:
Mentors:
Depends on: 432118
Blocks:
  Show dependency treegraph
 
Reported: 2009-11-29 07:37 PST by Philip Chee
Modified: 2009-12-04 14:06 PST (History)
1 user (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch v1.0 My Yahooooo!! [Checkin: Comment 3] (1.17 KB, patch)
2009-11-29 07:44 PST, Philip Chee
neil: review+
neil: superreview+
kairo: approval‑seamonkey2.0.1-
Details | Diff | Splinter Review

Description Philip Chee 2009-11-29 07:37:06 PST
+++ This bug was initially created as a clone of Bug #432118 +++
[quote]
This bug is similar to bug 264822.  According to bug 264822 comment 14, Yahoo!'s name should have an exclamation point.  I assume that this is true for "My Yahoo!" as well?  Fortunately, unlike bug 264822, the feed settings are not saved based on the name, so it's possible to change the name without disrupting user settings.
[/quote]
Comment 1 Philip Chee 2009-11-29 07:44:13 PST
Created attachment 414995 [details] [diff] [review]
Patch v1.0 My Yahooooo!!
[Checkin: Comment 3]

One! line! no! brainer!
Comment 2 neil@parkwaycc.co.uk 2009-11-29 12:22:04 PST
Comment on attachment 414995 [details] [diff] [review]
Patch v1.0 My Yahooooo!!
[Checkin: Comment 3]

Pity I can only set the flag to + ;-)
Comment 3 Serge Gautherie (:sgautherie) 2009-12-03 08:13:56 PST
Comment on attachment 414995 [details] [diff] [review]
Patch v1.0 My Yahooooo!!
[Checkin: Comment 3]


http://hg.mozilla.org/comm-central/rev/a742d7543f51
Comment 4 Serge Gautherie (:sgautherie) 2009-12-03 10:51:18 PST
Comment on attachment 414995 [details] [diff] [review]
Patch v1.0 My Yahooooo!!
[Checkin: Comment 3]

"approval-seamonkey2.0.1=?":
No risk, but is this considered a l10n string change?
Comment 5 Philip Chee 2009-12-03 11:01:37 PST
> but is this considered a l10n string change?
The Firefox devs don't think so. Correcting spelling mistakes don't count I don't think.
Comment 6 Robert Kaiser 2009-12-03 12:07:37 PST
Comment on attachment 414995 [details] [diff] [review]
Patch v1.0 My Yahooooo!!
[Checkin: Comment 3]

String change, turning down because of string freeze.

Note You need to log in before you can comment on or make changes to this bug.