Closed Bug 531645 Opened 11 years ago Closed 11 years ago

"My Yahoo" should be "My Yahoo!" in the list of feed handlers (Port Bug 432118)

Categories

(SeaMonkey :: Feed Discovery and Preview, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1a1

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #432118 +++
[quote]
This bug is similar to bug 264822.  According to bug 264822 comment 14, Yahoo!'s name should have an exclamation point.  I assume that this is true for "My Yahoo!" as well?  Fortunately, unlike bug 264822, the feed settings are not saved based on the name, so it's possible to change the name without disrupting user settings.
[/quote]
One! line! no! brainer!
Attachment #414995 - Flags: superreview?(neil)
Attachment #414995 - Flags: review?(neil)
See Also: → 432118
Attachment #414995 - Flags: superreview?(neil)
Attachment #414995 - Flags: superreview+
Attachment #414995 - Flags: review?(neil)
Attachment #414995 - Flags: review+
Comment on attachment 414995 [details] [diff] [review]
Patch v1.0 My Yahooooo!!
[Checkin: Comment 3]

Pity I can only set the flag to + ;-)
Keywords: checkin-needed
Comment on attachment 414995 [details] [diff] [review]
Patch v1.0 My Yahooooo!!
[Checkin: Comment 3]


http://hg.mozilla.org/comm-central/rev/a742d7543f51
Attachment #414995 - Attachment description: Patch v1.0 My Yahooooo!! → Patch v1.0 My Yahooooo!! [Checkin: Comment 3]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Depends on: 432118
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
See Also: 432118
Target Milestone: --- → seamonkey2.1a1
Attachment #414995 - Flags: approval-seamonkey2.0.1?
Comment on attachment 414995 [details] [diff] [review]
Patch v1.0 My Yahooooo!!
[Checkin: Comment 3]

"approval-seamonkey2.0.1=?":
No risk, but is this considered a l10n string change?
> but is this considered a l10n string change?
The Firefox devs don't think so. Correcting spelling mistakes don't count I don't think.
Comment on attachment 414995 [details] [diff] [review]
Patch v1.0 My Yahooooo!!
[Checkin: Comment 3]

String change, turning down because of string freeze.
Attachment #414995 - Flags: approval-seamonkey2.0.1? → approval-seamonkey2.0.1-
You need to log in before you can comment on or make changes to this bug.