432118 - "My Yahoo" should be "My Yahoo!" in the list of feed handlers

Status: VERIFIED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Kai Liu]

This bug is similar to bug 264822.  According to bug 264822 comment 14, Yahoo!'s name should have an exclamation point.  I assume that this is true for "My Yahoo!" as well?  Fortunately, unlike bug 264822, the feed settings are not saved based on the name, so it's possible to change the name without disrupting user settings.

Since it's so late, I assume that this is something for the next release?

(BTW, AFAIK, this and bug 264822 are the only two places missing the "!"--the mail handler got it right.)

Comment 1

[Tanner M. Young [:tmyoung]]

Attachment: Patch for en-US locale

This is also the case in 104 locales http://mxr.mozilla.org/l10n-central/search?string=my+yahoo[^!]&regexp=on&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-central

I leave it to Kev and Axel to determine if we should also change those.

Comment 2

[Robert Sayre]

kev, does this change need to be made?

Comment 3

[Kev Needham [:kev]]

It should be made, if it can be without mucking things up. "Yahoo!" is the proper name/trademark, and should be used when referencing Yahoo! or a Yahoo! property where possible.

Comment 4

[Robert Sayre]

should we change all the locales with one patch? I'm not really sure what the etiquette is here.

Comment 5

[Kev Needham [:kev]]

we should probably do this in 3.6, and ask l10n to coordinate with the regional localization teams to make the changes to theit specific locales. this is how we've done other changes that affect the product as a whole.

Comment 6

[Axel Hecht [:Pike]]

There is no "one patch" possible, as we're having separate repos per locale.

If we decide that we want to do it, it's probably on stas' lap to rewrite and land as there's out-of-band tracking to make sure that the productization files don't get broken, which he maintains.

Comment 7

[Tanner M. Young [:tmyoung]]

Axel, Kev: If there is anything that I could do to help, just let me know.

Comment 8

[Tanner M. Young [:tmyoung]]

Should this be an l10n bug now?  And should we reassign to stas, since I have the en-US patch and the other patches would be done by him?

Comment 9

[Dão Gottwald [:dao]]

The patch didn't apply, probably because it didn't have any context at all.

http://hg.mozilla.org/mozilla-central/rev/72074ac5a64e

Comment 10

[Tanner M. Young [:tmyoung]]

Verified Fixed on Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20091017 Minefield/3.7a1pre (.NET CLR 3.5.30729) ID:20091017051221

Stas, Kev, Pike: Do we want an l10n bug for the other localizations?