Closed
Bug 532143
Opened 15 years ago
Closed 15 years ago
NetUtil.newURI should take a string or nsIFile
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: dietrich, Assigned: sdwilsh)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
|
3.84 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Updated•15 years ago
|
Assignee: nobody → sdwilsh
|
Assignee | |
Comment 1•15 years ago
|
||
Not sold on the the first parameter's name, but I could not come up with anything better. Open to suggestions.
Attachment #415490 -
Flags: superreview?(vladimir)
Attachment #415490 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs review bz][needs sr vlad]
|
||
Comment 2•15 years ago
|
||
Comment on attachment 415490 [details] [diff] [review]
v1.0
Why not just leave it called aSpec?
Attachment #415490 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
(In reply to comment #2)
> (From update of attachment 415490 [details] [diff] [review])
> Why not just leave it called aSpec?
It didn't seem quite right, but I can certainly change it back. I do not have a strong opinion on this.
Whiteboard: [needs review bz][needs sr vlad] → [needs sr vlad]
|
|
Assignee | |
Comment 4•15 years ago
|
||
How about aTarget?
|
|
||
Comment 5•15 years ago
|
||
(In reply to comment #4)
> How about aTarget?
Sold.
|
|
Assignee | |
Comment 6•15 years ago
|
||
Fixed locally. Will attach a new patch once vlad does his sr.
Attachment #415490 -
Flags: superreview?(vladimir) → superreview+
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs sr vlad]
|
|
Assignee | |
Comment 7•15 years ago
|
||
For checkin (with commit message)
Attachment #415490 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•15 years ago
|
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [can land]
|
|
Assignee | |
Updated•15 years ago
|
Keywords: dev-doc-needed
|
|
Reporter | |
Comment 8•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [can land]
|
||
Updated•15 years ago
|
Whiteboard: [doc-waiting-1.9.3]
|
|
||
Comment 9•15 years ago
|
||
Documentation updated:
https://developer.mozilla.org/en/JavaScript_code_modules/NetUtil.jsm
Keywords: dev-doc-needed → dev-doc-complete
Whiteboard: [doc-waiting-1.9.3]
You need to log in
before you can comment on or make changes to this bug.
Description
•