NetUtil.newURI should take a string or nsIFile

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Core
Networking
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: dietrich, Assigned: sdwilsh)

Tracking

({dev-doc-complete})

Trunk
mozilla1.9.3a1
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Reporter)

Updated

8 years ago
Assignee: nobody → sdwilsh
(Reporter)

Updated

8 years ago
Blocks: 532146
(Reporter)

Updated

8 years ago
Blocks: 532147
(Assignee)

Comment 1

8 years ago
Created attachment 415490 [details] [diff] [review]
v1.0

Not sold on the the first parameter's name, but I could not come up with anything better.  Open to suggestions.
Attachment #415490 - Flags: superreview?(vladimir)
Attachment #415490 - Flags: review?(bzbarsky)
(Assignee)

Updated

8 years ago
Whiteboard: [needs review bz][needs sr vlad]
Comment on attachment 415490 [details] [diff] [review]
v1.0

Why not just leave it called aSpec?
Attachment #415490 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

8 years ago
(In reply to comment #2)
> (From update of attachment 415490 [details] [diff] [review])
> Why not just leave it called aSpec?
It didn't seem quite right, but I can certainly change it back.  I do not have a strong opinion on this.
Whiteboard: [needs review bz][needs sr vlad] → [needs sr vlad]
(Assignee)

Comment 4

8 years ago
How about aTarget?
(In reply to comment #4)
> How about aTarget?

Sold.
(Assignee)

Comment 6

8 years ago
Fixed locally.  Will attach a new patch once vlad does his sr.
Attachment #415490 - Flags: superreview?(vladimir) → superreview+
(Assignee)

Updated

8 years ago
Whiteboard: [needs sr vlad]
(Assignee)

Comment 7

8 years ago
Created attachment 415672 [details] [diff] [review]
v1.1

For checkin (with commit message)
Attachment #415490 - Attachment is obsolete: true
(Assignee)

Updated

8 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.3a1
(Assignee)

Updated

8 years ago
No longer blocks: 532147
(Assignee)

Updated

8 years ago
Whiteboard: [can land]
(Assignee)

Updated

8 years ago
Keywords: dev-doc-needed
(Reporter)

Comment 8

8 years ago
http://hg.mozilla.org/mozilla-central/rev/873fd3ad6ae3
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [can land]
Whiteboard: [doc-waiting-1.9.3]
Documentation updated:

https://developer.mozilla.org/en/JavaScript_code_modules/NetUtil.jsm
Keywords: dev-doc-needed → dev-doc-complete
Whiteboard: [doc-waiting-1.9.3]
You need to log in before you can comment on or make changes to this bug.