Created attachment 415490 [details] [diff] [review] v1.0 Not sold on the the first parameter's name, but I could not come up with anything better. Open to suggestions.
Whiteboard: [needs review bz][needs sr vlad]
Comment on attachment 415490 [details] [diff] [review] v1.0 Why not just leave it called aSpec?
Attachment #415490 - Flags: review?(bzbarsky) → review+
(In reply to comment #2) > (From update of attachment 415490 [details] [diff] [review]) > Why not just leave it called aSpec? It didn't seem quite right, but I can certainly change it back. I do not have a strong opinion on this.
Whiteboard: [needs review bz][needs sr vlad] → [needs sr vlad]
How about aTarget?
(In reply to comment #4) > How about aTarget? Sold.
Fixed locally. Will attach a new patch once vlad does his sr.
Attachment #415490 - Flags: superreview?(vladimir) → superreview+
Created attachment 415672 [details] [diff] [review] v1.1 For checkin (with commit message)
Attachment #415490 - Attachment is obsolete: true
Target Milestone: --- → mozilla1.9.3a1
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Whiteboard: [can land]
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.