Closed Bug 532143 Opened 15 years ago Closed 15 years ago

NetUtil.newURI should take a string or nsIFile

Categories

(Core :: Networking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: dietrich, Assigned: sdwilsh)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → sdwilsh
Blocks: 532146
Blocks: 532147
Attached patch v1.0 (obsolete) — Splinter Review
Not sold on the the first parameter's name, but I could not come up with anything better. Open to suggestions.
Attachment #415490 - Flags: superreview?(vladimir)
Attachment #415490 - Flags: review?(bzbarsky)
Whiteboard: [needs review bz][needs sr vlad]
Comment on attachment 415490 [details] [diff] [review] v1.0 Why not just leave it called aSpec?
Attachment #415490 - Flags: review?(bzbarsky) → review+
(In reply to comment #2) > (From update of attachment 415490 [details] [diff] [review]) > Why not just leave it called aSpec? It didn't seem quite right, but I can certainly change it back. I do not have a strong opinion on this.
Whiteboard: [needs review bz][needs sr vlad] → [needs sr vlad]
How about aTarget?
(In reply to comment #4) > How about aTarget? Sold.
Fixed locally. Will attach a new patch once vlad does his sr.
Attachment #415490 - Flags: superreview?(vladimir) → superreview+
Whiteboard: [needs sr vlad]
Attached patch v1.1Splinter Review
For checkin (with commit message)
Attachment #415490 - Attachment is obsolete: true
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.3a1
No longer blocks: 532147
Whiteboard: [can land]
Keywords: dev-doc-needed
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [can land]
Whiteboard: [doc-waiting-1.9.3]
Whiteboard: [doc-waiting-1.9.3]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: