NetUtil.asyncFetch should take an nsIURI, string, nsIFile, or nsIChannel

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Core
Networking
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: dietrich, Assigned: sdwilsh)

Tracking

({dev-doc-complete})

Trunk
mozilla1.9.3a1
dev-doc-complete
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
(Reporter)

Updated

8 years ago
Assignee: nobody → sdwilsh
(Reporter)

Updated

8 years ago
Depends on: 532143
(Reporter)

Updated

8 years ago
Blocks: 532150
(Assignee)

Updated

8 years ago
Summary: NetUtil.fetch should take an nsIURI, string or channel → NetUtil.asyncFetch should take an nsIURI, string, nsIFile, or nsIChannel
(Assignee)

Comment 1

8 years ago
Created attachment 415516 [details] [diff] [review]
v1.0

The bulk of this is new tests.  The code changes are trivial.  Hurray for tests!
Attachment #415516 - Flags: superreview?(vladimir)
Attachment #415516 - Flags: review?(bzbarsky)
(Assignee)

Updated

8 years ago
Whiteboard: [needs review bz][needs sr vlad]
Attachment #415516 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 2

8 years ago
I need to remember to update the last test I added to remove the test file I create when it is done.
Whiteboard: [needs review bz][needs sr vlad] → [needs sr vlad]
(Assignee)

Comment 3

8 years ago
(In reply to comment #2)
> I need to remember to update the last test I added to remove the test file I
> create when it is done.
Fixed this locally.  I'll upload a new patch once vlad does his sr.
Attachment #415516 - Flags: superreview?(vladimir) → superreview+
(Assignee)

Updated

8 years ago
Whiteboard: [needs sr vlad]
(Assignee)

Comment 4

8 years ago
Created attachment 415673 [details] [diff] [review]
v1.1

For checkin (with commit message)
Attachment #415516 - Attachment is obsolete: true
(Assignee)

Updated

8 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.3a1
(Assignee)

Updated

8 years ago
Depends on: 532146
No longer depends on: 532143
Whiteboard: [can land]
(Assignee)

Updated

8 years ago
Keywords: dev-doc-needed
(Reporter)

Comment 5

8 years ago
http://hg.mozilla.org/mozilla-central/rev/8707d444a7f8
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [can land]
(Reporter)

Comment 6

8 years ago
backed out due to test failure
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 7

8 years ago
Created attachment 419319 [details] [diff] [review]
v1.2

This should fix the test issues that came up.
Attachment #415673 - Attachment is obsolete: true
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
(Assignee)

Comment 8

8 years ago
http://hg.mozilla.org/mozilla-central/rev/caaa274d3b5f
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
https://developer.mozilla.org/en/JavaScript_code_modules/NetUtil.jsm

This article has been updated.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.