Closed
Bug 532147
Opened 15 years ago
Closed 15 years ago
NetUtil.asyncFetch should take an nsIURI, string, nsIFile, or nsIChannel
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: dietrich, Assigned: sdwilsh)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 2 obsolete files)
|
6.66 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Updated•15 years ago
|
Assignee: nobody → sdwilsh
|
Assignee | |
Updated•15 years ago
|
Summary: NetUtil.fetch should take an nsIURI, string or channel → NetUtil.asyncFetch should take an nsIURI, string, nsIFile, or nsIChannel
|
|
Assignee | |
Comment 1•15 years ago
|
||
The bulk of this is new tests. The code changes are trivial. Hurray for tests!
Attachment #415516 -
Flags: superreview?(vladimir)
Attachment #415516 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs review bz][needs sr vlad]
|
||
Updated•15 years ago
|
Attachment #415516 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
I need to remember to update the last test I added to remove the test file I create when it is done.
Whiteboard: [needs review bz][needs sr vlad] → [needs sr vlad]
|
|
Assignee | |
Comment 3•15 years ago
|
||
(In reply to comment #2)
> I need to remember to update the last test I added to remove the test file I
> create when it is done.
Fixed this locally. I'll upload a new patch once vlad does his sr.
Attachment #415516 -
Flags: superreview?(vladimir) → superreview+
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs sr vlad]
|
|
Assignee | |
Comment 4•15 years ago
|
||
For checkin (with commit message)
Attachment #415516 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•15 years ago
|
|
|
Assignee | |
Updated•15 years ago
|
|
|
Assignee | |
Updated•15 years ago
|
Keywords: dev-doc-needed
|
|
Reporter | |
Comment 5•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [can land]
|
|
Reporter | |
Comment 6•15 years ago
|
||
backed out due to test failure
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 7•15 years ago
|
||
This should fix the test issues that came up.
Attachment #415673 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 8•15 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
|
||
Comment 9•15 years ago
|
||
https://developer.mozilla.org/en/JavaScript_code_modules/NetUtil.jsm
This article has been updated.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•