Closed Bug 532147 Opened 11 years ago Closed 11 years ago

NetUtil.asyncFetch should take an nsIURI, string, nsIFile, or nsIChannel

Categories

(Core :: Networking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: dietrich, Assigned: sdwilsh)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 2 obsolete files)

No description provided.
Assignee: nobody → sdwilsh
Depends on: 532143
Blocks: 532150
Summary: NetUtil.fetch should take an nsIURI, string or channel → NetUtil.asyncFetch should take an nsIURI, string, nsIFile, or nsIChannel
Attached patch v1.0 (obsolete) — Splinter Review
The bulk of this is new tests.  The code changes are trivial.  Hurray for tests!
Attachment #415516 - Flags: superreview?(vladimir)
Attachment #415516 - Flags: review?(bzbarsky)
Whiteboard: [needs review bz][needs sr vlad]
Attachment #415516 - Flags: review?(bzbarsky) → review+
I need to remember to update the last test I added to remove the test file I create when it is done.
Whiteboard: [needs review bz][needs sr vlad] → [needs sr vlad]
(In reply to comment #2)
> I need to remember to update the last test I added to remove the test file I
> create when it is done.
Fixed this locally.  I'll upload a new patch once vlad does his sr.
Attachment #415516 - Flags: superreview?(vladimir) → superreview+
Whiteboard: [needs sr vlad]
Attached patch v1.1 (obsolete) — Splinter Review
For checkin (with commit message)
Attachment #415516 - Attachment is obsolete: true
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.3a1
Depends on: 532146
No longer depends on: 532143
Whiteboard: [can land]
Keywords: dev-doc-needed
http://hg.mozilla.org/mozilla-central/rev/8707d444a7f8
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [can land]
backed out due to test failure
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch v1.2Splinter Review
This should fix the test issues that came up.
Attachment #415673 - Attachment is obsolete: true
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/caaa274d3b5f
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.