NetUtil.asyncFetch should take an nsIURI, string, nsIFile, or nsIChannel

RESOLVED FIXED in mozilla1.9.3a1

Status

()

defect
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: dietrich, Assigned: sdwilsh)

Tracking

({dev-doc-complete})

Trunk
mozilla1.9.3a1
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Reporter

Description

10 years ago
No description provided.
Reporter

Updated

10 years ago
Assignee: nobody → sdwilsh
Reporter

Updated

10 years ago
Depends on: 532143
Reporter

Updated

10 years ago
Blocks: 532150
Assignee

Updated

10 years ago
Summary: NetUtil.fetch should take an nsIURI, string or channel → NetUtil.asyncFetch should take an nsIURI, string, nsIFile, or nsIChannel
Assignee

Comment 1

10 years ago
Posted patch v1.0 (obsolete) — Splinter Review
The bulk of this is new tests.  The code changes are trivial.  Hurray for tests!
Attachment #415516 - Flags: superreview?(vladimir)
Attachment #415516 - Flags: review?(bzbarsky)
Assignee

Updated

10 years ago
Whiteboard: [needs review bz][needs sr vlad]
Attachment #415516 - Flags: review?(bzbarsky) → review+
Assignee

Comment 2

10 years ago
I need to remember to update the last test I added to remove the test file I create when it is done.
Whiteboard: [needs review bz][needs sr vlad] → [needs sr vlad]
Assignee

Comment 3

10 years ago
(In reply to comment #2)
> I need to remember to update the last test I added to remove the test file I
> create when it is done.
Fixed this locally.  I'll upload a new patch once vlad does his sr.
Attachment #415516 - Flags: superreview?(vladimir) → superreview+
Assignee

Updated

10 years ago
Whiteboard: [needs sr vlad]
Assignee

Comment 4

10 years ago
Posted patch v1.1 (obsolete) — Splinter Review
For checkin (with commit message)
Attachment #415516 - Attachment is obsolete: true
Assignee

Updated

10 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.3a1
Assignee

Updated

10 years ago
Depends on: 532146
No longer depends on: 532143
Whiteboard: [can land]
Assignee

Updated

10 years ago
Keywords: dev-doc-needed
Reporter

Comment 5

10 years ago
http://hg.mozilla.org/mozilla-central/rev/8707d444a7f8
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [can land]
Reporter

Comment 6

10 years ago
backed out due to test failure
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee

Comment 7

10 years ago
Posted patch v1.2Splinter Review
This should fix the test issues that came up.
Attachment #415673 - Attachment is obsolete: true
Assignee

Updated

10 years ago
Keywords: checkin-needed
Assignee

Comment 8

10 years ago
http://hg.mozilla.org/mozilla-central/rev/caaa274d3b5f
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.