NetUtil.jsm needs a helper for creating new channels

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Core
Networking
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: dietrich, Assigned: sdwilsh)

Tracking

({dev-doc-complete})

Trunk
mozilla1.9.3a1
dev-doc-complete
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Comment hidden (empty)
(Reporter)

Updated

8 years ago
Assignee: nobody → sdwilsh
(Reporter)

Updated

8 years ago
Depends on: 532143
(Assignee)

Comment 1

8 years ago
This should take a string uri, an nsIURI, or an nsIFile, right?
(Reporter)

Comment 2

8 years ago
Yes.
What's wrong with NS_NewChannel in nsNetUtil.h?  Are you asking for a JS or C++ interface here?
(Assignee)

Comment 4

8 years ago
(In reply to comment #3)
> What's wrong with NS_NewChannel in nsNetUtil.h?  Are you asking for a JS or C++
> interface here?
NetUtil.jsm is for JavaScript.  C++ has all sorts of nice helpers, but JavaScript isn't so lucky.  I've been slowly fixing this.
(Assignee)

Comment 5

8 years ago
Created attachment 415506 [details] [diff] [review]
v1.0
Attachment #415506 - Flags: superreview?(vladimir)
Attachment #415506 - Flags: review?(bzbarsky)
(Assignee)

Updated

8 years ago
Whiteboard: [needs review asuth][needs sr vlad]
(Assignee)

Updated

8 years ago
Whiteboard: [needs review asuth][needs sr vlad] → [needs review bz][needs sr vlad]
Comment on attachment 415506 [details] [diff] [review]
v1.0

Maybe s/aSpecifier/aURISpec/ and be done with it?
Attachment #415506 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 7

8 years ago
(In reply to comment #6)
> (From update of attachment 415506 [details] [diff] [review])
> Maybe s/aSpecifier/aURISpec/ and be done with it?
That doesn't describe an nsIFile though, right?
(Assignee)

Updated

8 years ago
Whiteboard: [needs review bz][needs sr vlad] → [needs sr vlad]
It describes it at least as well as aSpecifier does.  My other thoughts had been along the lines of aTarget or aThingieToLoad....
aWhatToLoad?
(Assignee)

Comment 10

8 years ago
(In reply to comment #9)
> aWhatToLoad?
Sold.
(Assignee)

Updated

8 years ago
Summary: NetUtil needs a helper for creating new channels → NetUtil.jsm needs a helper for creating new channels
(Assignee)

Comment 11

8 years ago
Created attachment 415511 [details] [diff] [review]
v1.1

Name change plus an additional test I should have had in the first place.
Attachment #415506 - Attachment is obsolete: true
Attachment #415511 - Flags: superreview?(vladimir)
Attachment #415506 - Flags: superreview?(vladimir)
Attachment #415511 - Flags: superreview?(vladimir) → superreview+
(Assignee)

Updated

8 years ago
Whiteboard: [needs sr vlad]
(Assignee)

Comment 12

8 years ago
Created attachment 415674 [details] [diff] [review]
v1.2

For checkin (with commit message)
Attachment #415511 - Attachment is obsolete: true
(Assignee)

Updated

8 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [can land]
Target Milestone: --- → mozilla1.9.3a1
(Assignee)

Updated

8 years ago
Blocks: 532147
(Assignee)

Updated

8 years ago
Keywords: dev-doc-needed
(Reporter)

Comment 13

8 years ago
http://hg.mozilla.org/mozilla-central/rev/fb25cd2cc1d6
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [can land]
(Reporter)

Comment 14

8 years ago
backed out due to test failure
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 15

8 years ago
Created attachment 419317 [details] [diff] [review]
v1.3

This should fix the test issues.
Attachment #415674 - Attachment is obsolete: true
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
(Assignee)

Comment 16

8 years ago
http://hg.mozilla.org/mozilla-central/rev/404e56019315
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Updated the docs here:

https://developer.mozilla.org/en/JavaScript_code_modules/NetUtil.jsm
Keywords: dev-doc-needed → dev-doc-complete
(Assignee)

Comment 18

7 years ago
(In reply to comment #17)
> Updated the docs here:
> 
> https://developer.mozilla.org/en/JavaScript_code_modules/NetUtil.jsm
There seems to be a wiki error in the section that would cover this.
Oops. Fixed.
You need to log in before you can comment on or make changes to this bug.