Closed
Bug 532146
Opened 15 years ago
Closed 15 years ago
NetUtil.jsm needs a helper for creating new channels
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: dietrich, Assigned: sdwilsh)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 3 obsolete files)
|
6.26 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Updated•15 years ago
|
Assignee: nobody → sdwilsh
|
Assignee | |
Comment 1•15 years ago
|
||
This should take a string uri, an nsIURI, or an nsIFile, right?
|
|
Reporter | |
Comment 2•15 years ago
|
||
Yes.
|
||
Comment 3•15 years ago
|
||
What's wrong with NS_NewChannel in nsNetUtil.h? Are you asking for a JS or C++ interface here?
|
|
Assignee | |
Comment 4•15 years ago
|
||
(In reply to comment #3)
> What's wrong with NS_NewChannel in nsNetUtil.h? Are you asking for a JS or C++
> interface here?
NetUtil.jsm is for JavaScript. C++ has all sorts of nice helpers, but JavaScript isn't so lucky. I've been slowly fixing this.
|
|
Assignee | |
Comment 5•15 years ago
|
||
Attachment #415506 -
Flags: superreview?(vladimir)
Attachment #415506 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs review asuth][needs sr vlad]
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs review asuth][needs sr vlad] → [needs review bz][needs sr vlad]
|
||
Comment 6•15 years ago
|
||
Comment on attachment 415506 [details] [diff] [review]
v1.0
Maybe s/aSpecifier/aURISpec/ and be done with it?
Attachment #415506 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 7•15 years ago
|
||
(In reply to comment #6)
> (From update of attachment 415506 [details] [diff] [review])
> Maybe s/aSpecifier/aURISpec/ and be done with it?
That doesn't describe an nsIFile though, right?
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs review bz][needs sr vlad] → [needs sr vlad]
|
|
||
Comment 8•15 years ago
|
||
It describes it at least as well as aSpecifier does. My other thoughts had been along the lines of aTarget or aThingieToLoad....
|
|
||
Comment 9•15 years ago
|
||
aWhatToLoad?
|
|
Assignee | |
Comment 10•15 years ago
|
||
(In reply to comment #9)
> aWhatToLoad?
Sold.
|
|
Assignee | |
Updated•15 years ago
|
Summary: NetUtil needs a helper for creating new channels → NetUtil.jsm needs a helper for creating new channels
|
|
Assignee | |
Comment 11•15 years ago
|
||
Name change plus an additional test I should have had in the first place.
Attachment #415506 -
Attachment is obsolete: true
Attachment #415511 -
Flags: superreview?(vladimir)
Attachment #415506 -
Flags: superreview?(vladimir)
Attachment #415511 -
Flags: superreview?(vladimir) → superreview+
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs sr vlad]
|
|
Assignee | |
Comment 12•15 years ago
|
||
For checkin (with commit message)
Attachment #415511 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•15 years ago
|
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [can land]
Target Milestone: --- → mozilla1.9.3a1
|
|
Assignee | |
Updated•15 years ago
|
Keywords: dev-doc-needed
|
|
Reporter | |
Comment 13•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [can land]
|
|
Reporter | |
Comment 14•15 years ago
|
||
backed out due to test failure
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 15•15 years ago
|
||
This should fix the test issues.
Attachment #415674 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 16•15 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
|
||
Comment 17•15 years ago
|
||
Updated the docs here:
https://developer.mozilla.org/en/JavaScript_code_modules/NetUtil.jsm
Keywords: dev-doc-needed → dev-doc-complete
|
|
Assignee | |
Comment 18•15 years ago
|
||
(In reply to comment #17)
> Updated the docs here:
>
> https://developer.mozilla.org/en/JavaScript_code_modules/NetUtil.jsm
There seems to be a wiki error in the section that would cover this.
|
|
||
Comment 19•15 years ago
|
||
Oops. Fixed.
You need to log in
before you can comment on or make changes to this bug.
Description
•