533351 - Featured personas roundabout section is broken in hebrew

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Localization, defect, P4)

Description

[krupa raj[:krupa]]

steps to reproduce:
1.Load https://addons.mozilla.org/he/firefox/personas/


observed behavior:
Featured personas roundabout section is broken in hebrew.

screenshot:http://screencast.com/t/ODAzZDRiNzg

Comment 1

[Wil Clouser [:clouserw]]

This may be pretty complex, but CCing Ehsan if he has time to look at it.

Comment 2

[(no longer active)]

Attachment: Patch (v1)

Hopefully this patch fixes the issues.

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 416770 [details] [diff] [review]
Patch (v1)

This works way better than what we have.  One question though, I have to click the right arrow and then the images (and indicator) scroll left.  I don't think that's what we want.

Comment 4

[(no longer active)]

(In reply to comment #3)
> (From update of attachment 416770 [details] [diff] [review])
> This works way better than what we have.  One question though, I have to click
> the right arrow and then the images (and indicator) scroll left.  I don't think
> that's what we want.

I think I need to see it in action.  Is it OK to land this patch and try it on preview?  I'll back it out if it's seriously wrong, before trying another solution.  :-)

Comment 5

[Wil Clouser [:clouserw]]

Oh, I didn't realize you didn't have a dev copy setup.  Yeah, go ahead and land.  This is a way better than what we have.

Comment 6

[(no longer active)]

Landed as r57682.

Comment 7

[(no longer active)]

There seems to be only 1 featured persona in preview, which makes testing this feature silly :-)

https://preview.addons.mozilla.org/fa/firefox/personas/

Can you please add a few more?

Comment 8

[Wil Clouser [:clouserw]]

whoops, done.

Comment 9

[(no longer active)]

Attachment: Further fixes

OK, this should fix the problem completely.  I mispalced the slider controls, but the direction of animation is correct.

Comment 10

[Wil Clouser [:clouserw]]

Comment on attachment 417035 [details] [diff] [review]
Further fixes

do it!

Comment 11

[(no longer active)]

Committed in r57691.

Comment 12

[(no longer active)]

Looks good to me.