Closed Bug 533351 Opened 15 years ago Closed 15 years ago

Featured personas roundabout section is broken in hebrew

Categories

(addons.mozilla.org Graveyard :: Localization, defect, P4)

x86
All
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: krupa.mozbugs, Assigned: ehsan.akhgari)

References

()

Details

(Keywords: rtl)

Attachments

(2 files)

steps to reproduce:
1.Load https://addons.mozilla.org/he/firefox/personas/


observed behavior:
Featured personas roundabout section is broken in hebrew.

screenshot:http://screencast.com/t/ODAzZDRiNzg
This may be pretty complex, but CCing Ehsan if he has time to look at it.
Keywords: rtl
Priority: -- → P4
Attached patch Patch (v1)Splinter Review
Hopefully this patch fixes the issues.
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #416770 - Flags: review?(clouserw)
Blocks: amo2009-rtl
Comment on attachment 416770 [details] [diff] [review]
Patch (v1)

This works way better than what we have.  One question though, I have to click the right arrow and then the images (and indicator) scroll left.  I don't think that's what we want.
Attachment #416770 - Flags: review?(clouserw) → review+
(In reply to comment #3)
> (From update of attachment 416770 [details] [diff] [review])
> This works way better than what we have.  One question though, I have to click
> the right arrow and then the images (and indicator) scroll left.  I don't think
> that's what we want.

I think I need to see it in action.  Is it OK to land this patch and try it on preview?  I'll back it out if it's seriously wrong, before trying another solution.  :-)
Oh, I didn't realize you didn't have a dev copy setup.  Yeah, go ahead and land.  This is a way better than what we have.
Landed as r57682.
There seems to be only 1 featured persona in preview, which makes testing this feature silly :-)

https://preview.addons.mozilla.org/fa/firefox/personas/

Can you please add a few more?
whoops, done.
Attached patch Further fixesSplinter Review
OK, this should fix the problem completely.  I mispalced the slider controls, but the direction of animation is correct.
Attachment #417035 - Flags: review?(clouserw)
Comment on attachment 417035 [details] [diff] [review]
Further fixes

do it!
Attachment #417035 - Flags: review?(clouserw) → review+
Committed in r57691.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Looks good to me.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: