534139 - [ja] use japanese specific google search plug-in for Fennec

Status: RESOLVED FIXED

(Mozilla Localizations :: ja / Japanese, defect)

Description

[dynamis (Tomoya ASAI)]

Current ja/ja-JP-mac Fennec use global google serchplugin but Google Japan (they confirmed with Google US) require to use hl=ja parameter and use www.google.co.jp domain for search query urls.
They request to use same parameter as we use for ja/ja-JP-mac Firefox (for PC).

So I request approval to use ja specific google-ja.xml search plug-in.

Comment 1

[dynamis (Tomoya ASAI)]

Attachment: diff of ja firefox and ja fennec google-jp.xml

We use same parameters as desktop firefox but we need update Description and favicon. This patch show the diff between desktop one and mobile one.

Just to make things clear.

Comment 2

[dynamis (Tomoya ASAI)]

Attachment: diff of global google.xml and ja fennec google-jp.xml

This is diff of global/ja-specific google search plug-in
This also just to make things clear.

Comment 3

[dynamis (Tomoya ASAI)]

Attachment: use ja specific google-jp.xml search plug-in

This is the actual change.

See previous two patches to see details of parameters

Comment 4

[dynamis (Tomoya ASAI)]

stas:
Requesting approval to use google-jp.xml for fennec too.

Comment 5

[Staś Małolepszy :stas]

Comment on attachment 417057 [details] [diff] [review]
use ja specific google-jp.xml search plug-in

>+<Url type="text/html" method="GET" template="http://www.google.co.jp/search">
>+  <Param name="q" value="{searchTerms}"/>
>+  <!-- <Param name="lr" value="lang_ja"/> -->
>+  <!-- <Param name="num" value="100"/> -->

Can you remove these params from the file for clarity?

>+  <MozParam name="client" condition="defaultEngine" trueValue="firefox-a" falseValue="firefox"/>

We don't use this in en-US in Fennec. Is it required by Google Japan, or can we remove it?

r=me with these two questions answered.

Comment 6

[dynamis (Tomoya ASAI)]

In short:
I haven't asked about your question by Google Japan. They just require to use same parameters as Firefox one. I thought we should not add any change required by Google and that's why goolge-jp.xml become as my patch.

I'll commit current patch and confirm with Google Japan about client param.
If we need to remove it or some more update, I'll file another bug and request approval again.

(In reply to comment #5)
> (From update of attachment 417057 [details] [diff] [review])
> >+<Url type="text/html" method="GET" template="http://www.google.co.jp/search">
> >+  <Param name="q" value="{searchTerms}"/>

just to make sure: above are required.

> >+  <!-- <Param name="lr" value="lang_ja"/> -->
> >+  <!-- <Param name="num" value="100"/> -->
> 
> Can you remove these params from the file for clarity?

I included these commented out params 'lr' and 'num' just to make Fennec search plug-in as Firefox one except for the description and icon image.
# to keep diff minimal as attachment 417055 [details] [diff] [review]

Originally, I decided to keep (not to delete) optional params as comment just to make customize easy for power users in Firefox 1.0 days. And I just still keep this tradition for google-jp.xml.
When I confirm with google person, I send plug-in including these comments.
They don't require to remove comments and we keep them.

> >+  <MozParam name="client" condition="defaultEngine" trueValue="firefox-a" falseValue="firefox"/>
> 
> We don't use this in en-US in Fennec. Is it required by Google Japan, or can we
> remove it?

I haven't confirmed about this with Google Japan person. They just required to use same parameter as Firefox. Let me confirm about client param with them.
If they require to remove it, I'll file another bug and request approval again.

Comment 7

[dynamis (Tomoya ASAI)]

pushed for both ja/ja-JP-mac
 -> resolved fixed

Comment 8

[Kev Needham [:kev]]

hey folks, wrt comment #0, I have not heard anything from Google Corp. on changing the value of the search URL. 

Google has been specific in the past on using "google.com" and not any localized URLs. I'll ping the PSO group, but I'd also like to understand who Google Japan confirmed it with, and get an email from the PSO group to that effect. Dynamis, could you find out who Google Japan spoke to at Google Corp., so I can touch base with them?

wrt comment #6, the inclusion of the "client" parameter is at Mozilla's discretion, not Google's, and it is our requirement at this point that it not be included with any Fennec locales. Please remove that parameter ASAP. If there are any questions, feel free to contact me.

Thanks much.

Comment 9

[Staś Małolepszy :stas]

Bug 537713 is tracking what Kev said in comment 8.