534147 - Windows 7 taskbar when firefox shortcut is right clicked the Recent list shows files downloaded when private browsing was in effect

Status: RESOLVED WORKSFORME

(Firefox :: Shell Integration, defect)

Description

[Jeremy C]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5

Right clicking on the firefox shortcut of the Win7 Taskbar revealed file names downloaded during a prior private browsing session under the "recent" section although it should not function in this manner, similar to how the download window firefox uses already behaves.

Reproducible: Always

Steps to Reproduce:
1. Start private browsing
2. Download a file
3. Stop private browsing
4. Right-click win7 taskbar shortcut to firefox and see the file listed under recent
Actual Results:  
Files were listed under recent for anyone to come along and right click to reveal in what should have been a private browsing session.

Expected Results:  
Not show the files just as the Download window of firefox handles private browsing once private browsing has been stopped.

Comment 2

[Jim Mathies [:jimm]]

http://mxr.mozilla.org/mozilla-central/source/browser/components/wintaskbar/WindowsJumpLists.jsm#478

At some point I lost the "browser:purge-session-history" observer hookup in a merge. This should be easy to fix.

Comment 3

[Jim Mathies [:jimm]]

Attachment: patch v.1

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 446214 [details] [diff] [review]
patch v.1

This got lost in a merge at some point, the event handler is already present in the jsm.

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 446214 [details] [diff] [review]
patch v.1

actually, this should be in bug 566827.

I just confirmed with ehsan that history service does not collect history info during private browsing mode. I'm guessing this has something to do with our recent downloads setting we populate with windows in the download manager.

Comment 6

[Jim Mathies [:jimm]]

Potentially the problem is right here - 
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/downloads/src/nsDownloadManager.cpp#2234

Jeremy, do you have the addToRecentDocs pref set?

"browser.download.manager.addToRecentDocs"

Comment 7

[[not reading bugmail]]

(In reply to comment #6)
> "browser.download.manager.addToRecentDocs"

The default for this is set to true, i would imagine PB is suppose to bypass this?  I also checked the perf in about:config which doesn't flip while in PB mode.

Comment 8

[Jim Mathies [:jimm]]

(In reply to comment #7)
> (In reply to comment #6)
> > "browser.download.manager.addToRecentDocs"
> 
> The default for this is set to true, i would imagine PB is suppose to bypass
> this?  I also checked the perf in about:config which doesn't flip while in PB
> mode.

The code appears to check 

nsDownloadManager::gDownloadManagerService->mInPrivateBrowsing

so should be latched into privacy mode state. Maybe qa can help confirm.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

When I was testing the patch for bug 398174, I noticed that Windows added files to the "Recent Docs" folder if you used the file picker to save the file (as opposed to having it be saved to your download directory automatically), regardless of whether we added it explicitly or not. That may explain this. I'm not sure that there's anything we can do about it, if that is indeed the problem...

Comment 10

[Diwakar Sharma]

Unable to reproduce the issue: 

OS: Windows-7 32-bit
Browser : Aurora 15.0a2 (2012-07-12)


Steps to Reproduce:
1. Start private browsing
2. Download a file
3. Stop private browsing
4. Right-click win7 taskbar shortcut to firefox and see the file listed under recent

Observed result:

No Files were listed under recent when right clicked to reveal what has been downloaded in a private browsing session. 

Inference :

this issue has been resolved

Comment 11

[Giovanny Gongora [:gioyik]]

Unable to reproduce:

OS: Linux_x86-64
Browser: Aurora 15.0a2, Firefox 17.0b12 build1

I follow the steps but it doesn't occur nothing unexpected, So is posible that in this version of Firefox and Aurora, the issue has been resolved.

Comment 12

[Jonah Ho (AAstar)]

I was unable to reproduce this issue on the latest Nightly and Aurora.

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120624 Firefox/15.0a2
Windows 7 x64

Steps to reproduce:
1. Enter private browsing mode
2. Download a file from www.download.com for testing purposes
3. Close session
4. Right-click Firefox shortcut on taskbar for recent files

I only have "Frequent" and "Tasks" headings and do not have the "Recent" heading.

Resolving as Worksforme