534350 - Add live chat ID management to tiki-adminusers.php

Status: RESOLVED FIXED

(support.mozilla.org Graveyard :: Chat, defect, P2)

Description

[Paul Craciunoiu [:paulc]]

Per https://wiki.mozilla.org/Support/Live_Chat/SUMO_login

Comment 1

[Paul Craciunoiu [:paulc]]

Matthew, can you help clarify what needs to be managed on this page?
I'm thinking:
* livechat_id is listed under list view
* edit livechat_id for each user, listed under "Change user preferences" (the wrench icon) -- i.e. links of the form tiki-user_preferences.php?userId=12345

Anything else?

Comment 2

[Matthew Middleton (:zzxc)]

The livechat_id is the only field that will need to be managed in the admin panel.  Admins will be able to use this to manually migrate accounts that were not migrated by the manual or automatic migration script.  The same requirements forced in tiki-register.php should be enforced here as well.

Comment 3

[Paul Craciunoiu [:paulc]]

(In reply to comment #2)
Just to make sure, by "manually migrate" you mean just editing the livechat_id field for existing SUMO accounts, right? :)

Comment 4

[Matthew Middleton (:zzxc)]

> Just to make sure, by "manually migrate" you mean just editing the livechat_id
> field for existing SUMO accounts, right? :)

correct

Comment 5

[Paul Craciunoiu [:paulc]]

Attachment: v1

Adds livechat id information in two places:
* viewing a list of users (listed under usernames)
* editing/adding a user (listed as an editable input)
I created a separate tiki-adminusers.tpl instead of modifying the default Tiki one.

Comment 6

[James Socol [:jsocol, :james]]

Comment on attachment 417567 [details] [diff] [review]
v1

WFM.

Maybe this is a separate bug, but should we add a read-only Live Chat ID field to the My Account page?

Comment 7

[Paul Craciunoiu [:paulc]]

(In reply to comment #6)
> Maybe this is a separate bug, but should we add a read-only Live Chat ID field
> to the My Account page?
I was thinking about that too. I think Matthew is planning on using the TikiWiki login to lookup users' Live Chat ID, but I'm not sure -- would be less confusing to existing users, IMHO. However, if that's not the case, we should certainly make this field easily visible to users.

Matthew: thoughts?

Comment 8

[Paul Craciunoiu [:paulc]]

Bug 535693 filed for comment 6.

Since Matthew confirmed the regex for livechat_id validation looks good, James: should I just add that '+' to the regex as in bug 534340 comment 15 and commit this (updated with revision numbers, too) patch?

Comment 9

[James Socol [:jsocol, :james]]

Yes, please do.

Comment 10

[Paul Craciunoiu [:paulc]]

Attachment: v2, just added '+' for $livechat_id regex

r58194.
This is the updated version of the patch, only change is an extra '+' (line 20) and the revision numbers.