Closed Bug 534752 Opened 11 years ago Closed 11 years ago
Check previous version's status to determine beta vs
. public in updates
Weave users can't upgrade to 1.0b3 (admin'd to Public) since the update script thinks of 1.0b2 as a Beta version.
Comment on attachment 417573 [details] [diff] [review] considering the previous version's status for beta updates I thought we were going to run it through the beta regex first.
Attachment #417573 - Flags: review?(clouserw) → review+
The query is only run under the $want_beta branch, and $want_beta is determined using the regex.
Status: NEW → RESOLVED
Closed: 11 years ago
Priority: -- → P2
Resolution: --- → FIXED
Jeff, is a testcase something like: 1. Install 1.0b2 from preview 2. Change extensions.update.url to point to https://preview.addons.mozilla.org/update/VersionCheck.php?reqVersion=%REQ_VERSION%&id=%ITEM_ID%&version=%ITEM_VERSION%&maxAppVersion=%ITEM_MAXAPPVERSION%&status=%ITEM_STATUS%&appID=%APP_ID%&appVersion=%APP_VERSION%&appOS=%APP_OS%&appABI=%APP_ABI%&locale=%APP_LOCALE%¤tAppVersion=%CURRENT_APP_VERSION% 3. Try to upgrade That it?
1. Install Weave 1.0b2 from amo. 2. Download 1.0b3 from amo, upload it to preview (so you have something to upgrade to). 3. Change extensions.update.url to preview. 4. Try to upgrade. 5. Profit!
Verified FIXED; worked with Jeff on the steps above. (Jeff also landed a fix in r58082, to help us test, and safeguard against an edge-case.)
Status: RESOLVED → VERIFIED
10 years ago
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.