534752 - Check previous version's status to determine beta vs. public in updates

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[Jeff Balogh (:jbalogh)]

Weave users can't upgrade to 1.0b3 (admin'd to Public) since the update script thinks of 1.0b2 as a Beta version.

Comment 1

[Jeff Balogh (:jbalogh)]

Attachment: considering the previous version's status for beta updates

Comment 2

[Wil Clouser [:clouserw]]

Comment on attachment 417573 [details] [diff] [review]
considering the previous version's status for beta updates

I thought we were going to run it through the beta regex first.

Comment 3

[Jeff Balogh (:jbalogh)]

The query is only run under the $want_beta branch, and $want_beta is determined using the regex.

Comment 4

[Jeff Balogh (:jbalogh)]

r57921

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Jeff, is a testcase something like:

1. Install 1.0b2 from preview
2. Change extensions.update.url to point to https://preview.addons.mozilla.org/update/VersionCheck.php?reqVersion=%REQ_VERSION%&id=%ITEM_ID%&version=%ITEM_VERSION%&maxAppVersion=%ITEM_MAXAPPVERSION%&status=%ITEM_STATUS%&appID=%APP_ID%&appVersion=%APP_VERSION%&appOS=%APP_OS%&appABI=%APP_ABI%&locale=%APP_LOCALE%&currentAppVersion=%CURRENT_APP_VERSION%
3. Try to upgrade

That it?

Comment 6

[Jeff Balogh (:jbalogh)]

1. Install Weave 1.0b2 from amo.
2. Download 1.0b3 from amo, upload it to preview (so you have something to upgrade to).
3. Change extensions.update.url to preview.
4. Try to upgrade.
5. Profit!

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; worked with Jeff on the steps above.

(Jeff also landed a fix in r58082, to help us test, and safeguard against an edge-case.)

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

In-Litmus+: https://litmus.mozilla.org/show_test.cgi?id=9871