Closed Bug 535048 Opened 14 years ago Closed 13 years ago

nsILeakDetector leftovers in the tree

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b7

People

(Reporter: taras.mozilla, Assigned: ewong)

References

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

Removed nsILeakDetector
4.43 KB, patch
khuey
: review+
Details | Diff | Splinter Review 
There is a chunk of code in a DEBUG ifdef in browser.js and a few testcases left

./browser/base/content/browser.js:2135:                                       .createInstance(Components.interfaces.nsILeakDetector);
./netwerk/test/TestAsyncCache.js:39:    var leakDetector = Components.classes["@mozilla.org/xpcom/leakdetector;1"].getService(Components.interfaces.nsILeakDetector);
./netwerk/test/TestDiskCache.js:30:    var leakDetector = Components.classes["@mozilla.org/xpcom/leakdetector;1"].getService(Components.interfaces.nsILeakDetector);
./netwerk/test/TestObjectCache.js:3:    var leakDetector = Components.classes["@mozilla.org/xpcom/leakdetector;1"].getService(Components.interfaces.nsILeakDetector);
./netwerk/test/TestCacheCollisions.js:39:    var leakDetector = Components.classes["@mozilla.org/xpcom/leakdetector;1"].getService(Components.interfaces.nsILeakDetector);
./netwerk/test/TestCachePerformance.js:29:    var leakDetector = Components.classes["@mozilla.org/xpcom/leakdetector;1"].getService(Components.interfaces.nsILeakDetector);
Whiteboard: [good first bug]
Assignee: nobody → ewong
Status: NEW → ASSIGNED

        Attachment #476240 -
        Flags: review?(khuey)

    
  

        Attachment #476240 -
        Flags: superreview?(ted.mielczarek)

    
  

        Attachment #476240 -
        Flags: superreview?(ted.mielczarek)

    
  
Keywords: checkin-needed
Whiteboard: [good first bug] → [good first bug] [after branch]

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/875dc86045d0
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [good first bug] [after branch] → [good first bug]
Target Milestone: --- → mozilla2.0b7
Depends on: 597694
Flags: in-testsuite-
OS: Linux → All
Hardware: x86 → All
Depends on: 597403
No longer depends on: 597694

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.