Last Comment Bug 597694 - Remove nsILeakDetector leftovers in SeaMonkey
: Remove nsILeakDetector leftovers in SeaMonkey
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: UI Design (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b1
Assigned To: Serge Gautherie (:sgautherie)
:
:
Mentors:
http://mxr.mozilla.org/comm-central/s...
Depends on:
Blocks: 597403
  Show dependency treegraph
 
Reported: 2010-09-18 08:26 PDT by Serge Gautherie (:sgautherie)
Modified: 2010-09-18 21:24 PDT (History)
1 user (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
(Av1) Just do it [Checked in: See comment 4] (5.85 KB, patch)
2010-09-18 08:43 PDT, Serge Gautherie (:sgautherie)
neil: review+
Details | Diff | Splinter Review

Description Serge Gautherie (:sgautherie) 2010-09-18 08:26:13 PDT
"Port" bug 535048.
Comment 1 Serge Gautherie (:sgautherie) 2010-09-18 08:43:47 PDT
Created attachment 476533 [details] [diff] [review]
(Av1) Just do it
[Checked in: See comment 4]
Comment 2 neil@parkwaycc.co.uk 2010-09-18 16:13:05 PDT
Although it turns out that bug 597403 has an almost identical attachment.
Comment 3 neil@parkwaycc.co.uk 2010-09-18 16:17:22 PDT
Comment on attachment 476533 [details] [diff] [review]
(Av1) Just do it
[Checked in: See comment 4]

> 
>-var gLeakDetector = null;
>-var gLeakDetectorVerbose = false;
> 
This was the only part of your patch that was worse ;-)
Comment 4 neil@parkwaycc.co.uk 2010-09-18 16:25:19 PDT
I thought it was only fair to push the other patch separately, and push this one to comm-central changeset 9e878d36bbaa as additional cleanup.
Comment 5 Serge Gautherie (:sgautherie) 2010-09-18 21:24:15 PDT
(In reply to comment #2)
> Although it turns out that bug 597403 has an almost identical attachment.

Ah! I would have found it if it had been linked to bug 535048 :-<

Note You need to log in before you can comment on or make changes to this bug.