Closed
Bug 597403
Opened 14 years ago
Closed 14 years ago
nsILeakDetector leftovers in the c-c tree
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1b1
People
(Reporter: ewong, Assigned: ewong)
References
Details
Attachments
(1 file, 1 obsolete file)
3.34 KB,
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
From bug #535048, there is an entry for nsILeakDetector
in /suite/debugQA/content/debugQAMenuOverlay.js
* line 87 -- .createInstance(Components.interfaces.nsILeakDetector);
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #476251 -
Flags: review?(bugspam.Callek)
Comment 2•14 years ago
|
||
Comment on attachment 476251 [details] [diff] [review]
Removed nsILeakDetector from c-c tree
From debugQAMenuOverlay.js
window.addEventListener("load", onLoadLeakDetector, false);
needs to be removed.
Also remove:
var gLeakDetector = null;
var gLeakDetectorVerbose = false;
r+ with those fixed
Attachment #476251 -
Flags: review?(bugspam.Callek) → review+
Assignee | ||
Comment 3•14 years ago
|
||
With changes made as per comment #2.
Attachment #476251 -
Attachment is obsolete: true
Attachment #476519 -
Flags: review?(bugspam.Callek)
Updated•14 years ago
|
Attachment #476519 -
Flags: review?(bugspam.Callek) → review+
Comment 4•14 years ago
|
||
Pushed changeset a5cc8fd89b1b to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Component: Build Config → UI Design
Flags: in-testsuite-
OS: Windows 7 → All
QA Contact: build-config → ui-design
Hardware: x86 → All
Target Milestone: --- → seamonkey2.1b1
Version: unspecified → Trunk
Updated•14 years ago
|
Updated•14 years ago
|
Attachment #476519 -
Attachment description: Removed nsILeakDetector from c-c tree → Removed nsILeakDetector from c-c tree
[Checked in: Comment 4]
You need to log in
before you can comment on or make changes to this bug.
Description
•