Last Comment Bug 597403 - nsILeakDetector leftovers in the c-c tree
: nsILeakDetector leftovers in the c-c tree
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: UI Design (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b1
Assigned To: Edmund Wong (:ewong)
:
Mentors:
Depends on: 597694
Blocks: 535048
  Show dependency treegraph
 
Reported: 2010-09-17 07:28 PDT by Edmund Wong (:ewong)
Modified: 2010-09-18 21:21 PDT (History)
3 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Removed nsILeakDetector from c-c tree (2.67 KB, patch)
2010-09-17 08:11 PDT, Edmund Wong (:ewong)
bugspam.Callek: review+
Details | Diff | Splinter Review
Removed nsILeakDetector from c-c tree [Checked in: Comment 4] (3.34 KB, patch)
2010-09-18 06:12 PDT, Edmund Wong (:ewong)
bugspam.Callek: review+
Details | Diff | Splinter Review

Description Edmund Wong (:ewong) 2010-09-17 07:28:45 PDT
From bug #535048, there is an entry for nsILeakDetector
in /suite/debugQA/content/debugQAMenuOverlay.js 
    * line 87 -- .createInstance(Components.interfaces.nsILeakDetector);
Comment 1 Edmund Wong (:ewong) 2010-09-17 08:11:27 PDT
Created attachment 476251 [details] [diff] [review]
Removed nsILeakDetector from c-c tree
Comment 2 Justin Wood (:Callek) (Away until Aug 29) 2010-09-17 08:16:58 PDT
Comment on attachment 476251 [details] [diff] [review]
Removed nsILeakDetector from c-c tree

From debugQAMenuOverlay.js
window.addEventListener("load", onLoadLeakDetector, false);

needs to be removed.

Also remove:
var gLeakDetector = null;
var gLeakDetectorVerbose = false;

r+ with those fixed
Comment 3 Edmund Wong (:ewong) 2010-09-18 06:12:49 PDT
Created attachment 476519 [details] [diff] [review]
Removed nsILeakDetector from c-c tree
[Checked in: Comment 4]

With changes made as per comment #2.
Comment 4 neil@parkwaycc.co.uk 2010-09-18 16:25:48 PDT
Pushed changeset a5cc8fd89b1b to comm-central.

Note You need to log in before you can comment on or make changes to this bug.