Closed Bug 535209 Opened 10 years ago Closed 10 years ago

Need images for "Lanikai" branding

Categories

(Thunderbird :: Build Config, defect)

defect
Not set

Tracking

(blocking-thunderbird3.1 beta1+, thunderbird3.1 beta1-fixed)

RESOLVED FIXED
Thunderbird 3.1b1
Tracking Status
blocking-thunderbird3.1 --- beta1+
thunderbird3.1 --- beta1-fixed

People

(Reporter: standard8, Assigned: andreasn)

References

()

Details

Attachments

(6 files, 3 obsolete files)

As davida has already posted, we're using "Lanakai" for the codename for nightly/unofficial builds of the Thunderbird 3.1 builds.

We need some nice images to replace the current shredder ones (which also need replacing but that's another bug ;-) ).

Most of this consists of coming up with an icon and duplicating what is in mail/branding/nightly into mail/branding/unofficial.

I have a patch which copies the existing stuff and sets things up correctly. I'll post this tomorrow, then pass to andreasn for the image side of things.
an icon of a bird on the beach relaxing under an umbrella?
a bird with sunglasses!
Surfboard.
And according to the wiki page (not David's post ;-) ) its 'Lanikai'.
Summary: Need images for "Lanakai" branding → Need images for "Lanikai" branding
This sets up an initial branding in mail/branding/unofficial using the current nightly icons.

Until we fix bug 535206 the way to build with this branding is:

ac_add_options --with-branding=mail/branding/unofficial

(once bug 535206 is fixed it'll be default).

Andreas will be supplying a patch that builds on this to give us proper Lanikai artwork.

The patch is now on try server building with 1.9.2.
Attachment #418165 - Flags: review?(philringnalda)
The initial patch is here and I'll follow up when necessary, over to Andreas for the actual images.
Assignee: bugzilla → nisses.mail
I like the surfboard idea, since a birds feathers can be printed upon the board similar to the birds in Vancouver [1] and actual surfboards [2][3] and it's possible to vary depending on the future code names.

1. http://www.flickr.com/photos/lhirlimann/4008115549/in/set-72157622271525931/
2. http://www.islandsportshop.com/Images/LS_Digital_Art_Surfboards.jpg
3. http://www.islandsportshop.com/Images/LS_Digital_%20Art_%20Images_2.jpg
Attachment #418165 - Flags: review?(philringnalda) → review+
Comment on attachment 418165 [details] [diff] [review]
[checked in] Set up Branding

I've checked this into comm-central. This is text only changes so far, it can be activated by adding to the mozconfig:

ac_add_options --with-branding=mail/branding/unofficial

We'll enable it by default when we switch 3.1 to gecko 1.9.2 and fix bug 535206 / bug 532633.

http://hg.mozilla.org/comm-central/rev/328bf422b19a
Attachment #418165 - Attachment description: Set up Branding → [checked in] Set up Branding
Version: 3.0 → Trunk
Attached image lanakai branding image (obsolete) —
What about something like this?
Attachment #420095 - Attachment is obsolete: true
Here is the graphics implemented, OSX icons coming up soon. Need to finish the download and install of Xcode Tools first.
and this one includes the graphics for Mac OS X too.
Attachment #421069 - Attachment is obsolete: true
Attachment #421237 - Flags: ui-review?(clarkbw)
Attachment #421237 - Flags: review?(philringnalda)
Flags: blocking-thunderbird3.1?
Flags: blocking-thunderbird3.1? → blocking-thunderbird3.1+
Comment on attachment 421237 [details] [diff] [review]
[checked in] branding graphics for linux, windows, osx

This looks like a good start but I don't feel like it's quite ready.  I'm hoping for a bit more polish in the icon and I feel like we should do something different for the smaller sizes.  

I'll try to add some real feedback by Monday.  And since I've been slow on the turnaround for this so far I think we'll have to plan to get these graphics in for the next release instead of this coming one.
Attachment #421237 - Flags: ui-review?(clarkbw) → ui-review-
Attachment #421237 - Flags: review?(philringnalda)
Comment on attachment 421237 [details] [diff] [review]
[checked in] branding graphics for linux, windows, osx

changeset:   4710:0d8aabd78c66
tag:         tip
user:        Philippe M. Chiasson <gozer@mozillamessaging.com>
date:        Tue Jan 19 14:28:56 2010 -0500
summary:     Bug 535209 - "Lanikai" branding rs=dmose, ui-r=clarkbw, a=dmose
Attachment #421237 - Attachment description: branding graphics for linux, windows, osx → [checked in] branding graphics for linux, windows, osx
Comment on attachment 421237 [details] [diff] [review]
[checked in] branding graphics for linux, windows, osx

ui-r+ for 3.1a1 given by clarkbw; we're not done yet here, another patch is going to be needed.  andreasn, feel free to do that in this bug, or to resolve this bug and spin off another; whatever's easiest.  rs=dmose, a=dmose for landing.
Attachment #421237 - Flags: ui-review-
Attachment #421237 - Flags: ui-review+
Attachment #421237 - Flags: review?(dmose)
Attachment #421237 - Flags: review?(dmose) → review+
blocking-thunderbird3.1: --- → beta1+
Flags: blocking-thunderbird3.1+
Target Milestone: Thunderbird 3.1a1 → Thunderbird 3.1b1
Attached image polished icon
Here is a updated icon with some more polish that should fit better in the OS X dock. Feedback is welcome!
(In reply to comment #16)
> Created an attachment (id=427311) [details]
> polished icon
> 
> Here is a updated icon with some more polish that should fit better in the OS X
> dock. Feedback is welcome!

This definitely looks better as there's better contrast, but is it possible to get a patch for this to try it out in the right place?
Whiteboard: [needs patch for OS X revised dock icon]
Attached patch lanikai osx dock icon (obsolete) — Splinter Review
Here you are!
Comment on attachment 428196 [details] [diff] [review]
lanikai osx dock icon

r=dmose
Attachment #428196 - Flags: ui-review?(clarkbw)
Attachment #428196 - Flags: review+
Really, I actually meant rs=dmose.  Same difference, more or less.  :-)
Whiteboard: [needs patch for OS X revised dock icon] → [needs ui-review, landing]
(In reply to comment #19)
> Created an attachment (id=428197) [details]
> and here is how it looks in action

It looks almost white to me... what about adding more saturation to the colors?
Comment on attachment 428196 [details] [diff] [review]
lanikai osx dock icon

lets do it!
Attachment #428196 - Flags: ui-review?(clarkbw) → ui-review+
(In reply to comment #22)
> (In reply to comment #19)
> > Created an attachment (id=428197) [details] [details]
> > and here is how it looks in action
> 
> It looks almost white to me... what about adding more saturation to the colors?

Agree that a little more deeper color could make it stand out more but I don't feel like we need to block on that.
Keywords: checkin-needed
Whiteboard: [needs ui-review, landing] → [needs landing]
Here is something Blake can actually check in :)
Wow, I really need to actually make sure that I upload the complete patches next time.
Comment on attachment 428554 [details] [diff] [review]
[checked-in] actually working patch

Checked in as http://hg.mozilla.org/comm-central/rev/844e990256f5
Attachment #428554 - Attachment description: actually working patch → [checked-in] actually working patch
Keywords: checkin-needed
Whiteboard: [needs landing]
Attachment #428196 - Attachment is obsolete: true
We've got the basic issue in good shape, so marking as such.  If someone wants to keep pursuing the the depper color discussed in comment 22 and comment 24, please clone or spin off a new bug for that.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.