535209 - Need images for "Lanikai" branding

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Mark Banner (:standard8)]

As davida has already posted, we're using "Lanakai" for the codename for nightly/unofficial builds of the Thunderbird 3.1 builds.

We need some nice images to replace the current shredder ones (which also need replacing but that's another bug ;-) ).

Most of this consists of coming up with an icon and duplicating what is in mail/branding/nightly into mail/branding/unofficial.

I have a patch which copies the existing stuff and sets things up correctly. I'll post this tomorrow, then pass to andreasn for the image side of things.

Comment 1

[Bryan Clark (DevTools PM) [:clarkbw]]

an icon of a bird on the beach relaxing under an umbrella?

Comment 2

[Andreas Nilsson (:andreasn)]

a bird with sunglasses!

Comment 3

[David Ascher (:davida)]

Surfboard.

Comment 4

[Mark Banner (:standard8)]

And according to the wiki page (not David's post ;-) ) its 'Lanikai'.

Comment 5

[Mark Banner (:standard8)]

Attachment: [checked in] Set up Branding

This sets up an initial branding in mail/branding/unofficial using the current nightly icons.

Until we fix bug 535206 the way to build with this branding is:

ac_add_options --with-branding=mail/branding/unofficial

(once bug 535206 is fixed it'll be default).

Andreas will be supplying a patch that builds on this to give us proper Lanikai artwork.

The patch is now on try server building with 1.9.2.

Comment 6

[Mark Banner (:standard8)]

The initial patch is here and I'll follow up when necessary, over to Andreas for the actual images.

Comment 7

[Andreas Nilsson (:andreasn)]

I like the surfboard idea, since a birds feathers can be printed upon the board similar to the birds in Vancouver [1] and actual surfboards [2][3] and it's possible to vary depending on the future code names.

1. http://www.flickr.com/photos/lhirlimann/4008115549/in/set-72157622271525931/
2. http://www.islandsportshop.com/Images/LS_Digital_Art_Surfboards.jpg
3. http://www.islandsportshop.com/Images/LS_Digital_%20Art_%20Images_2.jpg

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 418165 [details] [diff] [review]
[checked in] Set up Branding

I've checked this into comm-central. This is text only changes so far, it can be activated by adding to the mozconfig:

ac_add_options --with-branding=mail/branding/unofficial

We'll enable it by default when we switch 3.1 to gecko 1.9.2 and fix bug 535206 / bug 532633.

http://hg.mozilla.org/comm-central/rev/328bf422b19a

Comment 9

[Andreas Nilsson (:andreasn)]

Attachment: lanakai branding image

What about something like this?

Comment 10

[Andreas Nilsson (:andreasn)]

Attachment: updated lanikai branding

Comment 11

[Andreas Nilsson (:andreasn)]

Attachment: lanakai branding graphics (linux, windows)

Here is the graphics implemented, OSX icons coming up soon. Need to finish the download and install of Xcode Tools first.

Comment 12

[Andreas Nilsson (:andreasn)]

Attachment: [checked in] branding graphics for linux, windows, osx

and this one includes the graphics for Mac OS X too.

Comment 13

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 421237 [details] [diff] [review]
[checked in] branding graphics for linux, windows, osx

This looks like a good start but I don't feel like it's quite ready.  I'm hoping for a bit more polish in the icon and I feel like we should do something different for the smaller sizes.  

I'll try to add some real feedback by Monday.  And since I've been slow on the turnaround for this so far I think we'll have to plan to get these graphics in for the next release instead of this coming one.

Comment 14

[Philippe M. Chiasson (:gozer)]

Comment on attachment 421237 [details] [diff] [review]
[checked in] branding graphics for linux, windows, osx

changeset:   4710:0d8aabd78c66
tag:         tip
user:        Philippe M. Chiasson <[e-mail]>
date:        Tue Jan 19 14:28:56 2010 -0500
summary:     Bug 535209 - "Lanikai" branding rs=dmose, ui-r=clarkbw, a=dmose

Comment 15

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 421237 [details] [diff] [review]
[checked in] branding graphics for linux, windows, osx

ui-r+ for 3.1a1 given by clarkbw; we're not done yet here, another patch is going to be needed.  andreasn, feel free to do that in this bug, or to resolve this bug and spin off another; whatever's easiest.  rs=dmose, a=dmose for landing.

Comment 16

[Andreas Nilsson (:andreasn)]

Attachment: polished icon

Here is a updated icon with some more polish that should fit better in the OS X dock. Feedback is welcome!

Comment 17

[Mark Banner (:standard8)]

(In reply to comment #16)
> Created an attachment (id=427311) [details]
> polished icon
> 
> Here is a updated icon with some more polish that should fit better in the OS X
> dock. Feedback is welcome!

This definitely looks better as there's better contrast, but is it possible to get a patch for this to try it out in the right place?

Comment 18

[Andreas Nilsson (:andreasn)]

Attachment: lanikai osx dock icon

Here you are!

Comment 19

[Andreas Nilsson (:andreasn)]

Attachment: and here is how it looks in action

Comment 20

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 428196 [details] [diff] [review]
lanikai osx dock icon

r=dmose

Comment 21

[Dan Mosedale (:dmosedale, :dmose)]

Really, I actually meant rs=dmose.  Same difference, more or less.  :-)

Comment 22

[Thomas Stache]

(In reply to comment #19)
> Created an attachment (id=428197) [details]
> and here is how it looks in action

It looks almost white to me... what about adding more saturation to the colors?

Comment 23

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 428196 [details] [diff] [review]
lanikai osx dock icon

lets do it!

Comment 24

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to comment #22)
> (In reply to comment #19)
> > Created an attachment (id=428197) [details] [details]
> > and here is how it looks in action
> 
> It looks almost white to me... what about adding more saturation to the colors?

Agree that a little more deeper color could make it stand out more but I don't feel like we need to block on that.

Comment 25

[Andreas Nilsson (:andreasn)]

Attachment: [checked-in] actually working patch

Here is something Blake can actually check in :)
Wow, I really need to actually make sure that I upload the complete patches next time.

Comment 26

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 428554 [details] [diff] [review]
[checked-in] actually working patch

Checked in as http://hg.mozilla.org/comm-central/rev/844e990256f5

Comment 27

[Dan Mosedale (:dmosedale, :dmose)]

We've got the basic issue in good shape, so marking as such.  If someone wants to keep pursuing the the depper color discussed in comment 22 and comment 24, please clone or spin off a new bug for that.