536024 - When i expand folder-tree on Edit This Bookmark, the bookmarked folder is changed.

Status: RESOLVED DUPLICATE of bug 531302

(Firefox :: Bookmarks & History, defect)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b6pre) Gecko/20091219 Firefox/3.5.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b6pre) Gecko/20091219 Firefox/3.5.5

When i expand folder-tree on Edit This Bookmark, the bookmarked folder is changed.
If I click ok button,the bookmark moves to a different folder.

This issue is critical.

Reproducible: Always

Steps to Reproduce:
1.Start Namoroka with new profile.
2.Open Bookmarks > "Mozilla Firefox" > "Customize Firefox",  Say TAB1.
3.Open in new foreground tab "Getting Started" in the Bookmarks Toolbar. Say TAB2.

4.Click Yellow Star button in the location bar.
5.Expand folder-tree by clicking tree expander.
6.You can confirm that the folder is "Bookmarks Toolbar".It's OK.

7.Select tab (TAB1) of "Customize Firefox".
8.Click Yellow Star button in the location bar.
9.You can confirm that the folder is "Mozilla Firefox". It's OK.

10.Expand folder-tree by clicking tree expander.

Actual Results:  
After Step 10, the folder is changed to "Bookmarks Toolbar" from "Mozilla Firefox"

Expected Results:  
The folder should not be changed.

Comment 1

[Alice0775 White]

This issue does not happen on Shiretoko (Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.7pre) Gecko/20091216 Firefox/3.5.7pre ID:20091216044727 )

This issue happens of Minefield (Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091219 Minefield/3.7a1pre ID:20091219042456)

Comment 2

[Alice0775 White]

Regression window:
Works fine:
http://hg.mozilla.org/mozilla-central/rev/eac99a38d8d9
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2a1pre) Gecko/20090615 Namoroka/3.6a1pre ID:20090615044733

Broken:
http://hg.mozilla.org/mozilla-central/rev/ca8799e74642
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2a1pre) Gecko/20090616 Namoroka/3.6a1pre ID:20090616042639

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=eac99a38d8d9&tochange=ca8799e74642

Comment 3

[Alice0775 White]

WORKAROUND FIX(editBookmarkOverlay.js):

  toggleFolderTreeVisibility: function EIO_toggleFolderTreeVisibility() {
    var expander = this._element("foldersExpander");
    var folderTreeRow = this._element("folderTreeRow");
    if (!folderTreeRow.collapsed) {
      expander.className = "expander-down";
      expander.setAttribute("tooltiptext",
                            expander.getAttribute("tooltiptextdown"));
      folderTreeRow.collapsed = true;
      this._element("chooseFolderSeparator").hidden =
        this._element("chooseFolderMenuItem").hidden = false;
    }
    else {
+      var currentFolder = this._getFolderIdFromMenuList();
      expander.className = "expander-up"
      expander.setAttribute("tooltiptext",
                            expander.getAttribute("tooltiptextup"));
      folderTreeRow.collapsed = false;

      // XXXmano: Ideally we would only do this once, but for some odd reason,
      // the editable mode set on this tree, together with its collapsed state
      // breaks the view.
      const FOLDER_TREE_PLACE_URI =
        "place:excludeItems=1&excludeQueries=1&excludeReadOnlyFolders=1&folder=" +
        PlacesUIUtils.allBookmarksFolderId;
      this._folderTree.place = FOLDER_TREE_PLACE_URI;

      this._element("chooseFolderSeparator").hidden =
        this._element("chooseFolderMenuItem").hidden = true;
-      var currentFolder = this._getFolderIdFromMenuList();
      this._folderTree.selectItems([currentFolder]);
      this._folderTree.focus();
    }
  },

Comment 4

[Leman Bennett [Omega]]

I can reproduce this as well, however it lands in "Unsorted Bookmarks" and sometimes is a duplicate.

Comment 5

[(mostly gone) XtC4UaLL [:xtc4uall]]

Mak, could the fix for Bug 324430, what is within the range mentioned in comment 2, have caused this?

Comment 6

[Marco Bonardo [:mak]]

(In reply to comment #5)
> Mak, could the fix for Bug 324430, what is within the range mentioned in
> comment 2, have caused this?

it's possible as a side effect of killing the result root and refreshing it. but also Bug 415791 involves focusing elements in popups, the star panel is a popup.

confirming for now, it needs some debug.

Comment 7

[Alice0775 White]

The following procedures are destroyed by this bug.
http://support.mozilla.com/en-US/kb/How+to+find+which+folder+a+bookmark+is+in?bl=n&s=locate%20bookmark#Find_the_bookmark_s_folder

Should fix asap.