531302 - Expand the folder tree always move bookmark to my recently selected folder

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[yuoo2k]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b4) Gecko/20091124 Firefox/3.6b4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b4) Gecko/20091124 Firefox/3.6b4

In Bookmarks Panel, if I click the folder tree's expander button, the bookmark will be moved to my recently selected folder.

Reproducible: Always

Steps to Reproduce:
1. Open Firefox 3.6b4 with a new profile,
2. Press [Ctrl-D] and click [Done] to bookmark current page to "Bookmarks Menu" folder.
3. Press [Ctrl-D], and click the folder tree's expander button.
4. When folder tree is expanded, choose the "Bookmarks Toolbar" folder.
5. Click [Cancel] button.
6. Press [Ctrl-D], and click the folder tree's expander button.

Actual Results:  
The bookmark is moved to "Bookmarks Toolbar" (My recently selected folder).

Expected Results:  
The bookmark should stay in "Bookmarks Menu".

I can't reproduce this bug in Firefox 3.5.
It happens only in Firefox 3.6 beta and latest 3.7 trunk.

Comment 1

[yuoo2k]

I can still reproduce this bug on Firefox 3.6rc1.

Comment 2

[Marco Bonardo [:mak]]

have you already tried safe-mode? http://support.mozilla.com/kb/Safe+Mode

could be due to an add-on

Comment 3

[yuoo2k]

See step 1, I use a new profile, there is no add-ons installed.
I've just tried, this bug still can be reproduced in safe-mode.

Comment 4

[Michael Kraft [:morac]]

I can reproduce this in Firefox 3.6 and the nightly Minefield trunk, but not Firefox 3.5 so it does appear to be a regression, albeit a very minor one.

I'm not sure when this changed, but I did noticed that if I performed the steps in comment 0 in the 20091226 Trunk branch load, Firefox would always crash right after step 5.  That crash no longer occurs in the latest trunk load, but the regression might have been a result of fixing the crash.

Comment 6

[Alice0775 White]

Acording to Bug 536024 Comment #2,

Regression window:
Works fine:
http://hg.mozilla.org/mozilla-central/rev/eac99a38d8d9
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2a1pre) Gecko/20090615
Namoroka/3.6a1pre ID:20090615044733

Broken:
http://hg.mozilla.org/mozilla-central/rev/ca8799e74642
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2a1pre) Gecko/20090616
Namoroka/3.6a1pre ID:20090616042639

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=eac99a38d8d9&tochange=ca8799e74642

Comment 7

[Michael Kraft [:morac]]

I'm not at all familiar with this code area, but bug 415791 looks promising.  That or maybe bug 324430.

Comment 8

[ptuna]

(In reply to comment #4)
> I can reproduce this in Firefox 3.6 and the nightly Minefield trunk, but not
> Firefox 3.5 so it does appear to be a regression, albeit a very minor one.

I wouldn't call this "minor" since bookmark organization is pretty important. This bug could screw up that organization alot.

Comment 9

[Michael Kraft [:morac]]

It's minor in the sense that it doesn't cause a crash, it's easy to avoid/work around and it only happens when performing a convoluted set of steps.  The bookmark doesn't actually move unless you click "Done" after step 6 in comment 0.

Comment 10

[Alice0775 White]

Here, workaround:
bug531302.xpi :: Add-ons for Firefox
https://addons.mozilla.org/en-US/firefox/addon/78908/

Comment 11

[Irop]

(In reply to comment #10)
> Here, workaround:
> bug531302.xpi :: Add-ons for Firefox
> https://addons.mozilla.org/en-US/firefox/addon/78908/

thanks!!!! for the solution

Comment 12

[Alice0775 White]

The patch in bug 553334 should fix these bugs on trunk too. 
I confirmed on Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre) Gecko/20100604 Minefield/3.7a5pre ID:20100604140232

Comment 13

[yuoo2k]

(In reply to comment #12)
> The patch in bug 553334 should fix these bugs on trunk too. 

Confirmed the patch fix this bug on trunk, 
but it seems not work on 3.6 branch.

Is there any chance to fix this bug on 3.6 branch?

Comment 14

[Marco Bonardo [:mak]]

Does still happen in current trunk nightly build?

Comment 15

[Alice0775 White]

(In reply to comment #14)
> Does still happen in current trunk nightly build?

I can not reproduce the problem on latest m-c nightly .
Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100620 Minefield/3.7a6pre ID:20100620053841

Comment 16

[Marco Bonardo [:mak]]

cool, thanks.