Closed Bug 536678 Opened 11 years ago Closed 11 years ago

Comm-central contains a MoreFilesX dependency, but is obsolete on Gecko1.9.2 and later

Categories

(MailNews Core :: Build Config, defect)

All
macOS
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.1b1

People

(Reporter: Nomis101, Assigned: Nomis101)

References

Details

Attachments

(2 files)

Bug 476230 (and Bug 464362) removed the MoreFilesX usage in 1.9.2a1 and later. Therefore the configure.in from mozilla-1.9.2 and mozilla-central doesn't contain a MoreFilesX dependency anymore.

In the configure.in from comm-central you still find
># set MACOSX to generate lib/mac/MoreFiles/Makefile
> MACOSX=1
But this is not needed anymore in comm-central, because we have comm-1.9.1 for TB3.0. And TB3.1/3.next will be build from 1.9.2 and later.
The MoreFilesX dependency was removed from mozilla-centrals configure.in in Bug 456662 (fix v1.3). I also found two other unused residues that were removed from configure.in in Bug 514787, but I'm not sure if we can remove this also in comm-central. So my patch will only remove the MoreFilesX dependency.
Blocks: C192ConfSync
Did you miss to request review on your patch?
Assignee: nobody → Nomis101
Severity: normal → trivial
Status: NEW → ASSIGNED
Flags: in-testsuite-
Product: Thunderbird → MailNews Core
QA Contact: build-config → build-config
Oh, yes. I didn't set the review flag yet, because I was not sure who is an appropriate reviewer for this. If I look at the configure.in contributors, it seems to me you or kairo would be a good choice, right?
Comment on attachment 419359 [details] [diff] [review]
Remove MoreFilesX dependency from comm-centrals configure.in (Gecko1.9.2 and later)

Serge isn't a reviewer, but KaiRo is, though KaiRo doesn't have a Mac. As I'm a possible reviewer as well, I'll try and get to this early next week.
Attachment #419359 - Flags: review?(bugzilla)
Ah OK, thanks :-)
I don't actually know what the MoreFilesX dependency is.  Not sure whether it's high-enough leverage that it really rises to the level of wanted+, but I'll let Standard8 make that call.  I suspect if this is wanted, it's not a 3.1-specific thing, so hoisting to wanted-thunderbird?  In general, though, cleanup patches are a fine fine thing, and I hope we get this sooner rather than later!
Flags: wanted-thunderbird?
Attachment #419359 - Flags: review?(bugzilla) → review+
Keywords: checkin-needed
Pushed as http://hg.mozilla.org/comm-central/rev/14b5b34b6449
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Attachment #419359 - Flags: review?(ted.mielczarek)
Comment on attachment 419359 [details] [diff] [review]
Remove MoreFilesX dependency from comm-centrals configure.in (Gecko1.9.2 and later)

ted, this was missed in js/ it seems, from whatever patch got it in m-c/configure.in  asking r+ to sync them (if you'd rather a seperate bug, no problem)
Attachment #426709 - Flags: review? → review?(jorendorff)
Comment on attachment 419359 [details] [diff] [review]
Remove MoreFilesX dependency from comm-centrals configure.in (Gecko1.9.2 and later)


Ah, I was just checking the same thing at the same time ;-)
Attachment #419359 - Flags: review?(ted.mielczarek)
Target Milestone: --- → Thunderbird 3.1b1
Fwiw, I wonder if
{
http://mxr.mozilla.org/comm-central/search?string=MoreFiles&case=on&find=%2FnsImportEncodeScan%5C.cpp%24

/mailnews/import/src/nsImportEncodeScan.cpp
    * line 54 -- #include "MoreFilesExtras.h"
}
would be related and could be removed too?
Comment on attachment 426709 [details] [diff] [review]
(Bv1) Remove /js/src/configure.in leftover too
[Checkin: Comment 14]

For reference the m-c checkin which removed this was: http://hg.mozilla.org/mozilla-central/rev/71f2a7fd2098 of Bug 487045
Depends on: 487045
Comment on attachment 426709 [details] [diff] [review]
(Bv1) Remove /js/src/configure.in leftover too
[Checkin: Comment 14]

Thanks.
Attachment #426709 - Flags: review?(jorendorff) → review+
Comment on attachment 426709 [details] [diff] [review]
(Bv1) Remove /js/src/configure.in leftover too
[Checkin: Comment 14]


http://hg.mozilla.org/mozilla-central/rev/501e5a425861
Attachment #426709 - Attachment description: (Bv1) Remove /js/src/configure.in leftover too → (Bv1) Remove /js/src/configure.in leftover too [Checkin: Comment 14]
(In reply to comment #11)
>     * line 54 -- #include "MoreFilesExtras.h"

I filed bug 547930.
Flags: wanted-thunderbird?
You need to log in before you can comment on or make changes to this bug.