Open Bug 537343 Opened 11 years ago Updated 4 years ago

Need new entities for proper Mac menu items localization in all the supported locales

Categories

(SeaMonkey :: OS Integration, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

People

(Reporter: xfox.mozilla, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9.1.8pre) Gecko/20091229 SeaMonkey/2.0.2pre
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9.1.8pre) Gecko/20091229 SeaMonkey/2.0.2pre

On the Macintosh platform some locales should use different menu names for some menu items compared to the Windows and *nix platforms. For example, on Mac the "File" menu should be named "Archivio" in the Italian locale and "Ablage" in the German one but on Windows and *nix it should be "File" in the Italian locale and "Datei" in the German one. It could even happen that a menu item should be named the same on Mac/Windows/*unix in some locales and differently in some other locales.
Thus, we need a new Mac-specific entity for all (and only) the menu items that need to be translated differently for some supported locales.
I'll try to write down a list of all these menu items but since I only know Italian and English (and I make mistakes), please correct me if you think I wrote something wrong and drop a note if you are aware of some missing menu items. I took the localization of some system applications on Mac OS X 10.5.8 (Safari, TextEdit, Finder, Mail, etc.) and comments from bug 268785, bug 266663 and bug 266678 as a reference.
AFAIK, the new entity should be created at least for these menu items (between parenthesis the example case):

*§* Browser window menu bar *§*
• File (in the 'it' locale, it should be "Archivio" on Mac and "File" on Windows/*nix)
• File -> Save Page As… (in the 'it' locale, it should be "Registra pagina col nome…" on Mac and "Salva pagina con nome…" on Windows/*nix)
• File -> Save Frame As… (in the 'it' locale, it should be "Registra riquadro col nome…" on Mac and "Salva riquadro con nome…" on Windows/*nix)
• File -> Page Setup… (in the 'it' locale, it should be "Formato di stampa…" on Mac and "Imposta pagina…" on Windows/*nix)
• Edit (in the 'it' locale, it should be "Composizione" on Mac and "Modifica" on Windows/*nix)
• Edit -> Undo (in the 'de' locale, it should be "Widerrufen" on Mac and "Rückgängig" on Windows/*nix)
• Edit -> Redo (in the 'it' locale, it should be "Ripristina originale" on Mac and "Ripeti" on Windows/*nix)
• Edit -> Paste (in the 'de' locale, it should be "Einsetzen" on Mac and "Einfügen" on Windows/*nix)
• Edit -> Find in This Page… (in the 'it' locale, it should be "Cerca in questa pagina…" on Mac and "Trova in questa pagina…" on Windows/*nix)
• Edit -> Find Again (in the 'de' locale, it should be "Weitersuchen (vorwärts)" on Mac and "Weitersuchen" on Windows/*nix)
• Edit -> Find Previous (in the 'de' locale, it should be "Weitersuchen (rückwärts)" on Mac and "Vorheriges suchen" on Windows/*nix)
• View (in the 'it' locale, it should be "Vista" on Mac and "Visualizza" on Windows/*nix)
• Window (in the 'it' locale, it should be "Finestra" on Mac and "Finestre" on Windows/*nix)
• Window -> Minimize (in the 'it' locale, it should be "Contrai" on Mac and "Minimizza" on Windows/*nix)
• Help (in the 'it' locale, it should be "Aiuto" on Mac and "Guida" on Windows/*nix)
• Help -> SeaMonkey Help (in the 'it' locale, it should be "Aiuto SeaMonkey" on Mac and "Guida di SeaMonkey" on Windows/*nix)

*§* Mail & Newsgroups window menu bar *§* (I won't repeat common menu items here)
• File -> Save As (in the 'it' locale, it should be "Registra come" on Mac and "Salva come" on Windows/*nix)
• Edit -> Find in This Message… (in the 'it' locale, it should be "Cerca nel messaggio…" on Mac and "Trova nel messaggio…" on Windows/*nix)


Reproducible: Always
Version: unspecified → SeaMonkey 2.0 Branch
We can't do this on 2.0.x, but we can do it for 2.1. Hmm, it was more than I expected.

I think I found 2 that already exists as separate entities:
"Help -> SeaMonkey Help" and "File -> Page Setup" (http://mxr.mozilla.org/comm-central/source/suite/locales/en-US/chrome/common/mac/platformCommunicatorOverlay.dtd)
Assignee: nobody → stefanh
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: SeaMonkey 2.0 Branch → Trunk
Stefan, in the file you linked I also see "Edit -> Redo" and "Window -> Minimize".
OK, so we have:

Menus: 
• File (it)
• Edit (it)
• View (it)
• Window (it)
• Help (it)

Menuitems:
• File -> Save As (it)
• File -> Save Page As… (it)
• File -> Save Frame As… (it)
• Edit -> Undo (de)
• Edit -> Paste (de)
• Edit -> Find in This Message… (it)
• Edit -> Find in This Page… (it)
• Edit -> Find Again (de)
• Edit -> Find Previous (de) 

MMx: can you confirm the German part?
de would be: (OS X 10.5.8 apps as reference, no 10.6 installed yet)

Menus:
· File  Ablage
· View  Darstellung

Menuitems:
· general: Space before the ellipsis (e.g. "Save As …"
· Save As…   Sichern unter … (not "Speichern unter…")
· Undo, Paste: as in previous comments, same for find stuff
Blocks: 4252
For these ones:
• Edit -> Find in This Message… (it)
• Edit -> Find in This Page… (it)
• Edit -> Find Again (de)
• Edit -> Find Previous (de)

What does the find box display (title and so on)? If we change the menuitem labels, will the labels then still match the strings in the find box?
In the original post I forgot two additional menuitems that need a new entity for proper Italian Mac localization:

• Edit -> Find Links As You Type
• Edit -> Find Text As You Type

(In reply to comment #5)
> For these ones:
> • Edit -> Find in This Message… (it)
> • Edit -> Find in This Page… (it)
> • Edit -> Find Again (de)
> • Edit -> Find Previous (de)
> 
> What does the find box display (title and so on)? If we change the menuitem
> labels, will the labels then still match the strings in the find box?

No, they would not match.
If we change those menuitem labels we should also be able to change the find box title "Find in This Page" and strings "Find what:" and "Find Next".
By the way, since probably you will be already working on the find box(es), you might have a look at the somewhat related bug 74620 and come up with a combo fix! :)
I would say that the menus are quite straight-forward, apart from the window menu which doesn't seem to be possible to do without an ifdef. Then I think we can do undo and paste in the edit menu quite easily.

• File (it) - ok
• Edit (it) - ok
• View (it) - ok
• Window (it) - ?
• Help (it) - ok

Menuitems:
• Edit -> Undo (de) - ok
• Edit -> Paste (de) - ok
OK, it turns out that the window menu can be done quite simple, I think
I've been looking at this, and I think we might be able to do the menu labels. Menuitem labels will require a lot of work, though.

I do see sa problem here, though: I don't think we'll be able to control what extensions do. For example, when opening chatzilla (which is an extension), the file, edit, view and help menus will have their labels from the cz localization. I'm not sure if this will look so good. Thoughts?
Attached patch demo patch (obsolete) — Splinter Review
Just putting a demo patch here (entity names prefixed, will obviously need to be changed)
Attached patch Updated patchSplinter Review
Oops, had some other changes in there (now removed).
Attachment #518511 - Attachment is obsolete: true
Whiteboard: [good first bug][mentor=Stefanh][lang=xul,dtd]
Sorry for the bugspam guys, but Stefanh say this isn't a good first bug, too complicated.
Whiteboard: [good first bug][mentor=Stefanh][lang=xul,dtd]
(In reply to Stefan [:stefanh] from comment #9)
> I do see sa problem here, though: I don't think we'll be able to control
> what extensions do. For example, when opening chatzilla (which is an
> extension), the file, edit, view and help menus will have their labels from
> the cz localization. I'm not sure if this will look so good. Thoughts?

Yes, it will not look so good to have menu items named differently in the main application windows and in the extensions windows but I think it's up to extensions makers to update their projects with proper platform localizations.

By the way, since my last comments, OS X 10.8 Mountain Lion has been released and the Italian translation of the File menu has been changed from "Archivio" to "File", so a separate Mac entity isn't needed anymore for the File menu, at least for Italian. I don't know if it's still needed by other localizations, though.

I'm sorry I almost disappeared soon after reporting this bug but now I have some time again to dedicate to SeaMonkey improvement and I'd really like to have this old bug squashed.
Is there something I can do?
> Is there something I can do?
I think Stefanh is the best person to ask.
Flags: needinfo?(stefanh)
Flags: needinfo?(stefanh)
Assignee: stefanh → nobody
You need to log in before you can comment on or make changes to this bug.