Closed Bug 538017 Opened 16 years ago Closed 9 years ago

[meta] Bookmarks should keep their date added as part of synced metadata

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Future

People

(Reporter: gehkacken02, Unassigned)

References

Details

(Keywords: meta)

User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.6) Gecko/20091215 Ubuntu/9.10 (karmic) Firefox/3.5.6 Build Identifier: I sync between Win7x64 and Ubuntu9.10x32 and when I add a bookmark with one machine (for example at the bottom of my "Unsorted Bookmarks" folder) and sync, the same bookmark appears in the "Unsorted Bookmarks" folder on the other pc, but somewhere in the middle of the list and NOT at the bottom. This completely **** up my bookmarking order. I cant find any of my important bookmarks in my "timeline" sorted folder. with foxmarks this never happend. go fixing! Reproducible: Always Steps to Reproduce: 1. add bookmarks 2. sync them 3. look at bookmars on another machine 4. --> the are not in the correct order Actual Results: bad ... very bad Expected Results: good, joyful if you cant figure it out, ask the foxmarks guys, i think it's called xmarks now
Have you reproduced this in other folders, too, or just the "unsorted bookmarks" folder? I'm not a Weave dev, but I wouldn't be surprised if maybe the "unsorted bookmarks" folder was treated specially. (If so, that might help narrow in on the chunk of code that needs fixing)
hmmmm ... yes, it seems to be restricted to the "unsorted bookmarks" folder. the problem is that most of my bookmarks ARE in that folder and that all the bookmarks i create by klicking on the 'star' icon are created in that folder, so though its called "unsorted bookmarks", it should at least sync the order of the unsorted bookmarks in there
Renaming as this seems to only affect unsorted bookmarks.
OS: Linux → All
Hardware: x86 → All
Summary: Bookmarks synced by one pc are displayed in an incorrect order on another pc → "Unsorted bookmarks" should keep their Added date order
It looks like it's by design: http://hg.mozilla.org/labs/weave/rev/1abab03c18ca But is it really a good idea to lose their sort order?
Status: UNCONFIRMED → NEW
Component: General → Sync
Ever confirmed: true
QA Contact: general → sync
Well, it's an "unsorted bookmarks" folder, so the idea of preserving sort order isn't exactly intuitive. The UI doesn't show "Sort by Name" or the like, as an explicit choice. Of course, the backend will return a deterministic order on a single machine, but that seems more happy accident than intended behaviour. Adding items from other machines will not automatically replicate the implementation detail here. We don't currently sync date added, but we should do that, as that's useful metadata to have for all bookmarks, and will allow people who use unsorted bookmarks like this to get the same behaviour.
Summary: "Unsorted bookmarks" should keep their Added date order → Bookmarks should keep their date added as part of synced metadata
Actually, no date is synced at all. The order is determined from the predecessor (see linked changeset). Backing out that changeset would fix this bug.
FYI, it was initially removed to prevent locking up the browser when a lot of unsorted bookmarks were added to remote machines.
I got it now. So I guess we can put it back?
Not without another solution in place to avoid those lockups... I don't think that sort order for this "folder" (which can often get into thousands of bookmarks) is worth the overhead. It seems much better to do what I just said, which is sync the date added, and users who care about the sort order can use that data. Main advantage being that it's generally useful (for all bookmarks), and isn't dependent on undefined behaviour from the Places backend remaining static. Were I looking for data to purge from the Places DB, I'd probably omit any ordering data for this folder, and order by date added in the default query.
I think "date added" it's important, even for unsorted bookmarks.
Severity: major → normal
Target Milestone: --- → Future
Blocks: 582425
soon to be birthday this bug, is there a chance that we all still get synchronized in time added?
It's something we're going to revisit at some point, but highly unlikely before Fx4
I also noticed this on Mozilla/5.0 (Windows NT 6.1; WOW64; rv:5.0a2) Gecko/20110421 Firefox/5.0a2. Fixing this seems to be not hard, not requiring changes in server code, not requiring changes in storage API, but clients need to save timestamps to encrypted payload and restore timestamps from encrypted payload. I'm ready for fixing this, but changing format of data in encrypted payload needs some approval from anyone?
https://developer.mozilla.org/En/Developer_Guide/How_to_Submit_a_Patch should answer your remaining questions if you still care after all the time. Anyway, don't hesitate to add a patch even if you don't know who to choose for the review.
(In reply to sss.sonik from comment #16) > I'm ready for fixing this, but changing format of data in encrypted payload > needs some approval from anyone? Sorry for not responding to this earlier. I'm in two minds about whether extending the bookmarks object format: http://docs.services.mozilla.com/sync/objectformats.html requires a version bump. If we don't care about older clients uploading records without it, and in fact discarding the data whenever they change a record, then we're probably OK moving forward. I'll have a think about this. Patch certainly welcome, though it might not land until there's another rev of the bookmarks engine.
rnewman: do you have any recent thoughts on this?
Not much to add to Comment 18. I think we should make a little list of things that we want to change with engines in the Flag Day Protocol Change: * Date added for bookmarks * URL histories in tabs * Better representation of visits in history * Non-sucky prefs sync? * More info in clients * Add a salt engine…? If we have to do a big protocol switchover, it makes sense to fix it all now…
Is "Flag Day Protocol Change" 2.0 or 2.next? Will 2.next be backward compatible with 2.0, or will we go through this giant migration mess again?
(In reply to Gregory Szorc [:gps] from comment #21) > Is "Flag Day Protocol Change" 2.0 or 2.next? Will 2.next be backward > compatible with 2.0, or will we go through this giant migration mess again? Any protocol change that locks out old clients is suitable. 2.0 is definitely that. I don't know if 2.0->2.next will lock out old clients. Toby?
2.next will by definition be compatible with 2.0. The goal is obviously to be compatible for as long as humanly possible so as to avoid migration messes.
(In reply to Toby Elliott [:telliott] from comment #23) > 2.next will by definition be compatible with 2.0. The goal is obviously to > be compatible for as long as humanly possible so as to avoid migration > messes. Then we should try to get all of these little storage protocol improvements done by 2.0, too…
I'm affected by this. Firefox 57 beta. Not only they appear with the same date in random order, also it seems I'm missing a bunch.
I've also lost the order in bookmarks up to mid 2015, but I didn't realize back then because the sync'd machine wasn't used seriously. Except that I used it as profile backup when the HDD of my main machine crashed.
Desktop syncs date added as of Firefox 55: Bug 676563. Android syncs date added as of Firefox 55: Bug 1335198. iOS will do so as of Firefox for iOS v10: Bug 1335201.
Status: NEW → RESOLVED
Closed: 9 years ago
Component: Firefox Sync: Backend → Firefox Sync: Cross-client
Depends on: 1335201, 1335198, 676563
Keywords: meta
Resolution: --- → FIXED
Summary: Bookmarks should keep their date added as part of synced metadata → [meta] Bookmarks should keep their date added as part of synced metadata
(In reply to kungfoobar from comment #25) > I'm affected by this. Firefox 57 beta. Not only they appear with the same > date in random order, also it seems I'm missing a bunch. You are probably affected by another bug, or have existing bad data on your sync server. The simplest thing to do is turn off bookmark sync, make sure your bookmarks are good on a single machine, then turn it back on on that machine.
Component: Firefox Sync: Cross-client → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.