Closed Bug 538568 Opened 10 years ago Closed 10 years ago
.0 can't handle autoconfig files with days To Leave Messages On Server elements .
First mentioned in bug 536546. The attached patch (written against comm-1.9.1, but applies cleanly to comm-central) fixes that, and includes a test. Without the fix, the test fails with: TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | can't copy objects of type xml yet With the fix, the test passes. Since we have an ISP who would like to use these, and since it's a minor change, and since it comes with a unit test, I would like to get the patch in to 3.0.1, if possible. Thanks, Blake.
r=davida for what it's worth. The failure mode is clear, the patch is simple, and there's a test. It'd be good to get in 3.0.1 if bienvenu & std8 agree that it's a simple fix.
the patch looks fine, but the test fails for me: TEST-INFO | (xpcshell/head.js) | test 1 pending TEST-INFO | (xpcshell/head.js) | test 2 pending TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | ReferenceError: test_readFromXML is not defined before 1007616, after 950272, break 00000000 this is on the trunk...I can try it against 3.01
maybe the line should read test_copying_readFromXML instead of test_readFromXML - I'll try that.
hmm, if I change that, the tests don't fail, but they do give this status: TEST-INFO | (xpcshell/head.js) | test 1 pending TEST-INFO | (xpcshell/head.js) | test 2 pending TEST-INFO | (xpcshell/head.js) | test 2 finished TEST-INFO | (xpcshell/head.js) | test 1 finished TEST-INFO | (xpcshell/head.js) | exiting test before 209232, after 151552, break 00000000 TEST-INFO | (xpcshell/head.js) | No (+ 0) checks actually run
Comment on attachment 420716 [details] [diff] [review] A patch to sanitize the daysToLeaveMessagesOnServer and downloadOnBiff settings. ok, r=me, if you change + test_readFromXML(); to test_copying_readFromXML(); running check-one, it says 1 passed; not sure what was going on with check-interactive.
Attachment #420716 - Flags: review?(bienvenu) → review+
Thanks for the review. I've fixed the function name in the test, so here's the new patch. Later, Blake.
Whiteboard: [patch up, needs r bienvenu, sr standard8] → [patch up, needs sr standard8]
Comment on attachment 420850 [details] [diff] [review] A better patch to sanitize the daysToLeaveMessagesOnServer and downloadOnBiff settings. sr+a=Standard8
Landed on trunk as <http://hg.mozilla.org/comm-central/rev/099eebc99f61> and 1.9.1 as <http://hg.mozilla.org/releases/comm-1.9.1/rev/12fa57a908f7>.
You need to log in before you can comment on or make changes to this bug.