Some animated gifs are not displayed properly

VERIFIED DUPLICATE of bug 513749

Status

()

Core
ImageLib
VERIFIED DUPLICATE of bug 513749
8 years ago
2 years ago

People

(Reporter: racoon, Unassigned)

Tracking

({relnote})

1.9.2 Branch
mozilla1.9.2
x86
Windows XP
relnote
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [3.6.x])

(Reporter)

Description

8 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.2) Gecko/20100105 Firefox/3.6 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.2) Gecko/20100105 Firefox/3.6 (.NET CLR 3.5.30729)

Since I use Firefox 3.6, some animated gifs appear corrupt. Using 3.5 or older version of Firefox, they are displayed properly.

Reproducible: Always

Steps to Reproduce:
1. go to http://s15.rimg.info/62669e6b118c5f4314ea2a9d9663b036.gif
2.
3.

Comment 1

8 years ago
Broken in:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2) Gecko/20100105 Firefox/3.6

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20090902 Minefield/3.7a1pre


Works in:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20090903 Minefield/3.7a1pre

Comment 2

8 years ago
mozilla-central was fixed in http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=75af94f85a98&tochange=3cab7a0c2c3d

makes me thing it might be the patch from bug 511689, can't see anything else in that range that could have fixed this in mozilla-central.
Reporter, can you please install firefox 3.7 and see if the gif works? ftp://ftp.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
Version: unspecified → 3.6 Branch
(Reporter)

Comment 4

8 years ago
Yes, it works and all other gifs I know.
OK, well, maybe bug 511689.

Comment 6

8 years ago
This problem has been reported today in the Italian support forum by a user. It happens the same with this image:

http://www.startrekitalia.com/publicnew/avatars/dracon.gif

Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9.2) Gecko/20100105 Firefox/3.6

but it doesn't happen with 

Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9.3a1pre) Gecko/20100116 Minefield/3.7a1pre

Updated

8 years ago
Duplicate of this bug: 540266

Comment 8

8 years ago
both this image and from Bug 540266 are confirmed not to work in 3.6, but they do work in 3.5.7 or on trunk (3.7a1pre)
Status: UNCONFIRMED → NEW
Ever confirmed: true
By using Mozilla/5.0 (Windows; U; Windows NT 6.0; it; rv:1.9.2) Gecko/20100115 Firefox/3.6 I can display correctly the animated gif http://www.startrekitalia.com/publicnew/avatars/dracon.gif
cc-ing joedrew and asking blocking, probably too late, but i prefer drivers being aware of the problem since it only affects 3.6.
we could at least relnote.
Flags: blocking-firefox3.6?
Do we have something for the release note? Some animated GIF files do not render properly? Do we know what the common denominator is, here?

Definitely want to fix it in a stability update.

--> Core::ImgLib, cc'ing jeff and joe for digging into
Component: General → ImageLib
Flags: blocking-firefox3.6?
Keywords: relnote
Product: Firefox → Core
QA Contact: general → imagelib
Whiteboard: [3.6.x]
Target Milestone: --- → mozilla1.9.2
Version: 3.6 Branch → 1.9.2 Branch
One common denominator is that both of the gif images were produced with GIF Movie Gear
It would be great if someone could find a regression range for the change that introduced this problem.
Keywords: regressionwindow-wanted
Another thing that these images have in common is that they only update a small region of the image in subsequent frames. If I had to guess it might be that we are not using the transparent color from the subsequent frames properly.

Comment 15

8 years ago
Either:
 Bug 514776 -  GIF with out-of-bounds colormap reference causes OOB read in nsGIFDecoder2::OutputRow
or:
 Bug 511689 -  (CVE-2009-3373) GIF Color Map Parsing Buffer Overflow Vulnerability -- iDefense [V-jb9pzo6q1s]
Both are submitted to 1.9.1/1.9.0 but not to central?
(In reply to comment #15)
> Both are submitted to 1.9.1/1.9.0 but not to central?

the problems is not central, the problem is 1.9.2. But both of those bugs contain a push-to-1.9.2 comment.

Comment 17

8 years ago
Or possibly in the imgContainer department:
Bug 513749 -  Mismerge causes issues in animated images

Comment 18

8 years ago
Works:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090720 Minefield/3.6a1pre

Broken:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090721 Minefield/3.6a1pre

Regression range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=247524e19d0c&tochange=f2a58ffcd00c

Comment 19

8 years ago
Bug 753 is then the suspect, there is an additional patch that is possibly not checked in...

Updated

8 years ago
Duplicate of this bug: 541279

Updated

8 years ago
Duplicate of this bug: 541388
Bug 513749 never landed on 1.9.2 so I'd it's a likely candidate. I'm trying it out now.
Applying the patch from 513749 fixes the problem for me. People can try out the build at https://build.mozilla.org/tryserver-builds/jmuizelaar@mozilla.com-try-a91718bc0bc8/
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 513749
(Reporter)

Comment 24

8 years ago
(In reply to comment #23)
> Applying the patch from 513749 fixes the problem for me. People can try out the
> build at
> https://build.mozilla.org/tryserver-builds/jmuizelaar@mozilla.com-try-a91718bc0bc8/

I tested it and it looks good for me

Comment 25

8 years ago
Same here: https://build.mozilla.org/tryserver-builds/jmuizelaar@mozilla.com-try-a91718bc0bc8/ fixes the problem.

Comment 26

8 years ago
(In reply to comment #23)
> Applying the patch from 513749 fixes the problem for me. People can try out the
> build at
> https://build.mozilla.org/tryserver-builds/jmuizelaar@mozilla.com-try-a91718bc0bc8/
> 
> *** This bug has been marked as a duplicate of bug 513749 ***

I can confirm this fix works, for linux, and for this .gif:
http://www.moparisthebest.com/smf/Themes/core/images/pikastaff.gif

I am also having this problem with Firefox 3.6 on Windows 7, Linux, and Mac OSX Tiger and Leopard.

The offending .gif can be found here:
http://www.moparisthebest.com/smf/Themes/core/images/pikastaff.gif

How long can we expect to wait before this makes it into an official update?

Updated

8 years ago
Duplicate of this bug: 543341

Comment 28

8 years ago
when will mozilla lauches an official patch or another version? I'will use another browser
3.6.2 will have this fix, which should be released around March 30th. (there is no 3.6.1)
Keywords: regressionwindow-wanted

Updated

2 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.