Closed Bug 540380 Opened 12 years ago Closed 12 years ago

Add mozsqlite3.dll to comm-central file in use checks

Categories

(Thunderbird :: Installer, defect)

x86
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.1b2

People

(Reporter: philor, Assigned: philor)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Fix for Tb, SM, Sb (obsolete) — Splinter Review
Can't do it until we branch for 1.9.2, since there's no preprocessing, but right now we're checking whether sqlite3.dll is in use when the file that's possibly in use for 1.9.3 is mozsqlite3.dll.
Attachment #422176 - Flags: review?(bugzilla)
No longer blocks: 540379
Depends on: 540379
Whiteboard: [needs branch] → [needs c-1.9.2 branch]
Serge: please keep your hands off my bugs.
Blocks: 540379
No longer depends on: 540379
Whiteboard: [needs c-1.9.2 branch] → [needs branch]
Comment on attachment 422176 [details] [diff] [review]
Fix for Tb, SM, Sb

Philor, r+ on the suite part.

If its decided suite won't do a rel off 1.9.2 that part can land before we are branched, but I don't see a rush for it to land either.
Attachment #422176 - Flags: review+
(In reply to comment #2)
> If it's decided suite won't do a rel off 1.9.2 that part can land

Phil, could you do that. Thanks.
Depends on: NoC192SM
Flags: in-testsuite-
(In reply to comment #0)
> Created an attachment (id=422176) [details]
> Fix for Tb, SM, Sb
> 
> Can't do it until we branch for 1.9.2, since there's no preprocessing, but
> right now we're checking whether sqlite3.dll is in use when the file that's
> possibly in use for 1.9.3 is mozsqlite3.dll.

Does it matter if we do check both even if we're not using/installing one?
(In reply to comment #4)
>..
> Does it matter if we do check both even if we're not using/installing one?
It doesn't matter and is safe
btw: you can remove xpicleanup.exe... it hasn't existed for a while and I left it since it just in case since it had caused a lot of headaches due to being in use and because it is safe when the file doesn't exist
Attachment #422176 - Flags: review?(bugzilla)
Attachment #422176 - Flags: review+
Comment on attachment 422176 [details] [diff] [review]
Fix for Tb, SM, Sb

Cancelling reviews based on previous comments, let's just go the route of checking both for Thunderbird and adding a comment to remove one when we stop supporting 1.9.2
Based on my (possibly flawed) understanding of a brief conversation with rs, I think this is actually what we want to do. We only want to remove things from the list when we're ready to laugh at the troubles of anyone upgrading from the last version that used something, which given our removed-files.in means never, and the cost is (very roughly speaking) equivalent to all the checks in removed-files.in for things that we're pretty darn sure 99% of the users aren't going to have anyway. Continuing to check for sqlite3.dll and xpicleanup.exe until nobody can even remember what they were isn't going to hurt a thing.
Attachment #438417 - Flags: review?(bugzilla)
Attachment #422176 - Attachment is obsolete: true
Attachment #438417 - Flags: review?(bugzilla) → review+
http://hg.mozilla.org/comm-central/rev/f19d129cfef8
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
No longer depends on: C192Branch, NoC192SM
Resolution: --- → FIXED
Summary: Switch comm-central file in use checks to mozsqlite3.dll → Add mozsqlite3.dll to comm-central file in use checks
Whiteboard: [needs branch]
Target Milestone: Thunderbird 3.2a1 → Thunderbird 3.1b2
You need to log in before you can comment on or make changes to this bug.