540629 - Use superior autohiding menubar in full screen mode?

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, enhancement)

Description

[[e-mail]]

Currently we just blindly hide the menubar in full screen mode, which makes the menus inaccessible. We should autohide it instead.

Comment 1

[[e-mail]]

Attachment: Proposed patch

I had to use the autohide attribute because the toolkit binding uses it to check whether it is still applicable, but I simplified the CSS rules since we always want to autohide the menubar in full screen mode even if it has been customised.

Comment 2

[Philip Chee]

> +#toolbar-menubar[autohide="true"]
No grippy in Full screen mode? I guess that makes sense.

Comment 3

[Ian Neal]

(In reply to comment #1)
> Created an attachment (id=422343) [details]
> Proposed patch
> 
> I had to use the autohide attribute because the toolkit binding uses it to
> check whether it is still applicable, but I simplified the CSS rules since we
> always want to autohide the menubar in full screen mode even if it has been
> customised.
I cannot spot any difference when testing this on linux, would be expected to see any?

Comment 4

[[e-mail]]

Whoops, it would help if I explained what autohide was, but maybe it would be easier just to demonstrate: just press (say) Alt+V in full screen mode.

Comment 5

[[e-mail]]

Pushed changeset 3d183cb5d855 to comm-central.

Comment 6

[[e-mail]]

Whoops, forgot to resolve this as fixed.