Closed
Bug 541668
Opened 14 years ago
Closed 14 years ago
blocks in rowspanning cells don't receive events (display:block links unclickable) when no table parts have border or background
Categories
(Core :: Layout: Tables, defect, P2)
Tracking
()
VERIFIED
FIXED
mozilla1.9.3a1
People
(Reporter: karl156, Assigned: dbaron)
References
Details
(Keywords: regression, testcase, verified1.9.2)
Attachments
(2 files)
1.04 KB,
text/html
|
Details | |
3.53 KB,
patch
|
roc
:
review+
beltzner
:
approval1.9.2.2+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.2) Gecko/20100115 Firefox/3.6 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.2) Gecko/20100115 Firefox/3.6 I noticed a problem that some links are not clickable in Firefox 3.6. I have traced the problem to a simple example. See attachment. Reproducible: Always
Comment 2•14 years ago
|
||
Confirmed with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20100122 Minefield/3.7a1pre This regressed in the second half of 2009.
Component: General → Layout
Keywords: regression,
regressionwindow-wanted
Product: Firefox → Core
QA Contact: general → layout
Version: 3.6 Branch → 1.9.2 Branch
Updated•14 years ago
|
Comment 3•14 years ago
|
||
Regression window for trunk 1.9.3: works: http://hg.mozilla.org/mozilla-central/rev/d379a17cbf8f Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091212 Minefield/3.7a1pre ID:20091212045454 broken: http://hg.mozilla.org/mozilla-central/rev/3ff17b03644e Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091213 Minefield/3.7a1pre ID:20091213045416 pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d379a17cbf8f&tochange=3ff17b03644e Regression window for branch 1.9.2: works: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/101b2f5eef9a Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b6pre) Gecko/20091212 Namoroka/3.6b6pre ID:20091212045310 broken: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/5e9329cfac70 Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b6pre) Gecko/20091213 Namoroka/3.6b6pre ID:20091213052138 pushlog: http://hg.mozilla.org/releases/mozilla-1.9.2/pushloghtml?fromchange=101b2f5eef9a&tochange=5e9329cfac70
Assignee | ||
Updated•14 years ago
|
Summary: Firefox 3.6 Regression → display:block links in rowspanning cells sometimes unclickable in rowspanning parts
Assignee | ||
Comment 4•14 years ago
|
||
Pretty clearly a regression from bug 530686 based on the testcase (particularly that giving other cells a background color fixes it), but it's not clear to me *why*; I suspect there's some other underlying bug not related to that patch.
Blocks: 530686
Assignee | ||
Comment 5•14 years ago
|
||
Actually, no... I think it is the fault of that patch. In particular, the change there means |item| is null, which means sortEventBackgrounds in nsTableFrame::DisplayGenericTablePart becomes false rather than true.
Assignee | ||
Updated•14 years ago
|
blocking1.9.2: --- → ?
Component: Layout → Layout: Tables
OS: Windows XP → All
QA Contact: layout → layout.tables
Hardware: x86 → All
I think the new title "display:block links in rowspanning cells sometimes unclickable in rowspanning parts" is wrong. I noticed the problem first with an inner table with onclick events on some td elements. That means there were no a tags at all.
blocking1.9.2: ? → ---
Component: Layout: Tables → Layout
OS: All → Windows XP
Hardware: All → x86
Assignee | ||
Updated•14 years ago
|
blocking1.9.2: --- → ?
Component: Layout → Layout: Tables
OS: Windows XP → All
Hardware: x86 → All
Summary: display:block links in rowspanning cells sometimes unclickable in rowspanning parts → blocks in rowspanning cells don't receive events (display:block links unclickable) when no table parts have border or background
Assignee | ||
Updated•14 years ago
|
Assignee | ||
Comment 7•14 years ago
|
||
Attachment #423157 -
Flags: review?(roc)
Comment on attachment 423157 [details] [diff] [review] patch The testcase could be simpler by just using elementFromPoint, but it doesn't matter. Thanks!
Attachment #423157 -
Flags: review?(roc) → review+
Attachment #423157 -
Flags: approval1.9.2.1?
Assignee | ||
Comment 9•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/dbb25266f4fa
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Assignee | ||
Comment 10•14 years ago
|
||
Thanks for reporting this. It's now fixed on mozilla-central (1.9.3) nightlies (starting with tomorrow's), and hopefully we'll get it into the 1.9.2 branch for 1.9.2.1 (and thus Firefox 3.6.1).
Flags: in-testsuite+
Updated•14 years ago
|
blocking1.9.2: ? → needed
Assignee | ||
Comment 13•14 years ago
|
||
This fixes a pretty bad regression in 3.6 from some last-minute changes, and we really shouldn't ship a major update to 3.6 without this patch; I think this would have been a clear release blocker if we'd seen it before the release.
Updated•14 years ago
|
status1.9.2:
--- → ?
Updated•14 years ago
|
Comment 16•14 years ago
|
||
Comment on attachment 423157 [details] [diff] [review] patch a1922=beltzner
Attachment #423157 -
Flags: approval1.9.2.2? → approval1.9.2.2+
Whiteboard: [needs 192 landing]
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/c803977d8782
Whiteboard: [needs 192 landing]
Assignee | ||
Comment 19•14 years ago
|
||
The previous commit was inadvertently on a relbranch. I backed it out of the relbranch: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/f57f01f6b371 and relanded it on the default branch: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/1e6c05f8071d
Comment 20•14 years ago
|
||
verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.3pre) Gecko/20100319 Namoroka/3.6.3pre
Keywords: verified1.9.2
You need to log in
before you can comment on or make changes to this bug.
Description
•