541668 - blocks in rowspanning cells don't receive events (display:block links unclickable) when no table parts have border or background

Status: VERIFIED FIXED

(Core :: Layout: Tables, defect, P2)

Description

[karl155]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.2) Gecko/20100115 Firefox/3.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.2) Gecko/20100115 Firefox/3.6

I noticed a problem that some links are not clickable in Firefox 3.6. I have traced the problem to a simple example. See attachment.

Reproducible: Always

Comment 1

[karl155]

Attachment: Firefox 3.6 regression - Example 1

Comment 2

[Ria Klaassen (not reading all bugmail)]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20100122 Minefield/3.7a1pre

This regressed in the second half of 2009.

Comment 3

[Alice0775 White]

Regression window for trunk 1.9.3:
works:
http://hg.mozilla.org/mozilla-central/rev/d379a17cbf8f
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091212 Minefield/3.7a1pre ID:20091212045454

broken:
http://hg.mozilla.org/mozilla-central/rev/3ff17b03644e
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091213 Minefield/3.7a1pre ID:20091213045416

pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d379a17cbf8f&tochange=3ff17b03644e

Regression window for branch 1.9.2:
works:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/101b2f5eef9a
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b6pre) Gecko/20091212 Namoroka/3.6b6pre ID:20091212045310

broken:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/5e9329cfac70
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b6pre) Gecko/20091213 Namoroka/3.6b6pre ID:20091213052138

pushlog:
http://hg.mozilla.org/releases/mozilla-1.9.2/pushloghtml?fromchange=101b2f5eef9a&tochange=5e9329cfac70

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Pretty clearly a regression from bug 530686 based on the testcase (particularly that giving other cells a background color fixes it), but it's not clear to me *why*; I suspect there's some other underlying bug not related to that patch.

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Actually, no... I think it is the fault of that patch.  In particular, the change there means |item| is null, which means sortEventBackgrounds in nsTableFrame::DisplayGenericTablePart becomes false rather than true.

Comment 6

[karl155]

I think the new title "display:block links in rowspanning cells sometimes unclickable in rowspanning parts" is wrong. I noticed the problem first with an inner table with onclick events on some td elements. That means there were no a tags at all.

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 423157 [details] [diff] [review]
patch

The testcase could be simpler by just using elementFromPoint, but it doesn't matter. Thanks!

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/dbb25266f4fa

Comment 10

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Thanks for reporting this.  It's now fixed on mozilla-central (1.9.3) nightlies (starting with tomorrow's), and hopefully we'll get it into the 1.9.2 branch for 1.9.2.1 (and thus Firefox 3.6.1).

Comment 13

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

This fixes a pretty bad regression in 3.6 from some last-minute changes, and we really shouldn't ship a major update to 3.6 without this patch; I think this would have been a clear release blocker if we'd seen it before the release.

Comment 16

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 423157 [details] [diff] [review]
patch

a1922=beltzner

Comment 18

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/c803977d8782

Comment 19

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

The previous commit was inadvertently on a relbranch.  I backed it out of the relbranch:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/f57f01f6b371
and relanded it on the default branch:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/1e6c05f8071d

Comment 20

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.3pre) Gecko/20100319 Namoroka/3.6.3pre