543284 - polish some Preferences window icons

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[philippe (part-time)]

Screenshot with some guidelines
http://dev.l-c-n.com/camino/preferences_window/preferences_guide.png

* Security icon:
bug 384725 comment 28 (Stuart)
--> icon is slightly too tall, need to loose 1~2 px to match the square icons.
proposal: shave 1 or 2 px off just below the rounded top

Any other issue ?

* Tabs icon:
bug 384725 comment 28 (Stuart) --> high line.
bug 384725 comment 30 (Smokey) --> close button is not well defined.

proposal: make close button darker & crisper inset and redraw gradient

* Downloads icon:
The proposed new version in bug 384725 was not accepted.
I do like the existing one, however:
- color mismatch with the 'open' icon in the Downloads window (the green is more blueish in the latter).
- size: the existing icon is 2px shorter than the squares ( I don't think this is a huge issue, personally).

proposal:
- redraw icon to use the greens of dl_open.tiff
- size (height, and eventually width to match) ?

----
notes:
1. Technically, the Privacy icons is 1px too tall, it is however barely noticeable, the top of the icon is much lighter (and is small) and nearly blends into the toolbar gradient (Leopard/Snow Leopard).

2. Why do the icons added in bug 384725 include a 24x24 image ? The toolbar cannot be modified by the user.

Comment 1

[philippe (part-time)]

Some work in progress:
- shaving 1px off the Security icon, new Tabs icon
  http://dev.l-c-n.com/camino/preferences_window/pref_window_1px.png
- shaving 2px off the Security icon, new Tabs icon
  http://dev.l-c-n.com/camino/preferences_window/pref_window_2px.png

In both cases: the revised Tabs icon is a wip (close button need som extra love), the Downloads icon has not been touched.
For those wanting to play along, icons:
http://dev.l-c-n.com/camino/preferences_window/Security_wip.zip
http://dev.l-c-n.com/camino/preferences_window/Tabs.tiff.zip

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I kind-of think shaving 2px off makes Security look too squat, just from an examination of the screenshots.

(In reply to comment #0)
> 2. Why do the icons added in bug 384725 include a 24x24 image ? The toolbar
> cannot be modified by the user.

I believe users can still tweak the plist to use the small size even now, but probably when we did the spec for the new icons, it was still customizable (in addition, we were pretty clear we wanted the other toolbar items in both sizes to banish the fuzziness).

Comment 3

[philippe (part-time)]

(In reply to comment #2)
> I kind-of think shaving 2px off makes Security look too squat, just from an
> examination of the screenshots.

I tend to agree. Taking out a 1px slice keeps the existing icon balanced, and it doesn't look that much out of place / too tall anymore.

To pull it off better, I'll have to rebuild the icon - at a minimum the top part. I'll have a look tomorrow how that goes.

(the light angle on the existing icon isn't really right either - it feels coming from an angle instead of from the top).

Comment 4

[philippe (part-time)]

Here is a screen shot of the preferences window with some updated icons:
http://dev.l-c-n.com/preferences_window/Preferences_window_v3.png

* Reworked Tabs icon, with a gradient matching the one in use on (real) tabs.
  This should be ready for review.
* Reworked Downloads icon, colors closer to the dl_open icon (download window).
  Same shape as existing icon, tail is 1px longer.
  Ready for review.
* Security icon: I made the top less fat, allowing for matching height.
  Still needs some polish, stray pixels

Security icon (wip):
http://dev.l-c-n.com/preferences_window/Security_v2.3c.tiff.zip

(In reply to comment #2) 
> I believe users can still tweak the plist to use the small size even now, but
> probably when we did the spec for the new icons, it was still customizable (in
> addition, we were pretty clear we wanted the other toolbar items in both sizes
> to banish the fuzziness).
The small size icons are eventually used by the Finder badged in the prefpane icons, depending on the size of icon display (using the 10.6 slider to change size in icon view mode is sometimes interesting :-).
I'll provide 24x24 icons.

Comment 5

[philippe (part-time)]

Attachment: new Tabs icon

Comment 6

[philippe (part-time)]

Attachment: new Downloads icon

Comment 7

[philippe (part-time)]

a complete redraw of the Security icon:
one of the things that bugged me with the existing Security icon was a top heavy look compared to other icons on the Preference window toolbar.
I remove some black out of the yellow/black strip to make it lighter, and adjust overall height per comments above.

screenshot in context (along with the 2 other refreshed icons):
http://dev.l-c-n.com/camino/preferences_window/preferences-window_v2.5.png

Comment 8

[philippe (part-time)]

Attachment: new Security icon

as shown in context in comment 7

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 424945 [details]
new Tabs icon

This looks really good :-)

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 427712 [details]
new Security icon

Now I think the "arm" of the lock looks too thin; can we find a happy middle between the current icon (too thick) and this?

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 424946 [details]
new Downloads icon

This one is very close.  The bottom is a bit fuzzy compared to the top (and to the bottom of the old one), especially near the point.  If if can be a bit sharper, that would be great.

Comment 12

[philippe (part-time)]

Attachment: Security icon, v4

Addressing review comments, the shackle is a bit more sturdy (thicker).

In context:
http://dev.l-c-n.com/camino/preferences_window/Preferences_Window-v4.png

Comment 13

[philippe (part-time)]

Attachment: Downloads icon, v 1.4

Now with a sharper tip.

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 434772 [details]
Downloads icon, v 1.4

r=ardissone :)

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 434771 [details]
Security icon, v4

This one is better, but it now seems just a bit too thick.

I think this is partly because the edges of the shackle are so dark (in the existing icon, they're lighter) and perhaps because the wrong-light on the existing icon gives it a bit more of a shine.

Can we tweak the shackle a bit more?

Comment 16

[philippe (part-time)]

Attachment: Security icon, v4.2

With a bit of diet, tricking into believe it uses less coloured pixels than it actually does.

In context: 
http://dev.l-c-n.com/camino/preferences_window/Preferences_Window_v4.2.png

Comment 17

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 435073 [details]
Security icon, v4.2

r=ardissone

Comment 18

[Stuart Morgan]

Comment on attachment 424945 [details]
new Tabs icon

sr=smorgan

Comment 19

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk and in the test repo: http://hg.mozilla.org/users/alqahira_ardisson.org/camino-1.9.2-test/rev/eee4d4c2a262

Comment 20

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/d6db9b9628af