524506 - [meta] Improvements to 2008-2009 toolbar icons

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Bug 384725 comment 22 (Stuart):

> Two after-the-fact comments from actually using these; I'm not sure if there's
> any chance of additional tweaks:
> - The shape of the reload arrow was changed somewhat, and it now appears less
> round and more smooshed, which is really bothering me. Could we have the old
> shape with the new contrast?
> - The front step that was added to the house breaks the bottom line that it
> used to share with many other elements in the toolbar, and makes it more busy.
> Can we shave that off?

Bug 384725 comment 28 (Stuart):

> I'm fine with landing these, but some thoughts in case we could get tweaked
> icons for a later version:
> 
> - The Security icon projects up a pixel or two past most of the other pref pane
> icons, and because it's so bulky it seems very noticeable. It would be nice if
> it were a bit shorter to make a better line.
> 
> - The high line on the Tabs icon makes the close button look off-center. Maybe
> if the gradient were less pronounced?

Bug 384725 comment 30 (me):

> 2) I really, really don't like the new Downloads prefPane icon.  It looks
> unbalanced (the head seems far too big), and I'd rather keep the existing one.
> 
> Minor points for future tweaking, in addition to the ones Stuart has already
> mentioned:
> 
> - The close button on the Tabs icon is far less defined in the new version than
> it was in the old one, so it seems to be disappearing into the tab.
> 
> - Next time we totally redo icons, we should also try to get the icon heights
> more consistent in the Downloads window; the Clean Up broom is noticeably
> taller, and Open slightly so.

Bug 384725 comment 31 (philippe):

> >  the Clean Up broom is noticeably taller, and Open slightly so.
> 
> 2px and 1px respectively (large size), the 'Open' one is 'easy' to correct, the
> broom is quite complex.
> 
> One additional point (and I agree on the points already raised):
> I find the dl_reveal a little on the heavy side. I commented on that when Sam
> first showed that icon in bug 450542 comment 16. At the time, I wiped up an
> alternative with a coloured handle.

(Stuart was unable to be placated by the alternate dl_reveal icons and we landed the one from the existing "new" set instead.)

We can file specific bugs as we work on specific icons.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Philippe, do you think you'll have any time to work on any of the issues here for 2.1 (at least the ones that don't involve completely redrawing complex icons)?

Comment 2

[philippe (part-time)]

(In reply to comment #1)
> Philippe, do you think you'll have any time to work on any of the issues here
> for 2.1 (at least the ones that don't involve completely redrawing complex
> icons)?

I can make time certainly. I had been playing a little with the dl_open.tiff file, but what I have can't be used, I left the box-cutters inside the box...
More seriously, do you happen to have multilayer/vector files (.psd) for the recent batch of icons Sam gave in bug 384725 ?

Comment 3

[Samuel Sidler (:ss)]

We didn't get PSDs or vectors for those icons, sadly.

Comment 4

[philippe (part-time)]

(In reply to comment #3)
> We didn't get PSDs or vectors for those icons, sadly.

<sigh></sigh>

----
We'll work with what we have.

For starters, some screenshots, with guides of the (current) downloads window

http://dev.l-c-n.com/camino/downloads_window/download_window-default_small.png
http://dev.l-c-n.com/camino/downloads_window/download_window-default.png
http://dev.l-c-n.com/camino/downloads_window/download_window-p_small.psd
http://dev.l-c-n.com/camino/downloads_window/download_window-p.png
zoomed view in Pixie
http://dev.l-c-n.com/camino/downloads_window/download_window-zoomed.png

both the dl_open and dl_reveal need some tweaking (bring them in line into a square the size of the round icons. The broom is another problem (I'd need to recreate it completely).

I'll look at the Preferences window later.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Are we all done here now?  I think every icon mentioned in comment 0 has been redone now.

Comment 6

[philippe (part-time)]

(In reply to comment #5)
> Are we all done here now?  I think every icon mentioned in comment 0 has been
> redone now.

I think so, atm.
Marking as fixed.