Closed Bug 546812 Opened 12 years ago Closed 11 years ago

Tree items in "Items for Offline Use" dialog have incorrect accessible name

Categories

(Core :: Disability Access APIs, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla7

People

(Reporter: Jamie, Assigned: surkov)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a2pre) Gecko/20100211 Minefield/3.7a2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.2pre) Gecko/20100214 Lanikai/3.1b1pre

In the Items for Offline Use dialog, the tree items (for each folder) inherit the accessible name of the tree instead of containing the name of the particular folder.

Reproducible: Always

Steps to Reproduce:
1. Open Thunderbird.
2. Open the "Items for Offline Use" dialog: File menu -> Offline -> Download/Sync Now... -> Select... button.
3. Observe that the accessible name of the tree itself is "Choose mail folders and newsgroups for offline use.". This is determined from the associated label.
4. Examine the accessible name of one of the tree items.
5. Examine the first table cell (first child) beneath the same tree item.
Actual Results:  
The name of the tree item (step 4) is "Choose mail folders and newsgroups for offline use." The name of its first child (step 5) is the name of the folder represented by the tree item.

Expected Results:  
The name of the tree item (step 4) should be the name of the folder represented by the tree item; i.e. the same as the name of the first table cell (step 5).

This causes screen readers to report "Choose mail folders and newsgroups for offline use." for every tree item in this tree, which is not very useful.

The ID of this tree is "synchronizeTree".
Keywords: access
Blocks: namea11y
Status: UNCONFIRMED → NEW
Ever confirmed: true
Duplicate of this bug: 660330
Attached patch patchSplinter Review
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #536264 - Flags: review?(trev.saunders)
Comment on attachment 536264 [details] [diff] [review]
patch


>+  nsCOMPtr<nsITreeColumns> columns;
>+  mTree->GetColumns(getter_AddRefs(columns));
>+  nsCOMPtr<nsITreeColumn> primaryColumn;
>+  if (columns) {
>+    columns->GetPrimaryColumn(getter_AddRefs(primaryColumn));
>+    if (primaryColumn)
>+      GetCellName(primaryColumn, aName);

why not declare primaryColumn inside the first if?  since you only need it  if you have columns, and so you save the useless construction in some cases?

>+        var tree = {
>+          role: ROLE_OUTLINE,
>+          children: [
>+            {
>+              role: ROLE_LIST
>+            },
>+            {
>+              role: ROLE_OUTLINEITEM,
>+              children: [],
>+              name: "row1col"

what is this _col about? its a tree so there's only one "column" right?
Attachment #536264 - Flags: review?(trev.saunders) → review+
(In reply to comment #3)

> why not declare primaryColumn inside the first if?  since you only need it 
> if you have columns, and so you save the useless construction in some cases?

thanks

> what is this _col about? its a tree so there's only one "column" right?

it's just autogenerated name
landed http://hg.mozilla.org/mozilla-central/rev/78026ebff8b3
Assignee: surkov.alexander → nobody
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Component: General → Disability Access APIs
Flags: in-testsuite+
Product: Thunderbird → Core
QA Contact: general → accessibility-apis
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
This causes a regression in about:config. The items there are no longer read by NVDA when up and down arrowing. Alex, do you need a separate bug for this?
Marco, please file new bug for this.
Depends on: 664376
Filed bug 664376 for the regression.
Assignee: nobody → surkov.alexander
You need to log in before you can comment on or make changes to this bug.