Last Comment Bug 546812 - Tree items in "Items for Offline Use" dialog have incorrect accessible name
: Tree items in "Items for Offline Use" dialog have incorrect accessible name
Status: RESOLVED FIXED
: access
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: x86 Windows 7
: -- normal (vote)
: mozilla7
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
: 660330 (view as bug list)
Depends on: 664376
Blocks: namea11y
  Show dependency treegraph
 
Reported: 2010-02-17 16:52 PST by James Teh [:Jamie]
Modified: 2011-06-15 01:20 PDT (History)
3 users (show)
surkov.alexander: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (10.84 KB, patch)
2011-05-31 03:23 PDT, alexander :surkov
tbsaunde+mozbugs: review+
Details | Diff | Splinter Review

Description James Teh [:Jamie] 2010-02-17 16:52:49 PST
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a2pre) Gecko/20100211 Minefield/3.7a2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.2pre) Gecko/20100214 Lanikai/3.1b1pre

In the Items for Offline Use dialog, the tree items (for each folder) inherit the accessible name of the tree instead of containing the name of the particular folder.

Reproducible: Always

Steps to Reproduce:
1. Open Thunderbird.
2. Open the "Items for Offline Use" dialog: File menu -> Offline -> Download/Sync Now... -> Select... button.
3. Observe that the accessible name of the tree itself is "Choose mail folders and newsgroups for offline use.". This is determined from the associated label.
4. Examine the accessible name of one of the tree items.
5. Examine the first table cell (first child) beneath the same tree item.
Actual Results:  
The name of the tree item (step 4) is "Choose mail folders and newsgroups for offline use." The name of its first child (step 5) is the name of the folder represented by the tree item.

Expected Results:  
The name of the tree item (step 4) should be the name of the folder represented by the tree item; i.e. the same as the name of the first table cell (step 5).

This causes screen readers to report "Choose mail folders and newsgroups for offline use." for every tree item in this tree, which is not very useful.

The ID of this tree is "synchronizeTree".
Comment 1 alexander :surkov 2011-05-31 01:44:57 PDT
*** Bug 660330 has been marked as a duplicate of this bug. ***
Comment 2 alexander :surkov 2011-05-31 03:23:08 PDT
Created attachment 536264 [details] [diff] [review]
patch
Comment 3 Trevor Saunders (:tbsaunde) 2011-06-08 16:04:46 PDT
Comment on attachment 536264 [details] [diff] [review]
patch


>+  nsCOMPtr<nsITreeColumns> columns;
>+  mTree->GetColumns(getter_AddRefs(columns));
>+  nsCOMPtr<nsITreeColumn> primaryColumn;
>+  if (columns) {
>+    columns->GetPrimaryColumn(getter_AddRefs(primaryColumn));
>+    if (primaryColumn)
>+      GetCellName(primaryColumn, aName);

why not declare primaryColumn inside the first if?  since you only need it  if you have columns, and so you save the useless construction in some cases?

>+        var tree = {
>+          role: ROLE_OUTLINE,
>+          children: [
>+            {
>+              role: ROLE_LIST
>+            },
>+            {
>+              role: ROLE_OUTLINEITEM,
>+              children: [],
>+              name: "row1col"

what is this _col about? its a tree so there's only one "column" right?
Comment 4 alexander :surkov 2011-06-08 19:10:14 PDT
(In reply to comment #3)

> why not declare primaryColumn inside the first if?  since you only need it 
> if you have columns, and so you save the useless construction in some cases?

thanks

> what is this _col about? its a tree so there's only one "column" right?

it's just autogenerated name
Comment 5 alexander :surkov 2011-06-09 02:13:43 PDT
landed http://hg.mozilla.org/mozilla-central/rev/78026ebff8b3
Comment 6 Marco Zehe (:MarcoZ) on PTO until August 15 2011-06-14 06:09:19 PDT
This causes a regression in about:config. The items there are no longer read by NVDA when up and down arrowing. Alex, do you need a separate bug for this?
Comment 7 alexander :surkov 2011-06-15 01:02:44 PDT
Marco, please file new bug for this.
Comment 8 Marco Zehe (:MarcoZ) on PTO until August 15 2011-06-15 01:20:14 PDT
Filed bug 664376 for the regression.

Note You need to log in before you can comment on or make changes to this bug.