54746 - Language encodings in font prefs dialog not sorted on non-English locales

Status: REOPENED

(Firefox :: Preferences, defect, P3)

Description

[bobj]

Language encodings are listed in a seemingly random order.
The order be alphabetical (and therefore change with localization).
As a special case, User-Defined should be last.

Comment 1

[Erik van der Poel]

Accepting bug, for Future. Please nominate for RTM if desired.

Comment 2

[bobj]

Forgot build info in my previous comment: Build 2000092808 on US Win95.

Comment 3

[bobj]

cc'd rchen for L10N FYI.  If this bug gets fixed, then list will need
to be reordered for each localization.

Comment 4

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 5

[Yuying Long]

The Language encodings still not looks been sorted on both 02-05-2001 Mtrunk and 
01-31-Mtest-ja build.

Comment 6

[nhottanscp]

Reassign to jbetak.

Comment 7

[Frank Tang]

erik resign. reassign all his bug to ftang for now.

Comment 8

[Frank Tang]

mark all future new as assigned after move from erik to ftang

Comment 9

[Adam Hauner]

-> to default owner (rather than ftang's WONTFIX)

Comment 10

[Jungshik Shin]

It's not random, but listed in the order we list them in xul files. I'm not sure
alphabetic sorting is a good thing, though. How about this?

1. localizable top element : Japanese for ja, Western for en,fr, de, etc
2. Alphabetic listing of the rest (consider what collation rules to use...)
3. Unicode and User-defined

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Firefox sorts the available list of languages alphabetically by name.

http://hg.mozilla.org/mozilla-central/annotate/0a91da5f5eab/browser/components/preferences/languages.js#l103

Comment 13

[Simon Montagu :smontagu]

This isn't fixed. The code linked in comment 12 sorts the list of languages for the "Choose your preferred language for displaying pages" dialog. This bug is about the list of languages for font preferences.

Comment 14

[Jonathan Kew (:jfkthame)]

(In reply to Jungshik Shin from comment #10)
> It's not random, but listed in the order we list them in xul files. I'm not
> sure
> alphabetic sorting is a good thing, though. How about this?
> 
> 1. localizable top element : Japanese for ja, Western for en,fr, de, etc
> 2. Alphabetic listing of the rest (consider what collation rules to use...)
> 3. Unicode and User-defined

Currently, we have Simplified Chinese and the two Traditional Chinese entries sorted (in the English localization) as if by "Chinese", so that all three appear together, and it'd be nice to maintain that, as well as the special-case for "Other Writing Systems" (formerly "Unicode") that goes at the end of the list. So any sorting we do for the localized names will need to be aware of these special cases somehow.

Comment 15

[Henri Sivonen (:hsivonen)]

(In reply to Jonathan Kew (:jfkthame) from comment #14)
> Currently, we have Simplified Chinese and the two Traditional Chinese
> entries sorted (in the English localization) as if by "Chinese", so that all
> three appear together, and it'd be nice to maintain that

In the case of the Character Encoding submenu of the View menu, this is accomplished by labeling the entries "Chinese, Simplified" and "Chinese, Traditional" to make sure they have a prefix for sorting. (I'm not actually sure if they have a common prefix in the Simplified Chinese and Traditional Chinese localizations themselves, though!)

Comment 16

[:Gijs (he/him)]

The list is sorted in en-US, as implied in the last few comments.